Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Ghimiray, Himal Prasad" <himal.prasad.ghimiray@intel.com>
To: Tejas Upadhyay <tejas.upadhyay@intel.com>,
	<intel-xe@lists.freedesktop.org>
Cc: <matthew.brost@intel.com>
Subject: Re: [PATCH 1/4] drm/xe: Clean up kernel-doc typos in VRAM manager
Date: Thu, 1 Oct 2026 15:55:57 +0530	[thread overview]
Message-ID: <1891dfc7-4606-43ec-8646-6f08c82ee0b2@intel.com> (raw)
In-Reply-To: <20261001094518.1493651-7-tejas.upadhyay@intel.com>



On 01-10-2026 15:15, Tejas Upadhyay wrote:
> Fix grammatical errors and misspelled hardware probing
> definitions within the TTM VRAM manager structures.
> 
> Signed-off-by: Tejas Upadhyay <tejas.upadhyay@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_ttm_vram_mgr.c       | 6 +++---
>   drivers/gpu/drm/xe/xe_ttm_vram_mgr_types.h | 2 +-
>   2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_ttm_vram_mgr.c b/drivers/gpu/drm/xe/xe_ttm_vram_mgr.c
> index 9a514d983e90..4c5837cdb996 100644
> --- a/drivers/gpu/drm/xe/xe_ttm_vram_mgr.c
> +++ b/drivers/gpu/drm/xe/xe_ttm_vram_mgr.c
> @@ -886,11 +886,11 @@ static struct xe_vram_region *xe_ttm_vram_addr_to_region(struct xe_device *xe, u
>   }
>   
>   /**
> - * xe_ttm_vram_handle_addr_fault - Handle vram physical address error flaged
> + * xe_ttm_vram_handle_addr_fault - Handle vram physical address error flagged
>    * @xe: pointer to parent device
>    * @addr: physical faulty address
>    *
> - * Handle the physcial faulty address error on specific tile.
> + * Handle the physical faulty address error on specific tile.
>    *
>    * Returns 0 for success, negative error code otherwise as follow:
>    * * %-EIO - critical BO or address outside any VRAM region; next action is reset.
> @@ -953,7 +953,7 @@ EXPORT_SYMBOL(xe_ttm_vram_handle_addr_fault);
>    * debugfs interface for testing page offlining.
>    *
>    * Note: Executing this test will permanently retire the allocated
> - * memory tracking pages. The driver must be rebinded (unbind and bind)
> + * memory tracking pages. The driver must be rebound (unbind and bind)
>    * post-test execution to reclaim the reserved space, as these pages
>    * cannot be freed or reclaimed dynamically while the current instance
>    * remains active.
> diff --git a/drivers/gpu/drm/xe/xe_ttm_vram_mgr_types.h b/drivers/gpu/drm/xe/xe_ttm_vram_mgr_types.h
> index efcf3e1d4e80..95a427e3b0a7 100644
> --- a/drivers/gpu/drm/xe/xe_ttm_vram_mgr_types.h
> +++ b/drivers/gpu/drm/xe/xe_ttm_vram_mgr_types.h
> @@ -27,7 +27,7 @@ struct xe_ttm_vram_mgr {
>   	struct list_head queued_pages;
>   	/** @n_queued_pages: Number of queued pages */
>   	u16 n_queued_pages;
> -	/** @visible_size: Proped size of the CPU visible portion */
> +	/** @visible_size: Probed size of the CPU visible portion */

Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>

>   	u64 visible_size;
>   	/** @visible_avail: CPU visible portion still unallocated */
>   	u64 visible_avail;


  reply	other threads:[~2026-10-01 10:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-01  9:45 [PATCH 0/4] Followup fixes for memory page offline Tejas Upadhyay
2026-10-01  9:45 ` [PATCH 1/4] drm/xe: Clean up kernel-doc typos in VRAM manager Tejas Upadhyay
2026-10-01 10:25   ` Ghimiray, Himal Prasad [this message]
2026-10-01  9:45 ` [PATCH 2/4] drm/xe: Re-validate external pin under resv lock before VRAM purge Tejas Upadhyay
2026-10-05  6:58   ` Ghimiray, Himal Prasad
2026-10-01  9:45 ` [PATCH 3/4] drm/xe: Drop RCU list handling for VRAM bad-page tracking, use mgr->lock Tejas Upadhyay
2026-10-01 10:26   ` Ghimiray, Himal Prasad
2026-10-01  9:45 ` [PATCH 4/4] drm/xe: Keep VRAM fault injection within the usable range Tejas Upadhyay
2026-10-01 10:01   ` sashiko-bot
2026-10-05  6:13     ` Upadhyay, Tejas
2026-10-01 10:27   ` Ghimiray, Himal Prasad
2026-10-01  9:53 ` ✓ CI.KUnit: success for Followup fixes for memory page offline Patchwork
2026-10-01 13:19 ` ✓ Xe.CI.BAT: " Patchwork
2026-10-01 17:19 ` ✗ Xe.CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1891dfc7-4606-43ec-8646-6f08c82ee0b2@intel.com \
    --to=himal.prasad.ghimiray@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.brost@intel.com \
    --cc=tejas.upadhyay@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox