Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe: remove unmatched xe_vm_unlock() from __xe_exec_queue_init()
@ 2025-05-30  8:48 Maciej Patelczyk
  2025-05-30 10:22 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (8 more replies)
  0 siblings, 9 replies; 13+ messages in thread
From: Maciej Patelczyk @ 2025-05-30  8:48 UTC (permalink / raw)
  To: intel-xe
  Cc: niranjana.vishwanathapura, matthew.brost, maarten.lankhorst,
	Maciej Patelczyk

There is unmatched xe_vm_unlock() in the __xe_exec_queue_init().
Leftover from fbeaad071a98 ("drm/xe: Create LRC BO without VM")

Fixes: fbeaad071a98 ("drm/xe: Create LRC BO without VM")
Signed-off-by: Maciej Patelczyk <maciej.patelczyk@intel.com>
---
 drivers/gpu/drm/xe/xe_exec_queue.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_exec_queue.c b/drivers/gpu/drm/xe/xe_exec_queue.c
index 32c6923df7c3..fee22358cc09 100644
--- a/drivers/gpu/drm/xe/xe_exec_queue.c
+++ b/drivers/gpu/drm/xe/xe_exec_queue.c
@@ -114,7 +114,6 @@ static struct xe_exec_queue *__xe_exec_queue_alloc(struct xe_device *xe,
 
 static int __xe_exec_queue_init(struct xe_exec_queue *q)
 {
-	struct xe_vm *vm = q->vm;
 	int i, err;
 	u32 flags = 0;
 
@@ -136,7 +135,7 @@ static int __xe_exec_queue_init(struct xe_exec_queue *q)
 		q->lrc[i] = xe_lrc_create(q->hwe, q->vm, SZ_16K, q->msix_vec, flags);
 		if (IS_ERR(q->lrc[i])) {
 			err = PTR_ERR(q->lrc[i]);
-			goto err_unlock;
+			goto err_lrc;
 		}
 	}
 
@@ -146,9 +145,6 @@ static int __xe_exec_queue_init(struct xe_exec_queue *q)
 
 	return 0;
 
-err_unlock:
-	if (vm)
-		xe_vm_unlock(vm);
 err_lrc:
 	for (i = i - 1; i >= 0; --i)
 		xe_lrc_put(q->lrc[i]);
-- 
2.35.0


^ permalink raw reply related	[flat|nested] 13+ messages in thread
* [PATCH] drm/xe: remove unmatched xe_vm_unlock() from __xe_exec_queue_init()
@ 2025-05-30 13:56 Maciej Patelczyk
  2025-05-30 21:02 ` Matthew Brost
  0 siblings, 1 reply; 13+ messages in thread
From: Maciej Patelczyk @ 2025-05-30 13:56 UTC (permalink / raw)
  To: intel-xe
  Cc: niranjana.vishwanathapura, matthew.brost, maarten.lankhorst,
	jonathan.cavitt, Maciej Patelczyk

There is unmatched xe_vm_unlock() in the __xe_exec_queue_init().
Leftover from commit fbeaad071a98 ("drm/xe: Create LRC BO without VM")

Fixes: fbeaad071a98 ("drm/xe: Create LRC BO without VM")
Signed-off-by: Maciej Patelczyk <maciej.patelczyk@intel.com>
Reviewed-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
---
 drivers/gpu/drm/xe/xe_exec_queue.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_exec_queue.c b/drivers/gpu/drm/xe/xe_exec_queue.c
index 32c6923df7c3..fee22358cc09 100644
--- a/drivers/gpu/drm/xe/xe_exec_queue.c
+++ b/drivers/gpu/drm/xe/xe_exec_queue.c
@@ -114,7 +114,6 @@ static struct xe_exec_queue *__xe_exec_queue_alloc(struct xe_device *xe,
 
 static int __xe_exec_queue_init(struct xe_exec_queue *q)
 {
-	struct xe_vm *vm = q->vm;
 	int i, err;
 	u32 flags = 0;
 
@@ -136,7 +135,7 @@ static int __xe_exec_queue_init(struct xe_exec_queue *q)
 		q->lrc[i] = xe_lrc_create(q->hwe, q->vm, SZ_16K, q->msix_vec, flags);
 		if (IS_ERR(q->lrc[i])) {
 			err = PTR_ERR(q->lrc[i]);
-			goto err_unlock;
+			goto err_lrc;
 		}
 	}
 
@@ -146,9 +145,6 @@ static int __xe_exec_queue_init(struct xe_exec_queue *q)
 
 	return 0;
 
-err_unlock:
-	if (vm)
-		xe_vm_unlock(vm);
 err_lrc:
 	for (i = i - 1; i >= 0; --i)
 		xe_lrc_put(q->lrc[i]);
-- 
2.35.0


^ permalink raw reply related	[flat|nested] 13+ messages in thread
end of thread, other threads:[~2025-05-31 18:12 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-30  8:48 [PATCH] drm/xe: remove unmatched xe_vm_unlock() from __xe_exec_queue_init() Maciej Patelczyk
2025-05-30 10:22 ` ✓ CI.Patch_applied: success for " Patchwork
2025-05-30 10:22 ` ✗ CI.checkpatch: warning " Patchwork
2025-05-30 10:23 ` ✓ CI.KUnit: success " Patchwork
2025-05-30 10:33 ` ✓ CI.Build: " Patchwork
2025-05-30 10:36 ` ✓ CI.Hooks: " Patchwork
2025-05-30 10:37 ` ✓ CI.checksparse: " Patchwork
2025-05-30 11:08 ` ✓ Xe.CI.BAT: " Patchwork
2025-05-30 14:07 ` [PATCH] " Cavitt, Jonathan
2025-05-30 14:22   ` Maciej Patelczyk
2025-05-31 18:11 ` ✗ Xe.CI.Full: failure for " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2025-05-30 13:56 [PATCH] " Maciej Patelczyk
2025-05-30 21:02 ` Matthew Brost

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox