Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Oak Zeng <oak.zeng@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: matthew.d.roper@intel.com, lucas.demarchi@intel.com
Subject: [Intel-xe] [PATCH] drm/xe: Implement HW workaround 14016763929
Date: Thu,  3 Aug 2023 15:01:49 -0400	[thread overview]
Message-ID: <20230803190149.2637666-1-oak.zeng@intel.com> (raw)

To workaround a HW bug on DG2, driver is required to map the whole
ppgtt virtual address space before GPU workload submission. Thus
set the XE_VM_FLAG_SCRATCH_PAGE flag during vm create so the whole
address space is mapped to point to scratch page.

Signed-off-by: Oak Zeng <oak.zeng@intel.com>
---
 drivers/gpu/drm/xe/Makefile        | 2 +-
 drivers/gpu/drm/xe/xe_vm.c         | 5 +++++
 drivers/gpu/drm/xe/xe_wa_oob.rules | 1 +
 3 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile
index e79624ab2cb3..e6a05d35c931 100644
--- a/drivers/gpu/drm/xe/Makefile
+++ b/drivers/gpu/drm/xe/Makefile
@@ -37,7 +37,7 @@ quiet_cmd_wa_oob = GEN     $(notdir $(generated_oob))
 $(generated_oob) &: $(obj)/xe_gen_wa_oob $(srctree)/$(src)/xe_wa_oob.rules
 	$(call cmd,wa_oob)
 
-$(obj)/xe_guc.o $(obj)/xe_wa.o $(obj)/xe_ring_ops.o: $(generated_oob)
+$(obj)/xe_guc.o $(obj)/xe_wa.o $(obj)/xe_ring_ops.o $(obj)/xe_vm.o: $(generated_oob)
 
 # Please keep these build lists sorted!
 
diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
index cb28dbc2bdbb..b045bb341a5c 100644
--- a/drivers/gpu/drm/xe/xe_vm.c
+++ b/drivers/gpu/drm/xe/xe_vm.c
@@ -29,6 +29,8 @@
 #include "xe_res_cursor.h"
 #include "xe_sync.h"
 #include "xe_trace.h"
+#include "generated/xe_wa_oob.h"
+#include "xe_wa.h"
 
 #define TEST_VM_ASYNC_OPS_ERROR
 
@@ -1235,6 +1237,9 @@ struct xe_vm *xe_vm_create(struct xe_device *xe, u32 flags)
 
 	INIT_LIST_HEAD(&vm->extobj.list);
 
+	if (XE_WA(xe_root_mmio_gt(xe), 14016763929))
+		flags |= XE_VM_FLAG_SCRATCH_PAGE;
+
 	if (!(flags & XE_VM_FLAG_MIGRATION))
 		xe_device_mem_access_get(xe);
 
diff --git a/drivers/gpu/drm/xe/xe_wa_oob.rules b/drivers/gpu/drm/xe/xe_wa_oob.rules
index 15c23813398a..6fc68c592ca8 100644
--- a/drivers/gpu/drm/xe/xe_wa_oob.rules
+++ b/drivers/gpu/drm/xe/xe_wa_oob.rules
@@ -15,3 +15,4 @@
 18020744125	PLATFORM(PVC)
 1509372804	PLATFORM(PVC), GRAPHICS_STEP(A0, C0)
 1409600907	GRAPHICS_VERSION_RANGE(1200, 1250)
+14016763929	PLATFORM(DG2)
-- 
2.26.3


             reply	other threads:[~2023-08-03 18:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-03 19:01 Oak Zeng [this message]
2023-08-03 18:54 ` [Intel-xe] ✓ CI.Patch_applied: success for drm/xe: Implement HW workaround 14016763929 Patchwork
2023-08-03 18:54 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-08-03 18:55 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-08-03 18:59 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-08-03 18:59 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-08-03 19:00 ` [Intel-xe] ✗ CI.checksparse: warning " Patchwork
2023-08-03 19:10 ` [Intel-xe] [PATCH] " Souza, Jose
2023-08-03 19:53   ` Zeng, Oak
2023-08-04 18:29     ` Welty, Brian
2023-08-04 20:08       ` Zeng, Oak
2023-08-04  8:29 ` [Intel-xe] ○ CI.BAT: info for " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2023-08-04 20:44 [Intel-xe] [PATCH] " Oak Zeng
2023-08-04 20:42 ` Souza, Jose
2023-08-04 20:51 ` Welty, Brian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230803190149.2637666-1-oak.zeng@intel.com \
    --to=oak.zeng@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    --cc=matthew.d.roper@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox