Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: jani.nikula@intel.com,
	"Jouni Högander" <jouni.hogander@intel.com>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>
Subject: [Intel-xe] [CI 2/9] drm/i915/irq: add dg1_de_irq_postinstall()
Date: Thu, 17 Aug 2023 11:24:30 +0300	[thread overview]
Message-ID: <20230817082437.3116208-3-jani.nikula@intel.com> (raw)
In-Reply-To: <20230817082437.3116208-1-jani.nikula@intel.com>

Add a dedicated de postinstall function.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/cb6bb860fb7596d6b37c3e1e4c7657064d2d747a.1691509966.git.jani.nikula@intel.com
(cherry picked from commit 1007337f5413259cb1c410e66bf980dd8adba62f)
Reviewed-by: Jouni Högander <jouni.hogander@intel.com>
---
 .../gpu/drm/i915/display/intel_display_irq.c    | 17 ++++++++++++++++-
 .../gpu/drm/i915/display/intel_display_irq.h    |  2 +-
 drivers/gpu/drm/i915/i915_irq.c                 | 11 +----------
 3 files changed, 18 insertions(+), 12 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_irq.c b/drivers/gpu/drm/i915/display/intel_display_irq.c
index 168f6d4ce208..a706ba740dd6 100644
--- a/drivers/gpu/drm/i915/display/intel_display_irq.c
+++ b/drivers/gpu/drm/i915/display/intel_display_irq.c
@@ -1666,7 +1666,7 @@ void gen8_de_irq_postinstall(struct drm_i915_private *dev_priv)
 	}
 }
 
-void mtp_irq_postinstall(struct drm_i915_private *i915)
+static void mtp_irq_postinstall(struct drm_i915_private *i915)
 {
 	struct intel_uncore *uncore = &i915->uncore;
 	u32 sde_mask = SDE_GMBUS_ICP | SDE_PICAINTERRUPT;
@@ -1699,6 +1699,21 @@ void gen11_de_irq_postinstall(struct drm_i915_private *dev_priv)
 			   GEN11_DISPLAY_IRQ_ENABLE);
 }
 
+void dg1_de_irq_postinstall(struct drm_i915_private *i915)
+{
+	if (!HAS_DISPLAY(i915))
+		return;
+
+	if (DISPLAY_VER(i915) >= 14)
+		mtp_irq_postinstall(i915);
+	else
+		icp_irq_postinstall(i915);
+
+	gen8_de_irq_postinstall(i915);
+	intel_uncore_write(&i915->uncore, GEN11_DISPLAY_INT_CTL,
+			   GEN11_DISPLAY_IRQ_ENABLE);
+}
+
 void intel_display_irq_init(struct drm_i915_private *i915)
 {
 	i915->drm.vblank_disable_immediate = true;
diff --git a/drivers/gpu/drm/i915/display/intel_display_irq.h b/drivers/gpu/drm/i915/display/intel_display_irq.h
index 8a2d069d3aac..ce190557826b 100644
--- a/drivers/gpu/drm/i915/display/intel_display_irq.h
+++ b/drivers/gpu/drm/i915/display/intel_display_irq.h
@@ -62,8 +62,8 @@ void ibx_irq_postinstall(struct drm_i915_private *i915);
 void vlv_display_irq_postinstall(struct drm_i915_private *i915);
 void icp_irq_postinstall(struct drm_i915_private *i915);
 void gen8_de_irq_postinstall(struct drm_i915_private *i915);
-void mtp_irq_postinstall(struct drm_i915_private *i915);
 void gen11_de_irq_postinstall(struct drm_i915_private *i915);
+void dg1_de_irq_postinstall(struct drm_i915_private *i915);
 
 u32 i915_pipestat_enable_mask(struct drm_i915_private *i915, enum pipe pipe);
 void i915_enable_pipestat(struct drm_i915_private *i915, enum pipe pipe, u32 status_mask);
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 1723c215dcf6..8c074643b6d1 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -869,16 +869,7 @@ static void dg1_irq_postinstall(struct drm_i915_private *dev_priv)
 
 	GEN3_IRQ_INIT(uncore, GEN11_GU_MISC_, ~gu_misc_masked, gu_misc_masked);
 
-	if (HAS_DISPLAY(dev_priv)) {
-		if (DISPLAY_VER(dev_priv) >= 14)
-			mtp_irq_postinstall(dev_priv);
-		else
-			icp_irq_postinstall(dev_priv);
-
-		gen8_de_irq_postinstall(dev_priv);
-		intel_uncore_write(&dev_priv->uncore, GEN11_DISPLAY_INT_CTL,
-				   GEN11_DISPLAY_IRQ_ENABLE);
-	}
+	dg1_de_irq_postinstall(dev_priv);
 
 	dg1_master_intr_enable(intel_uncore_regs(uncore));
 	intel_uncore_posting_read(uncore, DG1_MSTR_TILE_INTR);
-- 
2.39.2


  parent reply	other threads:[~2023-08-17  8:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-17  8:24 [Intel-xe] [CI 0/9] drm/xe: i915 irq backports + display cleanups Jani Nikula
2023-08-17  8:24 ` [Intel-xe] [CI 1/9] drm/i915/irq: add dedicated intel_display_irq_init() Jani Nikula
2023-08-17  8:24 ` Jani Nikula [this message]
2023-08-17  8:24 ` [Intel-xe] [CI 3/9] drm/i915/irq: add ilk_de_irq_postinstall() Jani Nikula
2023-08-17  8:24 ` [Intel-xe] [CI 4/9] drm/i915/irq: move all PCH irq postinstall calls to display code Jani Nikula
2023-08-17  8:24 ` [Intel-xe] [CI 5/9] fixup! drm/xe/display: Implement display support Jani Nikula
2023-08-17  8:24 ` [Intel-xe] [CI 6/9] " Jani Nikula
2023-08-17  8:24 ` [Intel-xe] [CI 7/9] " Jani Nikula
2023-08-17  8:24 ` [Intel-xe] [CI 8/9] " Jani Nikula
2023-08-17  8:24 ` [Intel-xe] [CI 9/9] " Jani Nikula
2023-08-17  8:27 ` [Intel-xe] ✓ CI.Patch_applied: success for drm/xe: i915 irq backports + display cleanups (rev3) Patchwork
2023-08-17  8:27 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-08-17  8:28 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-08-17  8:32 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-08-17  8:33 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-08-17  8:33 ` [Intel-xe] ✗ CI.checksparse: warning " Patchwork
2023-08-17  9:01 ` [Intel-xe] ✓ CI.BAT: success " Patchwork
2023-08-17 15:46 ` [Intel-xe] [CI 0/9] drm/xe: i915 irq backports + display cleanups Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230817082437.3116208-3-jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jouni.hogander@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox