Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: jani.nikula@intel.com, "Jouni Högander" <jouni.hogander@intel.com>
Subject: [Intel-xe] [CI 7/9] fixup! drm/xe/display: Implement display support
Date: Thu, 17 Aug 2023 11:24:35 +0300	[thread overview]
Message-ID: <20230817082437.3116208-8-jani.nikula@intel.com> (raw)
In-Reply-To: <20230817082437.3116208-1-jani.nikula@intel.com>

No need to keep a copy of i915_irq.h around. Use the i915 one.

v2: xe_display.h no longer needs to include ext/i915_irq.h either

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Jouni Högander <jouni.hogander@intel.com>
---
 .../gpu/drm/xe/compat-i915-headers/i915_irq.h |  6 +++
 drivers/gpu/drm/xe/display/ext/i915_irq.h     | 54 -------------------
 drivers/gpu/drm/xe/xe_display.c               |  1 -
 3 files changed, 6 insertions(+), 55 deletions(-)
 create mode 100644 drivers/gpu/drm/xe/compat-i915-headers/i915_irq.h
 delete mode 100644 drivers/gpu/drm/xe/display/ext/i915_irq.h

diff --git a/drivers/gpu/drm/xe/compat-i915-headers/i915_irq.h b/drivers/gpu/drm/xe/compat-i915-headers/i915_irq.h
new file mode 100644
index 000000000000..61707a07f91f
--- /dev/null
+++ b/drivers/gpu/drm/xe/compat-i915-headers/i915_irq.h
@@ -0,0 +1,6 @@
+/* SPDX-License-Identifier: MIT */
+/*
+ * Copyright © 2023 Intel Corporation
+ */
+
+#include "../../i915/i915_irq.h"
diff --git a/drivers/gpu/drm/xe/display/ext/i915_irq.h b/drivers/gpu/drm/xe/display/ext/i915_irq.h
deleted file mode 100644
index d7931139d4cd..000000000000
--- a/drivers/gpu/drm/xe/display/ext/i915_irq.h
+++ /dev/null
@@ -1,54 +0,0 @@
-/* SPDX-License-Identifier: MIT */
-/*
- * Copyright © 2019 Intel Corporation
- */
-
-#ifndef __I915_IRQ_H__
-#define __I915_IRQ_H__
-
-#include <linux/types.h>
-
-#include "i915_reg_defs.h"
-
-struct drm_i915_private;
-struct intel_uncore;
-
-bool intel_irqs_enabled(struct drm_i915_private *dev_priv);
-void intel_synchronize_irq(struct drm_i915_private *i915);
-
-void gen3_assert_iir_is_zero(struct intel_uncore *uncore, i915_reg_t reg);
-
-void gen3_irq_reset(struct intel_uncore *uncore, i915_reg_t imr,
-		    i915_reg_t iir, i915_reg_t ier);
-
-void gen3_irq_init(struct intel_uncore *uncore,
-		   i915_reg_t imr, u32 imr_val,
-		   i915_reg_t ier, u32 ier_val,
-		   i915_reg_t iir);
-
-#define GEN8_IRQ_RESET_NDX(uncore, type, which) \
-({ \
-	unsigned int which_ = which; \
-	gen3_irq_reset((uncore), GEN8_##type##_IMR(which_), \
-		       GEN8_##type##_IIR(which_), GEN8_##type##_IER(which_)); \
-})
-
-#define GEN3_IRQ_RESET(uncore, type) \
-	gen3_irq_reset((uncore), type##IMR, type##IIR, type##IER)
-
-#define GEN8_IRQ_INIT_NDX(uncore, type, which, imr_val, ier_val) \
-({ \
-	unsigned int which_ = which; \
-	gen3_irq_init((uncore), \
-		      GEN8_##type##_IMR(which_), imr_val, \
-		      GEN8_##type##_IER(which_), ier_val, \
-		      GEN8_##type##_IIR(which_)); \
-})
-
-#define GEN3_IRQ_INIT(uncore, type, imr_val, ier_val) \
-	gen3_irq_init((uncore), \
-		      type##IMR, imr_val, \
-		      type##IER, ier_val, \
-		      type##IIR)
-
-#endif /* __I915_IRQ_H__ */
diff --git a/drivers/gpu/drm/xe/xe_display.c b/drivers/gpu/drm/xe/xe_display.c
index be4cd6ebbe83..b6b547c4877c 100644
--- a/drivers/gpu/drm/xe/xe_display.c
+++ b/drivers/gpu/drm/xe/xe_display.c
@@ -14,7 +14,6 @@
 #include <drm/drm_managed.h>
 #include <drm/xe_drm.h>
 
-#include "ext/i915_irq.h"
 #include "soc/intel_dram.h"
 #include "intel_acpi.h"
 #include "intel_audio.h"
-- 
2.39.2


  parent reply	other threads:[~2023-08-17  8:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-17  8:24 [Intel-xe] [CI 0/9] drm/xe: i915 irq backports + display cleanups Jani Nikula
2023-08-17  8:24 ` [Intel-xe] [CI 1/9] drm/i915/irq: add dedicated intel_display_irq_init() Jani Nikula
2023-08-17  8:24 ` [Intel-xe] [CI 2/9] drm/i915/irq: add dg1_de_irq_postinstall() Jani Nikula
2023-08-17  8:24 ` [Intel-xe] [CI 3/9] drm/i915/irq: add ilk_de_irq_postinstall() Jani Nikula
2023-08-17  8:24 ` [Intel-xe] [CI 4/9] drm/i915/irq: move all PCH irq postinstall calls to display code Jani Nikula
2023-08-17  8:24 ` [Intel-xe] [CI 5/9] fixup! drm/xe/display: Implement display support Jani Nikula
2023-08-17  8:24 ` [Intel-xe] [CI 6/9] " Jani Nikula
2023-08-17  8:24 ` Jani Nikula [this message]
2023-08-17  8:24 ` [Intel-xe] [CI 8/9] " Jani Nikula
2023-08-17  8:24 ` [Intel-xe] [CI 9/9] " Jani Nikula
2023-08-17  8:27 ` [Intel-xe] ✓ CI.Patch_applied: success for drm/xe: i915 irq backports + display cleanups (rev3) Patchwork
2023-08-17  8:27 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-08-17  8:28 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-08-17  8:32 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-08-17  8:33 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-08-17  8:33 ` [Intel-xe] ✗ CI.checksparse: warning " Patchwork
2023-08-17  9:01 ` [Intel-xe] ✓ CI.BAT: success " Patchwork
2023-08-17 15:46 ` [Intel-xe] [CI 0/9] drm/xe: i915 irq backports + display cleanups Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230817082437.3116208-8-jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jouni.hogander@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox