From: Ashutosh Dixit <ashutosh.dixit@intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [Intel-xe] [PATCH 13/17] drm/xe/oa: Multiplex PERF ops through a single PERF ioctl
Date: Thu, 7 Sep 2023 21:23:44 -0700 [thread overview]
Message-ID: <20230908042348.1592535-14-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20230908042348.1592535-1-ashutosh.dixit@intel.com>
Since we are already mulitplexing multiple perf counter stream types
through the PERF layer, it seems odd to retain separate ioctls for perf
op's (add/remove config). In fact it seems logical to also multiplex these
ops through a single PERF ioctl. This also affords greater flexibility to
add stream specific ops if needed for different perf stream types.
Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
drivers/gpu/drm/xe/xe_device.c | 5 +----
drivers/gpu/drm/xe/xe_perf.c | 32 ++++++++------------------------
drivers/gpu/drm/xe/xe_perf.h | 4 +---
include/uapi/drm/xe_drm.h | 16 ++++++++++------
4 files changed, 20 insertions(+), 37 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
index 8447d1251fa59..75936b7eb3c67 100644
--- a/drivers/gpu/drm/xe/xe_device.c
+++ b/drivers/gpu/drm/xe/xe_device.c
@@ -115,10 +115,7 @@ static const struct drm_ioctl_desc xe_ioctls[] = {
DRM_RENDER_ALLOW),
DRM_IOCTL_DEF_DRV(XE_VM_MADVISE, xe_vm_madvise_ioctl, DRM_RENDER_ALLOW),
- DRM_IOCTL_DEF_DRV(XE_PERF_OPEN, xe_perf_open_ioctl, DRM_RENDER_ALLOW),
- DRM_IOCTL_DEF_DRV(XE_PERF_ADD_CONFIG, xe_perf_add_config_ioctl, DRM_RENDER_ALLOW),
- DRM_IOCTL_DEF_DRV(XE_PERF_REMOVE_CONFIG, xe_perf_remove_config_ioctl, DRM_RENDER_ALLOW),
-
+ DRM_IOCTL_DEF_DRV(XE_PERF, xe_perf_ioctl, DRM_RENDER_ALLOW),
};
static const struct file_operations xe_driver_fops = {
diff --git a/drivers/gpu/drm/xe/xe_perf.c b/drivers/gpu/drm/xe/xe_perf.c
index 0f747af59f245..f8d7eae8fffe0 100644
--- a/drivers/gpu/drm/xe/xe_perf.c
+++ b/drivers/gpu/drm/xe/xe_perf.c
@@ -6,37 +6,21 @@
#include "xe_oa.h"
#include "xe_perf.h"
-int xe_perf_open_ioctl(struct drm_device *dev, void *data, struct drm_file *file)
+int xe_oa_ioctl(struct drm_device *dev, struct drm_xe_perf_param *arg, struct drm_file *file)
{
- struct drm_xe_perf_param *arg = data;
-
- if (arg->extensions)
- return -EINVAL;
-
- switch (arg->perf_type) {
- case XE_PERF_TYPE_OA:
+ switch (arg->perf_op) {
+ case XE_PERF_STREAM_OPEN:
return xe_oa_stream_open_ioctl(dev, (void *)arg->param, file);
- default:
- return -EINVAL;
- }
-}
-
-int xe_perf_add_config_ioctl(struct drm_device *dev, void *data, struct drm_file *file)
-{
- struct drm_xe_perf_param *arg = data;
-
- if (arg->extensions)
- return -EINVAL;
-
- switch (arg->perf_type) {
- case XE_PERF_TYPE_OA:
+ case XE_PERF_ADD_CONFIG:
return xe_oa_add_config_ioctl(dev, (void *)arg->param, file);
+ case XE_PERF_REMOVE_CONFIG:
+ return xe_oa_remove_config_ioctl(dev, (void *)arg->param, file);
default:
return -EINVAL;
}
}
-int xe_perf_remove_config_ioctl(struct drm_device *dev, void *data, struct drm_file *file)
+int xe_perf_ioctl(struct drm_device *dev, void *data, struct drm_file *file)
{
struct drm_xe_perf_param *arg = data;
@@ -45,7 +29,7 @@ int xe_perf_remove_config_ioctl(struct drm_device *dev, void *data, struct drm_f
switch (arg->perf_type) {
case XE_PERF_TYPE_OA:
- return xe_oa_remove_config_ioctl(dev, (void *)arg->param, file);
+ return xe_oa_ioctl(dev, arg, file);
default:
return -EINVAL;
}
diff --git a/drivers/gpu/drm/xe/xe_perf.h b/drivers/gpu/drm/xe/xe_perf.h
index 7ee90491132a0..254cc7cf49fef 100644
--- a/drivers/gpu/drm/xe/xe_perf.h
+++ b/drivers/gpu/drm/xe/xe_perf.h
@@ -11,8 +11,6 @@
struct drm_device;
struct drm_file;
-int xe_perf_open_ioctl(struct drm_device *dev, void *data, struct drm_file *file);
-int xe_perf_add_config_ioctl(struct drm_device *dev, void *data, struct drm_file *file);
-int xe_perf_remove_config_ioctl(struct drm_device *dev, void *data, struct drm_file *file);
+int xe_perf_ioctl(struct drm_device *dev, void *data, struct drm_file *file);
#endif
diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h
index 91aaeab603571..3c15dfe19f427 100644
--- a/include/uapi/drm/xe_drm.h
+++ b/include/uapi/drm/xe_drm.h
@@ -111,9 +111,7 @@ struct xe_user_extension {
#define DRM_XE_WAIT_USER_FENCE 0x0b
#define DRM_XE_VM_MADVISE 0x0c
#define DRM_XE_EXEC_QUEUE_GET_PROPERTY 0x0d
-#define DRM_XE_PERF_OPEN 0x16
-#define DRM_XE_PERF_ADD_CONFIG 0x17
-#define DRM_XE_PERF_REMOVE_CONFIG 0x18
+#define DRM_XE_PERF 0x16
/* Must be kept compact -- no holes */
#define DRM_IOCTL_XE_DEVICE_QUERY DRM_IOWR(DRM_COMMAND_BASE + DRM_XE_DEVICE_QUERY, struct drm_xe_device_query)
@@ -130,9 +128,7 @@ struct xe_user_extension {
#define DRM_IOCTL_XE_EXEC_QUEUE_SET_PROPERTY DRM_IOW(DRM_COMMAND_BASE + DRM_XE_EXEC_QUEUE_SET_PROPERTY, struct drm_xe_exec_queue_set_property)
#define DRM_IOCTL_XE_WAIT_USER_FENCE DRM_IOWR(DRM_COMMAND_BASE + DRM_XE_WAIT_USER_FENCE, struct drm_xe_wait_user_fence)
#define DRM_IOCTL_XE_VM_MADVISE DRM_IOW(DRM_COMMAND_BASE + DRM_XE_VM_MADVISE, struct drm_xe_vm_madvise)
-#define DRM_IOCTL_XE_PERF_OPEN DRM_IOW(DRM_COMMAND_BASE + DRM_XE_PERF_OPEN, struct drm_xe_perf_param)
-#define DRM_IOCTL_XE_PERF_ADD_CONFIG DRM_IOW(DRM_COMMAND_BASE + DRM_XE_PERF_ADD_CONFIG, struct drm_xe_perf_param)
-#define DRM_IOCTL_XE_PERF_REMOVE_CONFIG DRM_IOW(DRM_COMMAND_BASE + DRM_XE_PERF_REMOVE_CONFIG, struct drm_xe_perf_param)
+#define DRM_IOCTL_XE_PERF DRM_IOW(DRM_COMMAND_BASE + DRM_XE_PERF, struct drm_xe_perf_param)
/**
* enum drm_xe_memory_class - Supported memory classes.
@@ -1069,6 +1065,12 @@ enum drm_xe_perf_type {
XE_PERF_TYPE_OA,
};
+enum drm_xe_perf_op {
+ XE_PERF_STREAM_OPEN,
+ XE_PERF_ADD_CONFIG,
+ XE_PERF_REMOVE_CONFIG,
+};
+
/**
* struct drm_xe_perf_param - XE perf layer param
*
@@ -1081,6 +1083,8 @@ struct drm_xe_perf_param {
__u64 extensions;
/** @perf_type: Type, of enum drm_xe_perf_type, of perf stream */
__u64 perf_type;
+ /** @perf_op: Perf op, of enum drm_xe_perf_op */
+ __u64 perf_op;
/** @param: Pointer to actual stream params */
__u64 param;
};
--
2.41.0
next prev parent reply other threads:[~2023-09-08 4:24 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-08 4:23 [Intel-xe] [PATCH 00/17] Add OA functionality to Xe Ashutosh Dixit
2023-09-08 4:23 ` [Intel-xe] [PATCH 01/17] drm/xe/oa: Introduce OA (observability architecture) uapi Ashutosh Dixit
2023-09-08 4:23 ` [Intel-xe] [PATCH 02/17] drm/xe/oa: Add OA types Ashutosh Dixit
2023-09-08 4:23 ` [Intel-xe] [PATCH 03/17] drm/xe/oa: Add registers and GPU commands used by OA Ashutosh Dixit
2023-09-08 4:23 ` [Intel-xe] [PATCH 04/17] drm/xe/oa: Module init/exit and probe/remove Ashutosh Dixit
2023-09-08 4:23 ` [Intel-xe] [PATCH 05/17] drm/xe/oa: Add/remove config ioctl's Ashutosh Dixit
2023-09-08 4:23 ` [Intel-xe] [PATCH 06/17] drm/xe/oa: Start implementing OA stream open ioctl Ashutosh Dixit
2023-09-08 4:23 ` [Intel-xe] [PATCH 07/17] drm/xe/oa: OA stream initialization Ashutosh Dixit
2023-09-08 4:23 ` [Intel-xe] [PATCH 08/17] drm/xe/oa: Expose OA stream fd Ashutosh Dixit
2023-09-08 4:23 ` [Intel-xe] [PATCH 09/17] drm/xe/oa: Read file_operation Ashutosh Dixit
2023-09-08 4:23 ` [Intel-xe] [PATCH 10/17] drm/xe/oa: Implement queries Ashutosh Dixit
2023-09-08 4:23 ` [Intel-xe] [PATCH 11/17] drm/xe/oa: Override GuC RC with OA on PVC Ashutosh Dixit
2023-09-08 4:23 ` [Intel-xe] [PATCH 12/17] drm/xe/perf: "Perf" layer to support multiple perf counter stream types Ashutosh Dixit
2023-09-08 4:23 ` Ashutosh Dixit [this message]
2023-09-08 4:23 ` [Intel-xe] [PATCH 14/17] drm/xe/oa: Simplify OA configs in uapi Ashutosh Dixit
2023-09-08 4:23 ` [Intel-xe] [PATCH 15/17] drm/xe/oa: Remove OA format names from OA uapi Ashutosh Dixit
2023-09-08 4:23 ` [Intel-xe] [PATCH 16/17] drm/xe/oa: Make xe_oa_timestamp_frequency per gt Ashutosh Dixit
2023-09-08 4:23 ` [Intel-xe] [PATCH 17/17] drm/xe/oa: Remove filtering reports on context id Ashutosh Dixit
2023-09-09 1:24 ` Dixit, Ashutosh
2023-11-13 20:22 ` Dixit, Ashutosh
2023-09-08 4:26 ` [Intel-xe] ✓ CI.Patch_applied: success for Add OA functionality to Xe (rev5) Patchwork
2023-09-08 4:27 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-09-08 4:28 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-09-08 4:35 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-09-08 4:35 ` [Intel-xe] ✗ CI.Hooks: failure " Patchwork
2023-09-19 21:18 ` Dixit, Ashutosh
2023-09-08 4:36 ` [Intel-xe] ✓ CI.checksparse: success " Patchwork
2023-09-08 5:10 ` [Intel-xe] ✗ CI.BAT: failure " Patchwork
2023-09-19 21:27 ` Dixit, Ashutosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230908042348.1592535-14-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox