From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: intel-xe@lists.freedesktop.org
Subject: Re: [Intel-xe] [PATCH 17/17] drm/xe/oa: Remove filtering reports on context id
Date: Mon, 13 Nov 2023 12:22:32 -0800 [thread overview]
Message-ID: <87wmulflo7.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <87pm2sqgtm.wl-ashutosh.dixit@intel.com>
On Fri, 08 Sep 2023 18:24:37 -0700, Dixit, Ashutosh wrote:
>
> On Thu, 07 Sep 2023 21:23:48 -0700, Ashutosh Dixit wrote:
> >
>
> Hi Umesh,
>
> > At present XE OA code does not obtain context id's from GuC. Even if these
> > context id's were available it is not clear if included reports for
> > userspace should be filtered on context id's. Till these issues are
> > resolved remove filtering reports based on context id's.
>
> Need more clarity on what we are doing here and why.
>
> > @@ -419,21 +409,10 @@ static int xe_oa_append_reports(struct xe_oa_stream *stream, char __user *buf,
> > * since it's not-uncommon for periodic samples to identify a switch
> > * before any 'context switch' report.
> > */
> > - if (!stream->exec_q || stream->specific_ctx_id == ctx_id ||
> > - stream->oa_buffer.last_ctx_id == stream->specific_ctx_id ||
> > - reason & OAREPORT_REASON_CTX_SWITCH) {
> > - /*
> > - * While filtering for a single context we avoid
> > - * leaking the IDs of other contexts.
> > - */
> > - if (stream->exec_q && stream->specific_ctx_id != ctx_id)
> > - oa_context_id_squash(stream, report32);
> > -
> > + if (!stream->exec_q || reason & OAREPORT_REASON_CTX_SWITCH) {
>
> Also, could you take a look at this? I wasn't sure, should we do this, or
> should we call xe_oa_append_sample() below unconditionally if we are
> removing context filtering.
I have dropped the above if () statement, it's obviously incorrect.
>
> > ret = xe_oa_append_sample(stream, buf, count, offset, report);
> > if (ret)
> > break;
> > -
> > - stream->oa_buffer.last_ctx_id = ctx_id;
> > }
>
> Thanks.
> --
> Ashutosh
next prev parent reply other threads:[~2023-11-13 20:22 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-08 4:23 [Intel-xe] [PATCH 00/17] Add OA functionality to Xe Ashutosh Dixit
2023-09-08 4:23 ` [Intel-xe] [PATCH 01/17] drm/xe/oa: Introduce OA (observability architecture) uapi Ashutosh Dixit
2023-09-08 4:23 ` [Intel-xe] [PATCH 02/17] drm/xe/oa: Add OA types Ashutosh Dixit
2023-09-08 4:23 ` [Intel-xe] [PATCH 03/17] drm/xe/oa: Add registers and GPU commands used by OA Ashutosh Dixit
2023-09-08 4:23 ` [Intel-xe] [PATCH 04/17] drm/xe/oa: Module init/exit and probe/remove Ashutosh Dixit
2023-09-08 4:23 ` [Intel-xe] [PATCH 05/17] drm/xe/oa: Add/remove config ioctl's Ashutosh Dixit
2023-09-08 4:23 ` [Intel-xe] [PATCH 06/17] drm/xe/oa: Start implementing OA stream open ioctl Ashutosh Dixit
2023-09-08 4:23 ` [Intel-xe] [PATCH 07/17] drm/xe/oa: OA stream initialization Ashutosh Dixit
2023-09-08 4:23 ` [Intel-xe] [PATCH 08/17] drm/xe/oa: Expose OA stream fd Ashutosh Dixit
2023-09-08 4:23 ` [Intel-xe] [PATCH 09/17] drm/xe/oa: Read file_operation Ashutosh Dixit
2023-09-08 4:23 ` [Intel-xe] [PATCH 10/17] drm/xe/oa: Implement queries Ashutosh Dixit
2023-09-08 4:23 ` [Intel-xe] [PATCH 11/17] drm/xe/oa: Override GuC RC with OA on PVC Ashutosh Dixit
2023-09-08 4:23 ` [Intel-xe] [PATCH 12/17] drm/xe/perf: "Perf" layer to support multiple perf counter stream types Ashutosh Dixit
2023-09-08 4:23 ` [Intel-xe] [PATCH 13/17] drm/xe/oa: Multiplex PERF ops through a single PERF ioctl Ashutosh Dixit
2023-09-08 4:23 ` [Intel-xe] [PATCH 14/17] drm/xe/oa: Simplify OA configs in uapi Ashutosh Dixit
2023-09-08 4:23 ` [Intel-xe] [PATCH 15/17] drm/xe/oa: Remove OA format names from OA uapi Ashutosh Dixit
2023-09-08 4:23 ` [Intel-xe] [PATCH 16/17] drm/xe/oa: Make xe_oa_timestamp_frequency per gt Ashutosh Dixit
2023-09-08 4:23 ` [Intel-xe] [PATCH 17/17] drm/xe/oa: Remove filtering reports on context id Ashutosh Dixit
2023-09-09 1:24 ` Dixit, Ashutosh
2023-11-13 20:22 ` Dixit, Ashutosh [this message]
2023-09-08 4:26 ` [Intel-xe] ✓ CI.Patch_applied: success for Add OA functionality to Xe (rev5) Patchwork
2023-09-08 4:27 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-09-08 4:28 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-09-08 4:35 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-09-08 4:35 ` [Intel-xe] ✗ CI.Hooks: failure " Patchwork
2023-09-19 21:18 ` Dixit, Ashutosh
2023-09-08 4:36 ` [Intel-xe] ✓ CI.checksparse: success " Patchwork
2023-09-08 5:10 ` [Intel-xe] ✗ CI.BAT: failure " Patchwork
2023-09-19 21:27 ` Dixit, Ashutosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmulflo7.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox