From: Stuart Summers <stuart.summers@intel.com>
Cc: stuart.summers@intel.com, intel-xe@lists.freedesktop.org
Subject: [Intel-xe] [PATCH 1/2] drm/xe: Print devcoredump to drm_info
Date: Tue, 26 Sep 2023 21:20:55 +0000 [thread overview]
Message-ID: <20230926212056.40881-1-stuart.summers@intel.com> (raw)
Currently the devcoredump is available in the file system
for a user. However 1) CI isn't currently set up to dump
this data and 2) if we try to dump this during the driver
load when a failure is observed, the driver will be torn
down before we have a chance to actually read this data.
Add a quick routine to print this out with drm_info as well
if CONFIG_DRM_XE_DEBUG is enabled.
Signed-off-by: Stuart Summers <stuart.summers@intel.com>
---
drivers/gpu/drm/xe/xe_devcoredump.c | 17 ++++++++++++++++-
drivers/gpu/drm/xe/xe_devcoredump.h | 3 +++
2 files changed, 19 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/xe_devcoredump.c b/drivers/gpu/drm/xe/xe_devcoredump.c
index 68abc0b195be..aa41d8e9b602 100644
--- a/drivers/gpu/drm/xe/xe_devcoredump.c
+++ b/drivers/gpu/drm/xe/xe_devcoredump.c
@@ -78,7 +78,11 @@ static ssize_t xe_devcoredump_read(char *buffer, loff_t offset,
iter.remain = count;
ss = &coredump->snapshot;
- p = drm_coredump_printer(&iter);
+
+ if (iter.data)
+ p = drm_coredump_printer(&iter);
+ else
+ p = drm_info_printer(coredump_to_xe(coredump)->drm.dev);
drm_printf(&p, "**** Xe Device Coredump ****\n");
drm_printf(&p, "kernel: " UTS_RELEASE "\n");
@@ -102,6 +106,15 @@ static ssize_t xe_devcoredump_read(char *buffer, loff_t offset,
return count - iter.remain;
}
+/* Print the coredump locally also for debug purposes */
+void
+xe_devcoredump_print(struct xe_devcoredump *coredump)
+{
+#if IS_ENABLED(CONFIG_DRM_XE_DEBUG)
+ xe_devcoredump_read(NULL, 0, 0, coredump, 0);
+#endif
+}
+
static void xe_devcoredump_free(void *data)
{
struct xe_devcoredump *coredump = data;
@@ -192,5 +205,7 @@ void xe_devcoredump(struct xe_exec_queue *q)
dev_coredumpm(xe->drm.dev, THIS_MODULE, coredump, 0, GFP_KERNEL,
xe_devcoredump_read, xe_devcoredump_free);
+
+ xe_devcoredump_print(coredump);
}
#endif
diff --git a/drivers/gpu/drm/xe/xe_devcoredump.h b/drivers/gpu/drm/xe/xe_devcoredump.h
index 6ac218a5c194..ba0c2a7b71b4 100644
--- a/drivers/gpu/drm/xe/xe_devcoredump.h
+++ b/drivers/gpu/drm/xe/xe_devcoredump.h
@@ -8,6 +8,9 @@
struct xe_device;
struct xe_exec_queue;
+struct xe_devcoredump;
+
+void xe_devcoredump_print(struct xe_devcoredump *coredump);
#ifdef CONFIG_DEV_COREDUMP
void xe_devcoredump(struct xe_exec_queue *q);
--
2.34.1
next reply other threads:[~2023-09-26 21:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 21:20 Stuart Summers [this message]
2023-09-26 21:20 ` [Intel-xe] [PATCH 2/2] drm/xe: Add coredump to wa_bb timeouts Stuart Summers
2023-10-04 13:40 ` Rodrigo Vivi
2023-10-05 15:39 ` Summers, Stuart
2023-09-26 21:23 ` [Intel-xe] ✓ CI.Patch_applied: success for series starting with [1/2] drm/xe: Print devcoredump to drm_info Patchwork
2023-09-26 21:23 ` [Intel-xe] ✓ CI.checkpatch: " Patchwork
2023-09-26 21:24 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-09-26 21:31 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-09-26 21:32 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-09-26 21:33 ` [Intel-xe] ✓ CI.checksparse: " Patchwork
2023-09-26 22:05 ` [Intel-xe] ✓ CI.BAT: " Patchwork
2023-10-04 13:37 ` [Intel-xe] [PATCH 1/2] " Rodrigo Vivi
2023-10-05 15:38 ` Summers, Stuart
2023-10-05 16:13 ` Rodrigo Vivi
2023-10-05 16:26 ` Summers, Stuart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230926212056.40881-1-stuart.summers@intel.com \
--to=stuart.summers@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox