Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Stuart Summers <stuart.summers@intel.com>
Cc: stuart.summers@intel.com, intel-xe@lists.freedesktop.org
Subject: [Intel-xe] [PATCH 2/2] drm/xe: Add coredump to wa_bb timeouts
Date: Tue, 26 Sep 2023 21:20:56 +0000	[thread overview]
Message-ID: <20230926212056.40881-2-stuart.summers@intel.com> (raw)
In-Reply-To: <20230926212056.40881-1-stuart.summers@intel.com>

We're seeing some hangs during driver load on some platforms
in CI which are hard to catch manually. As such, add the dump
at the time of the hang.

Signed-off-by: Stuart Summers <stuart.summers@intel.com>
---
 drivers/gpu/drm/xe/xe_gt.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c
index 1aa44d4f9ac1..80ea076197e5 100644
--- a/drivers/gpu/drm/xe/xe_gt.c
+++ b/drivers/gpu/drm/xe/xe_gt.c
@@ -46,6 +46,7 @@
 #include "xe_vm.h"
 #include "xe_wa.h"
 #include "xe_wopcm.h"
+#include "xe_devcoredump.h"
 
 struct xe_gt *xe_gt_alloc(struct xe_tile *tile)
 {
@@ -187,8 +188,10 @@ static int emit_wa_job(struct xe_gt *gt, struct xe_exec_queue *q)
 	xe_bb_free(bb, NULL);
 	if (timeout < 0)
 		return timeout;
-	else if (!timeout)
+	else if (!timeout) {
+		xe_devcoredump(q);
 		return -ETIME;
+	}
 
 	return 0;
 }
-- 
2.34.1


  reply	other threads:[~2023-09-26 21:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-26 21:20 [Intel-xe] [PATCH 1/2] drm/xe: Print devcoredump to drm_info Stuart Summers
2023-09-26 21:20 ` Stuart Summers [this message]
2023-10-04 13:40   ` [Intel-xe] [PATCH 2/2] drm/xe: Add coredump to wa_bb timeouts Rodrigo Vivi
2023-10-05 15:39     ` Summers, Stuart
2023-09-26 21:23 ` [Intel-xe] ✓ CI.Patch_applied: success for series starting with [1/2] drm/xe: Print devcoredump to drm_info Patchwork
2023-09-26 21:23 ` [Intel-xe] ✓ CI.checkpatch: " Patchwork
2023-09-26 21:24 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-09-26 21:31 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-09-26 21:32 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-09-26 21:33 ` [Intel-xe] ✓ CI.checksparse: " Patchwork
2023-09-26 22:05 ` [Intel-xe] ✓ CI.BAT: " Patchwork
2023-10-04 13:37 ` [Intel-xe] [PATCH 1/2] " Rodrigo Vivi
2023-10-05 15:38   ` Summers, Stuart
2023-10-05 16:13     ` Rodrigo Vivi
2023-10-05 16:26       ` Summers, Stuart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230926212056.40881-2-stuart.summers@intel.com \
    --to=stuart.summers@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox