From: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>,
rodrigo.vivi@intel.com
Subject: [PATCH 2/3] drm/xe: Add base balance sysfs attributes
Date: Tue, 19 Dec 2023 15:37:10 +0530 [thread overview]
Message-ID: <20231219100711.645011-2-sujaritha.sundaresan@intel.com> (raw)
In-Reply-To: <20231219100711.645011-1-sujaritha.sundaresan@intel.com>
Add sysfs attributes for base balance in gt.
device/tile#gt#/freq0/balance
|- base_freq_factor
|- base_freq_factor.scale
|- base_rp0_freq
|- base_rpn_freq
Signed-off-by: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
---
drivers/gpu/drm/xe/Makefile | 1 +
drivers/gpu/drm/xe/xe_gt_balance_sysfs.c | 181 +++++++++++++++++++++++
drivers/gpu/drm/xe/xe_gt_balance_sysfs.h | 17 +++
drivers/gpu/drm/xe/xe_gt_freq.c | 3 +
drivers/gpu/drm/xe/xe_pcode_api.h | 5 +
5 files changed, 207 insertions(+)
create mode 100644 drivers/gpu/drm/xe/xe_gt_balance_sysfs.c
create mode 100644 drivers/gpu/drm/xe/xe_gt_balance_sysfs.h
diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile
index 53bd2a8ba1ae..64bfd3d6eab4 100644
--- a/drivers/gpu/drm/xe/Makefile
+++ b/drivers/gpu/drm/xe/Makefile
@@ -87,6 +87,7 @@ xe-y += xe_bb.o \
xe_gt_mcr.o \
xe_gt_pagefault.o \
xe_gt_sysfs.o \
+ xe_gt_balance_sysfs.o \
xe_gt_throttle_sysfs.o \
xe_gt_tlb_invalidation.o \
xe_gt_topology.o \
diff --git a/drivers/gpu/drm/xe/xe_gt_balance_sysfs.c b/drivers/gpu/drm/xe/xe_gt_balance_sysfs.c
new file mode 100644
index 000000000000..054b90ca128d
--- /dev/null
+++ b/drivers/gpu/drm/xe/xe_gt_balance_sysfs.c
@@ -0,0 +1,181 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2023 Intel Corporation
+ */
+
+#include <drm/drm_managed.h>
+
+#include <regs/xe_reg_defs.h>
+#include "xe_device.h"
+#include "xe_gt.h"
+#include "xe_gt_balance_sysfs.h"
+#include "xe_gt_sysfs.h"
+#include "xe_pcode.h"
+#include "xe_pcode_api.h"
+#include "xe_mmio.h"
+
+/**
+ * DOC: Xe GT Balance
+ *
+ * Provides sysfs entries for balance frequency in GT
+ *
+ * device/tile#/gt#/freq0/balance/base_freq_factor - Base frequency factor
+ * device/tile#/gt#/freq0/balance/base_freq_factor.scale - Base frequency factor scale
+ * device/tile#/gt#/freq0/balance/base_rp0_freq - Base Render Performance 0 level frequency
+ * device/tile#//gt#/freq0/balance/base_rpn_freq - Base Render Performance N level frequency
+ */
+
+#define GT_FREQUENCY_MULTIPLIER 50
+
+#define U8_8_VAL_MASK 0xffff
+#define U8_8_SCALE_TO_VALUE "0.00390625"
+
+static struct xe_gt *
+dev_to_gt(struct device *dev)
+{
+ return kobj_to_gt(dev->kobj.parent);
+}
+
+static ssize_t freq_factor_scale_show(struct device *dev,
+ struct device_attribute *attr,
+ char *buff)
+{
+ return sysfs_emit(buff, "%s\n", U8_8_SCALE_TO_VALUE);
+}
+
+static ssize_t base_freq_factor_show(struct device *dev,
+ struct device_attribute *attr,
+ char *buff)
+{
+ struct xe_gt *gt = dev_to_gt(dev);
+ u32 val, mbox;
+ int err;
+
+ mbox = REG_FIELD_PREP(PCODE_MB_COMMAND, PCODE_QOS_MULTIPLIER_GET)
+ | REG_FIELD_PREP(PCODE_MB_PARAM1, PCODE_MBOX_DOMAIN_CHIPLET)
+ | REG_FIELD_PREP(PCODE_MB_PARAM2, PCODE_MBOX_DOMAIN_BASE);
+
+ err = xe_pcode_read(gt, mbox, &val, NULL);
+ if (err)
+ return err;
+
+ val &= U8_8_VAL_MASK;
+
+ return sysfs_emit(buff, "%u\n", val);
+}
+
+static ssize_t base_freq_factor_store(struct device *dev,
+ struct device_attribute *attr,
+ const char *buff, size_t count)
+{
+ struct xe_gt *gt = dev_to_gt(dev);
+ u32 val, mbox;
+ int err;
+
+ err = kstrtou32(buff, 0, &val);
+ if (err)
+ return err;
+
+ if (val > U8_8_VAL_MASK)
+ return -EINVAL;
+
+ mbox = REG_FIELD_PREP(PCODE_MB_COMMAND, PCODE_QOS_MULTIPLIER_SET)
+ | REG_FIELD_PREP(PCODE_MB_PARAM1, PCODE_MBOX_DOMAIN_CHIPLET)
+ | REG_FIELD_PREP(PCODE_MB_PARAM2, PCODE_MBOX_DOMAIN_BASE);
+
+ err = xe_pcode_write(gt, mbox, val);
+ if (err)
+ return err;
+
+ return count;
+}
+static DEVICE_ATTR_RW(base_freq_factor);
+static struct device_attribute dev_attr_base_freq_factor_scale =
+ __ATTR(base_freq_factor.scale, 0444, freq_factor_scale_show, NULL);
+
+static ssize_t base_rp0_freq_show(struct device *dev, struct device_attribute *attr,
+ char *buff)
+{
+ struct xe_gt *gt = dev_to_gt(dev);
+ u32 val, mbox;
+ int err;
+
+ mbox = REG_FIELD_PREP(PCODE_MB_COMMAND, PCODE_FREQUENCY_CONFIG)
+ | REG_FIELD_PREP(PCODE_MB_PARAM1, PCODE_MBOX_FC_SC_READ_FUSED_P0)
+ | REG_FIELD_PREP(PCODE_MB_PARAM2, PCODE_MBOX_DOMAIN_BASE);
+
+ err = xe_pcode_read(gt, mbox, &val, NULL);
+ if (err)
+ return err;
+
+ /* data_out - Fused P0 for domain ID in units of 50 MHz */
+ val *= GT_FREQUENCY_MULTIPLIER;
+
+ return sysfs_emit(buff, "%u\n", val);
+}
+static DEVICE_ATTR_RO(base_rp0_freq);
+
+static ssize_t base_rpn_freq_show(struct device *dev, struct device_attribute *attr,
+ char *buff)
+{
+ struct xe_gt *gt = dev_to_gt(dev);
+ u32 val, mbox;
+ int err;
+
+ mbox = REG_FIELD_PREP(PCODE_MB_COMMAND, PCODE_FREQUENCY_CONFIG)
+ | REG_FIELD_PREP(PCODE_MB_PARAM1, PCODE_MBOX_FC_SC_READ_FUSED_PN)
+ | REG_FIELD_PREP(PCODE_MB_PARAM2, PCODE_MBOX_DOMAIN_BASE);
+
+ err = xe_pcode_read(gt, mbox, &val, NULL);
+ if (err)
+ return err;
+
+ /* data_out - Fused Pn for domain ID in units of 50 MHz */
+ val *= GT_FREQUENCY_MULTIPLIER;
+
+ return sysfs_emit(buff, "%u\n", val);
+}
+static DEVICE_ATTR_RO(base_rpn_freq);
+
+static struct attribute *balance_attrs[] = {
+ &dev_attr_base_freq_factor.attr,
+ &dev_attr_base_freq_factor_scale.attr,
+ &dev_attr_base_rp0_freq.attr,
+ &dev_attr_base_rpn_freq.attr,
+ NULL
+};
+
+static const struct attribute_group balance_group_attrs = {
+ .name = "balance",
+ .attrs = balance_attrs,
+};
+
+static void gt_balance_sysfs_fini(struct drm_device *drm, void *arg)
+{
+ struct xe_gt *gt = arg;
+ struct xe_device *xe = gt_to_xe(gt);
+
+ if (xe->info.platform == XE_PVC)
+ sysfs_remove_group(gt->freq, &balance_group_attrs);
+}
+
+void xe_gt_balance_sysfs_init(struct xe_gt *gt)
+{
+ struct xe_device *xe = gt_to_xe(gt);
+ int err;
+
+ if (xe->info.platform == XE_PVC) {
+ err = sysfs_create_group(gt->freq, &balance_group_attrs);
+ if (err) {
+ drm_warn(&xe->drm, "failed to register throttle sysfs, err: %d\n", err);
+ return;
+ }
+ }
+
+ err = drmm_add_action_or_reset(&xe->drm, gt_balance_sysfs_fini, gt);
+ if (err) {
+ drm_warn(&xe->drm, "%s: drmm_add_action_or_reset failed, err: %d\n",
+ __func__, err);
+ sysfs_remove_group(gt->freq, &balance_group_attrs);
+ }
+}
diff --git a/drivers/gpu/drm/xe/xe_gt_balance_sysfs.h b/drivers/gpu/drm/xe/xe_gt_balance_sysfs.h
new file mode 100644
index 000000000000..39cec5223cf3
--- /dev/null
+++ b/drivers/gpu/drm/xe/xe_gt_balance_sysfs.h
@@ -0,0 +1,17 @@
+/* SPDX-License-Identifier: MIT */
+/*
+ * Copyright © 2023 Intel Corporation
+ */
+
+#ifndef _XE_GT_BALANCE_SYSFS_H_
+#define _XE_GT_BALANCE_SYSFS_H_
+
+#include <drm/drm_managed.h>
+
+#include "xe_device.h"
+#include "xe_gt.h"
+
+void xe_gt_balance_sysfs_init(struct xe_gt *gt);
+
+#endif /* _XE_GT_BALANCE_SYSFS_H_ */
+
diff --git a/drivers/gpu/drm/xe/xe_gt_freq.c b/drivers/gpu/drm/xe/xe_gt_freq.c
index 08eabcafe7bc..5b0e4fc402ec 100644
--- a/drivers/gpu/drm/xe/xe_gt_freq.c
+++ b/drivers/gpu/drm/xe/xe_gt_freq.c
@@ -13,6 +13,7 @@
#include "xe_device_types.h"
#include "xe_gt_sysfs.h"
+#include "xe_gt_balance_sysfs.h"
#include "xe_gt_throttle_sysfs.h"
#include "xe_guc_pc.h"
@@ -215,5 +216,7 @@ void xe_gt_freq_init(struct xe_gt *gt)
drm_warn(&xe->drm, "failed to add freq attrs to %s, err: %d\n",
kobject_name(gt->freq), err);
+ xe_gt_balance_sysfs_init(gt);
+
xe_gt_throttle_sysfs_init(gt);
}
diff --git a/drivers/gpu/drm/xe/xe_pcode_api.h b/drivers/gpu/drm/xe/xe_pcode_api.h
index 4076a4e9daf3..87213b52df4a 100644
--- a/drivers/gpu/drm/xe/xe_pcode_api.h
+++ b/drivers/gpu/drm/xe/xe_pcode_api.h
@@ -49,6 +49,11 @@
/* PCODE_MBOX_DOMAIN_* - mailbox domain IDs */
/* PCODE_FREQUENCY_CONFIG param2 */
#define PCODE_MBOX_DOMAIN_HBM 0x2
+#define PCODE_MBOX_DOMAIN_CHIPLET 0x6
+#define PCODE_MBOX_DOMAIN_BASE 0x8
+#define PCODE_QOS_MULTIPLIER_SET 0x67
+/* See PCODE_MBOX_DOMAIN_* - mailbox domain IDs - param1 and 2 */
+#define PCODE_QOS_MULTIPLIER_GET 0x66
struct pcode_err_decode {
int errno;
--
2.25.1
next prev parent reply other threads:[~2023-12-19 9:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 10:07 [v5 1/3] drm/xe: Add vram frequency sysfs attributes Sujaritha Sundaresan
2023-12-19 9:55 ` ✓ CI.Patch_applied: success for series starting with [v5,1/3] " Patchwork
2023-12-19 9:55 ` ✗ CI.checkpatch: warning " Patchwork
2023-12-19 9:56 ` ✓ CI.KUnit: success " Patchwork
2023-12-19 10:04 ` ✓ CI.Build: " Patchwork
2023-12-19 10:04 ` ✓ CI.Hooks: " Patchwork
2023-12-19 10:05 ` ✓ CI.checksparse: " Patchwork
2023-12-19 10:07 ` Sujaritha Sundaresan [this message]
2023-12-19 10:53 ` [PATCH 2/3] drm/xe: Add base balance " Jani Nikula
2023-12-19 11:04 ` Sundaresan, Sujaritha
2023-12-20 16:56 ` Rodrigo Vivi
2023-12-21 1:50 ` Sundaresan, Sujaritha
2023-12-19 10:07 ` [PATCH 3/3] [RFC] drm/xe: Add media rp0/rpn " Sujaritha Sundaresan
2023-12-19 10:41 ` ✓ CI.BAT: success for series starting with [v5,1/3] drm/xe: Add vram frequency " Patchwork
2023-12-20 14:56 ` [v5 1/3] " Gupta, Anshuman
2023-12-20 15:24 ` Rodrigo Vivi
2023-12-22 3:54 ` Gupta, Anshuman
2023-12-20 16:49 ` Rodrigo Vivi
2023-12-21 1:48 ` Sundaresan, Sujaritha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231219100711.645011-2-sujaritha.sundaresan@intel.com \
--to=sujaritha.sundaresan@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox