Re: [PATCH 02/10] drm/xe: Define Virtual Function Identifier

["Piotr Piórkowski" <piotr.piorkowski@intel.com>]

Michal Wajdeczko <michal.wajdeczko@intel.com> wrote on czw [2023-gru-28 00:58:30 +0100]:
> According to the PCI Express specification, the SR-IOV Virtual
> Functions (VFs) are numbered starting with 1 (VF1, VF2, ...).
> Additionally, both driver and GuC will refer to Physical Function
> (PF) as VF0. Define helper macro to represent VFn and PF.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_sriov_types.h | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_sriov_types.h b/drivers/gpu/drm/xe/xe_sriov_types.h
> index 999a4311b98b..fbeebdb12166 100644
> --- a/drivers/gpu/drm/xe/xe_sriov_types.h
> +++ b/drivers/gpu/drm/xe/xe_sriov_types.h
> @@ -8,6 +8,18 @@
>  
>  #include <linux/build_bug.h>
>  
> +/**
> + * VFID - Virtual Function Identifier
> + * @n: VF number
> + *
> + * Helper macro to represent Virtual Function (VF) Indentifier.

typo

> + * VFID(0) is used as alias to the PFID that represents Physical Function.
> + *
> + * Note: According to PCI spec, SR-IOV VF's numbers are 1-based (VF1, VF2, ...).
> + */
> +#define VFID(n)		(n)
> +#define PFID		VFID(0)
> +
>  /**
>   * enum xe_sriov_mode - SR-IOV mode
>   * @XE_SRIOV_MODE_NONE: bare-metal mode (non-virtualized)

One typo to fix:
Reviewed-by: Piotr Piórkowski <piotr.piorkowski@intel.com>


> -- 
> 2.25.1
> 

--