Re: [PATCH 03/10] drm/xe: Introduce GT-oriented SR-IOV logging macros

["Piotr Piórkowski" <piotr.piorkowski@intel.com>]

Michal Wajdeczko <michal.wajdeczko@intel.com> wrote on czw [2023-gru-28 00:58:31 +0100]:
> To simplify logging and help identify SR-IOV specific messages
> related to the GT, define set of helper macros that will add
> prefix to the messages based on the current SR-IOV mode.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Reviewed-by: Piotr Piórkowski <piotr.piorkowski@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_gt_sriov_printk.h | 34 +++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
>  create mode 100644 drivers/gpu/drm/xe/xe_gt_sriov_printk.h
> 
> diff --git a/drivers/gpu/drm/xe/xe_gt_sriov_printk.h b/drivers/gpu/drm/xe/xe_gt_sriov_printk.h
> new file mode 100644
> index 000000000000..17624b16300a
> --- /dev/null
> +++ b/drivers/gpu/drm/xe/xe_gt_sriov_printk.h
> @@ -0,0 +1,34 @@
> +/* SPDX-License-Identifier: MIT */
> +/*
> + * Copyright © 2023 Intel Corporation
> + */
> +
> +#ifndef _XE_GT_SRIOV_PRINTK_H_
> +#define _XE_GT_SRIOV_PRINTK_H_
> +
> +#include "xe_gt_printk.h"
> +#include "xe_sriov_printk.h"
> +
> +#define __xe_gt_sriov_printk(gt, _level, fmt, ...) \
> +	xe_gt_printk((gt), _level, "%s" fmt, xe_sriov_printk_prefix(gt_to_xe(gt)), ##__VA_ARGS__)
> +
> +#define xe_gt_sriov_err(_gt, _fmt, ...) \
> +	__xe_gt_sriov_printk(_gt, err, _fmt, ##__VA_ARGS__)
> +
> +#define xe_gt_sriov_notice(_gt, _fmt, ...) \
> +	__xe_gt_sriov_printk(_gt, notice, _fmt, ##__VA_ARGS__)
> +
> +#define xe_gt_sriov_info(_gt, _fmt, ...) \
> +	__xe_gt_sriov_printk(_gt, info, _fmt, ##__VA_ARGS__)
> +
> +#define xe_gt_sriov_dbg(_gt, _fmt, ...) \
> +	__xe_gt_sriov_printk(_gt, dbg, _fmt, ##__VA_ARGS__)
> +
> +/* for low level noisy debug messages */
> +#ifdef CONFIG_DRM_XE_DEBUG_SRIOV
> +#define xe_gt_sriov_dbg_verbose(_gt, _fmt, ...) xe_gt_sriov_dbg(_gt, _fmt, ##__VA_ARGS__)
> +#else
> +#define xe_gt_sriov_dbg_verbose(_gt, _fmt, ...) typecheck(struct xe_gt *, (_gt))
> +#endif
> +
> +#endif
> -- 
> 2.25.1
> 

--