Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Welty <brian.welty@intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [PATCH 0/4] Refactor xe_exec_queue_create to fix user extensions
Date: Tue,  2 Jan 2024 13:17:27 -0800	[thread overview]
Message-ID: <20240102211731.6720-1-brian.welty@intel.com> (raw)

We have an issue in that exec_queue_user_extensions are applied too late.
In the case of USM properties, these need to be set prior to xe_lrc_init().

Split __xe_exec_queue_create() into two functions, alloc and init.
Setting of exec_queue user extensions is moved from the end of the ioctl
function earlier, into __xe_exec_queue_alloc(). This fixes above issue
with USM properties being set too late.

However, in order to apply user extensions this early, we can no longer
call q->ops functions.  Instead, make it more efficient. User extension
functions can simply update the q->sched_props values and they will be
applied by the backend during q->ops->init().

Note to reviewers, perhaps review the last patch first.


Brian Welty (4):
  drm/xe: Refactor __xe_exec_queue_create()
  drm/xe: Add exec_queue.sched_props.job_timeout_ms
  drm/xe: Add exec_queue.sched_props.priority
  drm/xe: Finish refactoring of exec_queue_create

 drivers/gpu/drm/xe/xe_exec_queue.c       | 129 ++++++++++++++++-------
 drivers/gpu/drm/xe/xe_exec_queue.h       |   3 +-
 drivers/gpu/drm/xe/xe_exec_queue_types.h |   6 +-
 drivers/gpu/drm/xe/xe_gsc.c              |   2 +-
 drivers/gpu/drm/xe/xe_gt.c               |   4 +-
 drivers/gpu/drm/xe/xe_guc_submit.c       |  10 +-
 drivers/gpu/drm/xe/xe_migrate.c          |   4 +-
 7 files changed, 106 insertions(+), 52 deletions(-)

-- 
2.43.0


             reply	other threads:[~2024-01-02 21:17 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-02 21:17 Brian Welty [this message]
2024-01-02 21:17 ` [PATCH 1/4] drm/xe: Refactor __xe_exec_queue_create() Brian Welty
2024-01-03  7:56   ` Matthew Brost
2024-01-02 21:17 ` [PATCH 2/4] drm/xe: Add exec_queue.sched_props.job_timeout_ms Brian Welty
2024-01-03  8:14   ` Matthew Brost
2024-01-02 21:17 ` [PATCH 3/4] drm/xe: Add exec_queue.sched_props.priority Brian Welty
2024-01-03  8:11   ` Matthew Brost
2024-01-03 18:15     ` Welty, Brian
2024-01-03 18:29       ` Matthew Brost
2024-01-02 21:17 ` [PATCH 4/4] drm/xe: Finish refactoring of exec_queue_create Brian Welty
2024-01-03  8:07   ` Matthew Brost
2024-01-03 18:16     ` Welty, Brian
2024-01-03 14:19 ` ✓ CI.Patch_applied: success for Refactor xe_exec_queue_create to fix user extensions Patchwork
2024-01-03 14:19 ` ✓ CI.checkpatch: " Patchwork
2024-01-03 14:20 ` ✓ CI.KUnit: " Patchwork
2024-01-03 14:28 ` ✓ CI.Build: " Patchwork
2024-01-03 14:28 ` ✓ CI.Hooks: " Patchwork
2024-01-03 14:29 ` ✓ CI.checksparse: " Patchwork
2024-01-03 15:05 ` ✓ CI.BAT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240102211731.6720-1-brian.welty@intel.com \
    --to=brian.welty@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox