Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Brost <matthew.brost@intel.com>
To: <intel-xe@lists.freedesktop.org>
Subject: [PATCH] drm/xe/guc: Only take actions in CT irq handler if CTs are enabled
Date: Tue,  2 Jan 2024 13:43:20 -0800	[thread overview]
Message-ID: <20240102214320.1255783-1-matthew.brost@intel.com> (raw)

Protect entire IRQ handler by CT being enabled rather than just G2H
handler.

Suggested-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
---
 drivers/gpu/drm/xe/xe_guc_ct.h | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_guc_ct.h b/drivers/gpu/drm/xe/xe_guc_ct.h
index f15f8a4857e0..05302db02e08 100644
--- a/drivers/gpu/drm/xe/xe_guc_ct.h
+++ b/drivers/gpu/drm/xe/xe_guc_ct.h
@@ -24,10 +24,11 @@ void xe_guc_ct_print(struct xe_guc_ct *ct, struct drm_printer *p, bool atomic);
 
 static inline void xe_guc_ct_irq_handler(struct xe_guc_ct *ct)
 {
-	wake_up_all(&ct->wq);
-	if (ct->enabled)
+	if (ct->enabled) {
+		wake_up_all(&ct->wq);
 		queue_work(system_unbound_wq, &ct->g2h_worker);
-	xe_guc_ct_fast_path(ct);
+		xe_guc_ct_fast_path(ct);
+	}
 }
 
 /* Basic CT send / receives */
-- 
2.34.1


             reply	other threads:[~2024-01-02 21:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-02 21:43 Matthew Brost [this message]
2024-01-03 13:31 ` ✓ CI.Patch_applied: success for drm/xe/guc: Only take actions in CT irq handler if CTs are enabled Patchwork
2024-01-03 13:32 ` ✓ CI.checkpatch: " Patchwork
2024-01-03 13:32 ` ✓ CI.KUnit: " Patchwork
2024-01-03 13:40 ` ✓ CI.Build: " Patchwork
2024-01-03 13:40 ` ✓ CI.Hooks: " Patchwork
2024-01-03 13:42 ` ✓ CI.checksparse: " Patchwork
2024-01-03 14:16 ` ✓ CI.BAT: " Patchwork
2024-01-05 19:59 ` [PATCH] " Michal Wajdeczko
2024-01-05 20:12   ` Matthew Brost
  -- strict thread matches above, loose matches on Subject: below --
2024-01-05 20:25 Matthew Brost
2024-01-05 20:34 Matthew Brost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240102214320.1255783-1-matthew.brost@intel.com \
    --to=matthew.brost@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox