From: Matthew Brost <matthew.brost@intel.com>
To: <intel-xe@lists.freedesktop.org>
Subject: [PATCH] drm/xe/guc: Only take actions in CT irq handler if CTs are enabled
Date: Fri, 5 Jan 2024 12:34:31 -0800 [thread overview]
Message-ID: <20240105203431.1329368-1-matthew.brost@intel.com> (raw)
Protect entire IRQ handler by CT being enabled rather than just G2H
handler.
v2: Return on not enabled in CT irq handler (Michal)
Suggested-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
---
drivers/gpu/drm/xe/xe_guc_ct.h | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_guc_ct.h b/drivers/gpu/drm/xe/xe_guc_ct.h
index f15f8a4857e0..9ecb67db8ec4 100644
--- a/drivers/gpu/drm/xe/xe_guc_ct.h
+++ b/drivers/gpu/drm/xe/xe_guc_ct.h
@@ -24,9 +24,11 @@ void xe_guc_ct_print(struct xe_guc_ct *ct, struct drm_printer *p, bool atomic);
static inline void xe_guc_ct_irq_handler(struct xe_guc_ct *ct)
{
+ if (!ct->enabled)
+ return;
+
wake_up_all(&ct->wq);
- if (ct->enabled)
- queue_work(system_unbound_wq, &ct->g2h_worker);
+ queue_work(system_unbound_wq, &ct->g2h_worker);
xe_guc_ct_fast_path(ct);
}
--
2.34.1
next reply other threads:[~2024-01-05 20:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-05 20:34 Matthew Brost [this message]
2024-01-06 1:44 ` ✓ CI.Patch_applied: success for drm/xe/guc: Only take actions in CT irq handler if CTs are enabled (rev3) Patchwork
2024-01-06 1:44 ` ✓ CI.checkpatch: " Patchwork
2024-01-06 1:45 ` ✓ CI.KUnit: " Patchwork
2024-01-06 1:52 ` ✓ CI.Build: " Patchwork
2024-01-06 1:53 ` ✓ CI.Hooks: " Patchwork
2024-01-06 1:54 ` ✓ CI.checksparse: " Patchwork
2024-01-06 2:29 ` ✓ CI.BAT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2024-01-05 20:25 [PATCH] drm/xe/guc: Only take actions in CT irq handler if CTs are enabled Matthew Brost
2024-01-02 21:43 Matthew Brost
2024-01-05 19:59 ` Michal Wajdeczko
2024-01-05 20:12 ` Matthew Brost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240105203431.1329368-1-matthew.brost@intel.com \
--to=matthew.brost@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox