Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "José Roberto de Souza" <jose.souza@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Maarten Lankhorst <dev@lankhorst.se>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: [PATCH v3 1/9] drm/xe: Remove double new lines in devcoredump
Date: Tue, 23 Jan 2024 12:44:46 -0800	[thread overview]
Message-ID: <20240123204454.246788-1-jose.souza@intel.com> (raw)

Right now devcoredump has a new line between '**** GuC CT ****' and
'H2G CTB (all sizes in DW):' while other sections don't have.

v2: remove double new line after IPEHR

Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Maarten Lankhorst <dev@lankhorst.se>
Cc: Stuart Summers <stuart.summers@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 drivers/gpu/drm/xe/xe_guc_ct.c    | 4 ++--
 drivers/gpu/drm/xe/xe_hw_engine.c | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_guc_ct.c b/drivers/gpu/drm/xe/xe_guc_ct.c
index ee5d99456aebc..0c07355690948 100644
--- a/drivers/gpu/drm/xe/xe_guc_ct.c
+++ b/drivers/gpu/drm/xe/xe_guc_ct.c
@@ -1366,7 +1366,7 @@ void xe_guc_ct_snapshot_print(struct xe_guc_ct_snapshot *snapshot,
 		return;
 
 	if (snapshot->ct_enabled) {
-		drm_puts(p, "\nH2G CTB (all sizes in DW):\n");
+		drm_puts(p, "H2G CTB (all sizes in DW):\n");
 		guc_ctb_snapshot_print(&snapshot->h2g, p);
 
 		drm_puts(p, "\nG2H CTB (all sizes in DW):\n");
@@ -1375,7 +1375,7 @@ void xe_guc_ct_snapshot_print(struct xe_guc_ct_snapshot *snapshot,
 		drm_printf(p, "\tg2h outstanding: %d\n",
 			   snapshot->g2h_outstanding);
 	} else {
-		drm_puts(p, "\nCT disabled\n");
+		drm_puts(p, "CT disabled\n");
 	}
 }
 
diff --git a/drivers/gpu/drm/xe/xe_hw_engine.c b/drivers/gpu/drm/xe/xe_hw_engine.c
index 3aaab507f37fe..789736a34c1ba 100644
--- a/drivers/gpu/drm/xe/xe_hw_engine.c
+++ b/drivers/gpu/drm/xe/xe_hw_engine.c
@@ -856,7 +856,7 @@ void xe_hw_engine_snapshot_print(struct xe_hw_engine_snapshot *snapshot,
 	drm_printf(p, "\tDMA_FADDR: 0x%08x_%08x\n",
 		   snapshot->reg.ring_dma_fadd_udw,
 		   snapshot->reg.ring_dma_fadd);
-	drm_printf(p, "\tIPEHR: 0x%08x\n\n", snapshot->reg.ipehr);
+	drm_printf(p, "\tIPEHR: 0x%08x\n", snapshot->reg.ipehr);
 	if (snapshot->class == XE_ENGINE_CLASS_COMPUTE)
 		drm_printf(p, "\tRCU_MODE: 0x%08x\n",
 			   snapshot->reg.rcu_mode);
-- 
2.43.0


             reply	other threads:[~2024-01-23 20:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-23 20:44 José Roberto de Souza [this message]
2024-01-23 20:44 ` [PATCH v3 2/9] drm/xe: Change devcoredump functions parameters to xe_sched_job José Roberto de Souza
2024-01-23 20:44 ` [PATCH v3 3/9] drm/xe: Nuke xe from xe_devcoredump José Roberto de Souza
2024-01-23 20:44 ` [PATCH v3 4/9] drm/xe: Stash GMD_ID value in xe_gt José Roberto de Souza
2024-01-23 21:16   ` Souza, Jose
2024-01-23 20:44 ` [PATCH v3 5/9] drm/xe: Print more device information in devcoredump José Roberto de Souza
2024-01-23 20:44 ` [PATCH v3 6/9] drm/xe: Print registers spread in 2 u32 as u64 José Roberto de Souza
2024-01-23 20:44 ` [PATCH v3 7/9] drm/xe: Remove additional spaces in devcoredump HW Engines section José Roberto de Souza
2024-01-23 20:44 ` [PATCH v3 8/9] drm/xe: Add functions to convert regular address to canonical address and back José Roberto de Souza
2024-01-23 20:44 ` [PATCH v3 9/9] drm/xe: Add batch buffer addresses to devcoredump José Roberto de Souza
2024-01-23 20:57 ` ✓ CI.Patch_applied: success for series starting with [v3,1/9] drm/xe: Remove double new lines in devcoredump Patchwork
2024-01-23 20:58 ` ✓ CI.checkpatch: " Patchwork
2024-01-23 20:59 ` ✓ CI.KUnit: " Patchwork
2024-01-23 21:06 ` ✓ CI.Build: " Patchwork
2024-01-23 21:06 ` ✗ CI.Hooks: failure " Patchwork
2024-01-23 21:08 ` ✓ CI.checksparse: success " Patchwork
2024-01-23 21:31 ` ✓ CI.BAT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240123204454.246788-1-jose.souza@intel.com \
    --to=jose.souza@intel.com \
    --cc=dev@lankhorst.se \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox