From: "José Roberto de Souza" <jose.souza@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>,
Maarten Lankhorst <dev@lankhorst.se>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: [PATCH v3 8/9] drm/xe: Add functions to convert regular address to canonical address and back
Date: Tue, 23 Jan 2024 12:44:53 -0800 [thread overview]
Message-ID: <20240123204454.246788-8-jose.souza@intel.com> (raw)
In-Reply-To: <20240123204454.246788-1-jose.souza@intel.com>
Some instructions requires canonical address like
MI_BATCH_BUFFER_START(UMDs must call xe_exec with a canonical address
for Xe2+).
So here adding functions to convert regular address to canonical
address and back, the first user of this functions will be added
in the next patches.
v3:
- inline removed from highest_address_bit_get()
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Maarten Lankhorst <dev@lankhorst.se>
Cc: Stuart Summers <stuart.summers@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
drivers/gpu/drm/xe/xe_device.c | 15 +++++++++++++++
drivers/gpu/drm/xe/xe_device.h | 3 +++
2 files changed, 18 insertions(+)
diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
index 6faa7865b1aab..c830da883732c 100644
--- a/drivers/gpu/drm/xe/xe_device.c
+++ b/drivers/gpu/drm/xe/xe_device.c
@@ -747,3 +747,18 @@ void xe_device_snapshot_print(struct xe_device *xe, struct drm_printer *p)
drm_printf(p, "\tCS reference clock: %u\n", gt->info.reference_clock);
}
}
+
+static int highest_address_bit_get(struct xe_device *xe)
+{
+ return xe->info.dma_mask_size > 48 ? 57 : 47;
+}
+
+u64 xe_device_canonicalize_addr(struct xe_device *xe, u64 address)
+{
+ return sign_extend64(address, highest_address_bit_get(xe));
+}
+
+u64 xe_device_uncanonicalize_addr(struct xe_device *xe, u64 address)
+{
+ return address & GENMASK_ULL(highest_address_bit_get(xe), 0);
+}
diff --git a/drivers/gpu/drm/xe/xe_device.h b/drivers/gpu/drm/xe/xe_device.h
index 270124da1e00e..462f59e902b12 100644
--- a/drivers/gpu/drm/xe/xe_device.h
+++ b/drivers/gpu/drm/xe/xe_device.h
@@ -177,4 +177,7 @@ u32 xe_device_ccs_bytes(struct xe_device *xe, u64 size);
void xe_device_snapshot_print(struct xe_device *xe, struct drm_printer *p);
+u64 xe_device_canonicalize_addr(struct xe_device *xe, u64 address);
+u64 xe_device_uncanonicalize_addr(struct xe_device *xe, u64 address);
+
#endif
--
2.43.0
next prev parent reply other threads:[~2024-01-23 20:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 20:44 [PATCH v3 1/9] drm/xe: Remove double new lines in devcoredump José Roberto de Souza
2024-01-23 20:44 ` [PATCH v3 2/9] drm/xe: Change devcoredump functions parameters to xe_sched_job José Roberto de Souza
2024-01-23 20:44 ` [PATCH v3 3/9] drm/xe: Nuke xe from xe_devcoredump José Roberto de Souza
2024-01-23 20:44 ` [PATCH v3 4/9] drm/xe: Stash GMD_ID value in xe_gt José Roberto de Souza
2024-01-23 21:16 ` Souza, Jose
2024-01-23 20:44 ` [PATCH v3 5/9] drm/xe: Print more device information in devcoredump José Roberto de Souza
2024-01-23 20:44 ` [PATCH v3 6/9] drm/xe: Print registers spread in 2 u32 as u64 José Roberto de Souza
2024-01-23 20:44 ` [PATCH v3 7/9] drm/xe: Remove additional spaces in devcoredump HW Engines section José Roberto de Souza
2024-01-23 20:44 ` José Roberto de Souza [this message]
2024-01-23 20:44 ` [PATCH v3 9/9] drm/xe: Add batch buffer addresses to devcoredump José Roberto de Souza
2024-01-23 20:57 ` ✓ CI.Patch_applied: success for series starting with [v3,1/9] drm/xe: Remove double new lines in devcoredump Patchwork
2024-01-23 20:58 ` ✓ CI.checkpatch: " Patchwork
2024-01-23 20:59 ` ✓ CI.KUnit: " Patchwork
2024-01-23 21:06 ` ✓ CI.Build: " Patchwork
2024-01-23 21:06 ` ✗ CI.Hooks: failure " Patchwork
2024-01-23 21:08 ` ✓ CI.checksparse: success " Patchwork
2024-01-23 21:31 ` ✓ CI.BAT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240123204454.246788-8-jose.souza@intel.com \
--to=jose.souza@intel.com \
--cc=dev@lankhorst.se \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox