From: Ashutosh Dixit <ashutosh.dixit@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Riana Tauro <riana.tauro@intel.com>,
Badal Nilawar <badal.nilawar@intel.com>
Subject: [PATCH] drm/xe/xe_gt_idle: Drop redundant newline in name
Date: Tue, 6 Feb 2024 11:27:31 -0800 [thread overview]
Message-ID: <20240206192731.3533608-1-ashutosh.dixit@intel.com> (raw)
Newline in name is redunant and produces an unnecessary empty line during
'cat name'. Newline is added during sysfs_emit. See '27a1a1e2e47d ("drm/xe:
stringify the argument to avoid potential vulnerability")'.
v2: Add Fixes tag (Riana)
Fixes: 7b076d14f21a ("drm/xe/mtl: Add support to get C6 residency/status of MTL")
Reviewed-by: Riana Tauro <riana.tauro@intel.com>
Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
drivers/gpu/drm/xe/xe_gt_idle.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_gt_idle.c b/drivers/gpu/drm/xe/xe_gt_idle.c
index 9358f73368896..9fcae65b64699 100644
--- a/drivers/gpu/drm/xe/xe_gt_idle.c
+++ b/drivers/gpu/drm/xe/xe_gt_idle.c
@@ -145,10 +145,10 @@ void xe_gt_idle_sysfs_init(struct xe_gt_idle *gtidle)
}
if (xe_gt_is_media_type(gt)) {
- sprintf(gtidle->name, "gt%d-mc\n", gt->info.id);
+ sprintf(gtidle->name, "gt%d-mc", gt->info.id);
gtidle->idle_residency = xe_guc_pc_mc6_residency;
} else {
- sprintf(gtidle->name, "gt%d-rc\n", gt->info.id);
+ sprintf(gtidle->name, "gt%d-rc", gt->info.id);
gtidle->idle_residency = xe_guc_pc_rc6_residency;
}
--
2.41.0
next reply other threads:[~2024-02-06 19:27 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 19:27 Ashutosh Dixit [this message]
2024-02-06 19:30 ` ✓ CI.Patch_applied: success for drm/xe/xe_gt_idle: Drop redundant newline in name (rev3) Patchwork
2024-02-06 19:31 ` ✗ CI.checkpatch: warning " Patchwork
2024-02-06 19:37 ` Dixit, Ashutosh
2024-02-06 21:38 ` Lucas De Marchi
2024-02-06 19:31 ` ✓ CI.KUnit: success " Patchwork
2024-02-06 19:39 ` ✓ CI.Build: " Patchwork
2024-02-06 19:39 ` ✓ CI.Hooks: " Patchwork
2024-02-06 19:40 ` ✓ CI.checksparse: " Patchwork
2024-02-06 20:17 ` ✓ CI.BAT: " Patchwork
2024-02-08 8:37 ` ✓ CI.Patch_applied: success for drm/xe/xe_gt_idle: Drop redundant newline in name (rev4) Patchwork
2024-02-08 8:37 ` ✗ CI.checkpatch: warning " Patchwork
2024-02-08 8:38 ` ✓ CI.KUnit: success " Patchwork
2024-02-08 8:48 ` ✓ CI.Build: " Patchwork
2024-02-08 8:49 ` ✓ CI.Hooks: " Patchwork
2024-02-08 8:50 ` ✓ CI.checksparse: " Patchwork
2024-02-08 9:39 ` ✗ CI.BAT: failure " Patchwork
2024-02-08 15:53 ` ✓ CI.Patch_applied: success for drm/xe/xe_gt_idle: Drop redundant newline in name (rev5) Patchwork
2024-02-08 15:53 ` ✗ CI.checkpatch: warning " Patchwork
2024-02-08 15:54 ` ✓ CI.KUnit: success " Patchwork
2024-02-08 16:04 ` ✓ CI.Build: " Patchwork
2024-02-08 16:05 ` ✓ CI.Hooks: " Patchwork
2024-02-08 16:06 ` ✓ CI.checksparse: " Patchwork
2024-02-08 16:42 ` ✓ CI.BAT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2024-02-02 22:56 [PATCH] drm/xe/xe_gt_idle: Drop redundant newline in name Ashutosh Dixit
2024-02-03 5:36 ` Lucas De Marchi
2024-02-03 6:37 ` Dixit, Ashutosh
2024-02-05 5:07 ` Riana Tauro
2024-02-02 22:35 Ashutosh Dixit
2024-02-02 22:49 ` Dixit, Ashutosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240206192731.3533608-1-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=badal.nilawar@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=riana.tauro@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox