From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Riana Tauro <riana.tauro@intel.com>, carlos.santa@intel.com
Subject: Re: [PATCH] drm/xe/xe_gt_idle: Drop redundant newline in name
Date: Fri, 02 Feb 2024 14:49:30 -0800 [thread overview]
Message-ID: <85cytebhxh.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20240202223525.3221158-1-ashutosh.dixit@intel.com>
On Fri, 02 Feb 2024 14:35:25 -0800, Ashutosh Dixit wrote:
>
> Newline in name is redunant and produces an unnecessary empty line during
> 'cat name'.
>
> Fixes: 27a1a1e2e47d ("drm/xe: stringify the argument to avoid potential vulnerability")
> Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> ---
> drivers/gpu/drm/xe/xe_gt_idle.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_gt_idle.c b/drivers/gpu/drm/xe/xe_gt_idle.c
> index 9358f73368896..42fdc7f688d0e 100644
> --- a/drivers/gpu/drm/xe/xe_gt_idle.c
> +++ b/drivers/gpu/drm/xe/xe_gt_idle.c
> @@ -87,7 +87,7 @@ static ssize_t name_show(struct device *dev,
> {
> struct xe_gt_idle *gtidle = dev_to_gtidle(dev);
>
> - return sysfs_emit(buff, "%s\n", gtidle->name);
> + return sysfs_emit(buff, "%s", gtidle->name);
Sorry, please ignore this patch. The issue is there but the patch is incorrect.
next prev parent reply other threads:[~2024-02-02 22:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 22:35 [PATCH] drm/xe/xe_gt_idle: Drop redundant newline in name Ashutosh Dixit
2024-02-02 22:38 ` ✓ CI.Patch_applied: success for " Patchwork
2024-02-02 22:39 ` ✗ CI.checkpatch: warning " Patchwork
2024-02-02 22:40 ` ✓ CI.KUnit: success " Patchwork
2024-02-02 22:47 ` ✓ CI.Build: " Patchwork
2024-02-02 22:47 ` ✓ CI.Hooks: " Patchwork
2024-02-02 22:49 ` ✓ CI.checksparse: " Patchwork
2024-02-02 22:49 ` Dixit, Ashutosh [this message]
2024-02-02 23:12 ` ✓ CI.BAT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2024-02-02 22:56 [PATCH] " Ashutosh Dixit
2024-02-03 5:36 ` Lucas De Marchi
2024-02-03 6:37 ` Dixit, Ashutosh
2024-02-05 5:07 ` Riana Tauro
2024-02-06 19:27 Ashutosh Dixit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85cytebhxh.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=carlos.santa@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=riana.tauro@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox