From: Jani Nikula <jani.nikula@intel.com>
To: intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: "Jani Nikula" <jani.nikula@intel.com>,
"Stephen Rothwell" <sfr@canb.auug.org.au>,
"Luca Coelho" <luciano.coelho@intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>
Subject: [PATCH drm-misc-next] drm/xe: fix arguments to drm_err_printer()
Date: Tue, 13 Feb 2024 10:49:54 +0200 [thread overview]
Message-ID: <20240213084954.878643-1-jani.nikula@intel.com> (raw)
The commit below changed drm_err_printer() arguments, but failed to
update all places.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Closes: https://lore.kernel.org/r/20240213120410.75c45763@canb.auug.org.au
Fixes: 5e0c04c8c40b ("drm/print: make drm_err_printer() device specific by using drm_err()")
Cc: Luca Coelho <luciano.coelho@intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
Argh. This is getting embarrassing. This one was hiding behind
CONFIG_DRM_XE_SIMPLE_ERROR_CAPTURE=y.
---
drivers/gpu/drm/xe/xe_guc_submit.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
index 4744668ef60a..0c763ceafbed 100644
--- a/drivers/gpu/drm/xe/xe_guc_submit.c
+++ b/drivers/gpu/drm/xe/xe_guc_submit.c
@@ -812,7 +812,8 @@ static void guc_exec_queue_print(struct xe_exec_queue *q, struct drm_printer *p)
static void simple_error_capture(struct xe_exec_queue *q)
{
struct xe_guc *guc = exec_queue_to_guc(q);
- struct drm_printer p = drm_err_printer("");
+ struct xe_device *xe = guc_to_xe(guc);
+ struct drm_printer p = drm_err_printer(&xe->drm, NULL);
struct xe_hw_engine *hwe;
enum xe_hw_engine_id id;
u32 adj_logical_mask = q->logical_mask;
--
2.39.2
next reply other threads:[~2024-02-13 8:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 8:49 Jani Nikula [this message]
2024-02-13 8:52 ` ✓ CI.Patch_applied: success for drm/xe: fix arguments to drm_err_printer() Patchwork
2024-02-13 8:52 ` ✗ CI.checkpatch: warning " Patchwork
2024-02-13 8:53 ` ✓ CI.KUnit: success " Patchwork
2024-02-13 9:04 ` ✓ CI.Build: " Patchwork
2024-02-13 9:04 ` ✓ CI.Hooks: " Patchwork
2024-02-13 9:05 ` ✓ CI.checksparse: " Patchwork
2024-02-13 9:37 ` [PATCH drm-misc-next] " Thomas Hellström
2024-02-13 10:04 ` Jani Nikula
2024-02-13 9:42 ` ✓ CI.BAT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240213084954.878643-1-jani.nikula@intel.com \
--to=jani.nikula@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=luciano.coelho@intel.com \
--cc=mripard@kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox