Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH drm-misc-next] drm/xe: fix arguments to drm_err_printer()
@ 2024-02-13  8:49 Jani Nikula
  2024-02-13  8:52 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (7 more replies)
  0 siblings, 8 replies; 10+ messages in thread
From: Jani Nikula @ 2024-02-13  8:49 UTC (permalink / raw)
  To: intel-xe, dri-devel
  Cc: Jani Nikula, Stephen Rothwell, Luca Coelho, Maxime Ripard,
	Thomas Hellström

The commit below changed drm_err_printer() arguments, but failed to
update all places.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Closes: https://lore.kernel.org/r/20240213120410.75c45763@canb.auug.org.au
Fixes: 5e0c04c8c40b ("drm/print: make drm_err_printer() device specific by using drm_err()")
Cc: Luca Coelho <luciano.coelho@intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>

---

Argh. This is getting embarrassing. This one was hiding behind
CONFIG_DRM_XE_SIMPLE_ERROR_CAPTURE=y.
---
 drivers/gpu/drm/xe/xe_guc_submit.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
index 4744668ef60a..0c763ceafbed 100644
--- a/drivers/gpu/drm/xe/xe_guc_submit.c
+++ b/drivers/gpu/drm/xe/xe_guc_submit.c
@@ -812,7 +812,8 @@ static void guc_exec_queue_print(struct xe_exec_queue *q, struct drm_printer *p)
 static void simple_error_capture(struct xe_exec_queue *q)
 {
 	struct xe_guc *guc = exec_queue_to_guc(q);
-	struct drm_printer p = drm_err_printer("");
+	struct xe_device *xe = guc_to_xe(guc);
+	struct drm_printer p = drm_err_printer(&xe->drm, NULL);
 	struct xe_hw_engine *hwe;
 	enum xe_hw_engine_id id;
 	u32 adj_logical_mask = q->logical_mask;
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2024-02-13 10:04 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-13  8:49 [PATCH drm-misc-next] drm/xe: fix arguments to drm_err_printer() Jani Nikula
2024-02-13  8:52 ` ✓ CI.Patch_applied: success for " Patchwork
2024-02-13  8:52 ` ✗ CI.checkpatch: warning " Patchwork
2024-02-13  8:53 ` ✓ CI.KUnit: success " Patchwork
2024-02-13  9:04 ` ✓ CI.Build: " Patchwork
2024-02-13  9:04 ` ✓ CI.Hooks: " Patchwork
2024-02-13  9:05 ` ✓ CI.checksparse: " Patchwork
2024-02-13  9:37 ` [PATCH drm-misc-next] " Thomas Hellström
2024-02-13 10:04   ` Jani Nikula
2024-02-13  9:42 ` ✓ CI.BAT: success for " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox