From: Matthew Brost <matthew.brost@intel.com>
To: <intel-xe@lists.freedesktop.org>
Cc: Matthew Brost <matthew.brost@intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: [PATCH v3 3/3] drm/xe: Don't support execlists in xe_gt_tlb_invalidation layer
Date: Thu, 22 Feb 2024 15:20:21 -0800 [thread overview]
Message-ID: <20240222232021.3911545-4-matthew.brost@intel.com> (raw)
In-Reply-To: <20240222232021.3911545-1-matthew.brost@intel.com>
The xe_gt_tlb_invalidation layer implements TLB invalidations for a GuC
backend. Simply return if in execlists mode. A follow up may properly
implement the xe_gt_tlb_invalidation layer for both GuC and execlists.
Fixes: a9351846d945 ("drm/xe: Break of TLB invalidation into its own file")
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
---
drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c b/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
index 48bf5fdb0fbe..71ab03956670 100644
--- a/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
+++ b/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
@@ -286,6 +286,14 @@ int xe_gt_tlb_invalidation_vma(struct xe_gt *gt,
xe_gt_assert(gt, vma);
+ /* Execlists not supported */
+ if (gt_to_xe(gt)->info.force_execlist) {
+ if (fence)
+ __invalidation_fence_signal(fence);
+
+ return 0;
+ }
+
action[len++] = XE_GUC_ACTION_TLB_INVALIDATION;
action[len++] = 0; /* seqno, replaced in send_tlb_invalidation */
if (!xe->info.has_range_tlb_invalidation) {
@@ -354,6 +362,10 @@ int xe_gt_tlb_invalidation_wait(struct xe_gt *gt, int seqno)
struct xe_guc *guc = >->uc.guc;
int ret;
+ /* Execlists not supported */
+ if (gt_to_xe(gt)->info.force_execlist)
+ return 0;
+
/*
* XXX: See above, this algorithm only works if seqno are always in
* order
--
2.34.1
next prev parent reply other threads:[~2024-02-22 23:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 23:20 [PATCH v3 0/3] Fix execlist mode Matthew Brost
2024-02-22 23:20 ` [PATCH v3 1/3] drm/xe: Fix execlist splat Matthew Brost
2024-02-22 23:20 ` [PATCH v3 2/3] drm/xe: Cleanup some layering in GGTT Matthew Brost
2024-02-23 14:15 ` Rodrigo Vivi
2024-02-22 23:20 ` Matthew Brost [this message]
2024-02-23 14:16 ` [PATCH v3 3/3] drm/xe: Don't support execlists in xe_gt_tlb_invalidation layer Rodrigo Vivi
2024-02-22 23:32 ` ✓ CI.Patch_applied: success for Fix execlist mode Patchwork
2024-02-22 23:32 ` ✗ CI.checkpatch: warning " Patchwork
2024-02-22 23:33 ` ✓ CI.KUnit: success " Patchwork
2024-02-22 23:45 ` ✓ CI.Build: " Patchwork
2024-02-22 23:46 ` ✓ CI.Hooks: " Patchwork
2024-02-22 23:47 ` ✓ CI.checksparse: " Patchwork
2024-02-23 0:10 ` ✓ CI.BAT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240222232021.3911545-4-matthew.brost@intel.com \
--to=matthew.brost@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox