Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 0/7] drm/xe: Rework rebinding and allow same-vm eviction
@ 2024-03-22  9:02 Thomas Hellström
  2024-03-22  9:02 ` [PATCH v2 1/7] drm/xe: Use ring ops TLB invalidation for rebinds Thomas Hellström
                   ` (13 more replies)
  0 siblings, 14 replies; 21+ messages in thread
From: Thomas Hellström @ 2024-03-22  9:02 UTC (permalink / raw)
  To: intel-xe; +Cc: Thomas Hellström

We were not allowing eviction / shrinking of completely unbound
local objects. Since unbinding is the UMD primary means of
freeing up memory on local VM overcommit situations, fix this.

The funtionality added here also open up the possibility to evict
purgeable local objects with upcoming changes.

To make this work properly, rebinding needs to be moved to the
while-not-all-locked drm-exec loop, since rebinding may allocate
gpu page table bos and thus cause evictions which forces us
to re-run validation.

This is done in patch 5, but when writing that patch, a number
couple of rebinding flaws were discovered.

1) When saving the rebinding fence we always presumed the
   rebinding fences were ordered. That is not true, and is
   fixed in patch 2, where we attach the rebind fences as
   kernel fences to the vm's resv.
2) In fact, TLB invalidation fences may currently not be assumed to be
   ordered at all. This is fixed in patch 3.
3) The combination of fixes for 1) and 2) makes the rebind
   of each vma wait for the TLB invalidation of the previous
   rebind, which is unnecessary and would incur unneeded latency.
   This is fixed in patch 1 where we move rebind TLB invalidation
   to the ring ops.

Patch 4 helps avoid fragile fence context assumptions for binds.
Patch 5 helps us decide which local bos can be evicted
Patch 6 allows evictions of completely unbound local bos

v2:
- Simplify if-statements around the tlb_flush_seqno.
      (Matthew Brost)
- Add some comments and asserts.
- Remove a leftover call to xe_vm_rebind() (Matt Brost)
- Add a helper function xe_vm_validate_rebind() (Matt Brost)
- Rebasing

Thomas Hellström (7):
  drm/xe: Use ring ops TLB invalidation for rebinds
  drm/xe: Rework rebinding
  drm/xe: Make TLB invalidation fences unordered
  drm/xe: Reserve fences where needed
  drm/xe: Move vma rebinding to the drm_exec locking loop
  drm/xe/bo: Forward the decision to evict local objects during
    validation
  drm/xe/bo: Allow eviction of unbound local bos

 drivers/gpu/drm/xe/display/xe_fb_pin.c      |   2 +-
 drivers/gpu/drm/xe/tests/xe_bo.c            |   6 +-
 drivers/gpu/drm/xe/tests/xe_dma_buf.c       |   4 +-
 drivers/gpu/drm/xe/tests/xe_migrate.c       |   2 +-
 drivers/gpu/drm/xe/xe_bo.c                  |  40 +++++--
 drivers/gpu/drm/xe/xe_bo.h                  |   2 +-
 drivers/gpu/drm/xe/xe_dma_buf.c             |   2 +-
 drivers/gpu/drm/xe/xe_exec.c                |  75 +------------
 drivers/gpu/drm/xe/xe_exec_queue_types.h    |   5 +
 drivers/gpu/drm/xe/xe_ggtt.c                |   2 +-
 drivers/gpu/drm/xe/xe_gt_pagefault.c        |   5 +-
 drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c |   1 -
 drivers/gpu/drm/xe/xe_gt_types.h            |   7 --
 drivers/gpu/drm/xe/xe_pt.c                  |  25 ++++-
 drivers/gpu/drm/xe/xe_ring_ops.c            |  11 +-
 drivers/gpu/drm/xe/xe_sched_job.c           |  10 ++
 drivers/gpu/drm/xe/xe_sched_job_types.h     |   2 +
 drivers/gpu/drm/xe/xe_vm.c                  | 114 ++++++++++++--------
 drivers/gpu/drm/xe/xe_vm.h                  |   8 +-
 drivers/gpu/drm/xe/xe_vm_types.h            |  18 +++-
 20 files changed, 174 insertions(+), 167 deletions(-)

-- 
2.44.0


^ permalink raw reply	[flat|nested] 21+ messages in thread

end of thread, other threads:[~2024-03-22 18:54 UTC | newest]

Thread overview: 21+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-22  9:02 [PATCH v2 0/7] drm/xe: Rework rebinding and allow same-vm eviction Thomas Hellström
2024-03-22  9:02 ` [PATCH v2 1/7] drm/xe: Use ring ops TLB invalidation for rebinds Thomas Hellström
2024-03-22 17:47   ` Matthew Brost
2024-03-22  9:02 ` [PATCH v2 2/7] drm/xe: Rework rebinding Thomas Hellström
2024-03-22  9:02 ` [PATCH v2 3/7] drm/xe: Make TLB invalidation fences unordered Thomas Hellström
2024-03-22 18:00   ` Matthew Brost
2024-03-22  9:02 ` [PATCH v2 4/7] drm/xe: Reserve fences where needed Thomas Hellström
2024-03-22 18:28   ` Matthew Brost
2024-03-22  9:02 ` [PATCH v2 5/7] drm/xe: Move vma rebinding to the drm_exec locking loop Thomas Hellström
2024-03-22 18:30   ` Matthew Brost
2024-03-22  9:02 ` [PATCH v2 6/7] drm/xe/bo: Forward the decision to evict local objects during validation Thomas Hellström
2024-03-22 18:51   ` Matthew Brost
2024-03-22  9:02 ` [PATCH v2 7/7] drm/xe/bo: Allow eviction of unbound local bos Thomas Hellström
2024-03-22 18:52   ` Matthew Brost
2024-03-22  9:16 ` ✓ CI.Patch_applied: success for drm/xe: Rework rebinding and allow same-vm eviction (rev2) Patchwork
2024-03-22  9:16 ` ✓ CI.checkpatch: " Patchwork
2024-03-22  9:17 ` ✓ CI.KUnit: " Patchwork
2024-03-22  9:28 ` ✓ CI.Build: " Patchwork
2024-03-22  9:30 ` ✓ CI.Hooks: " Patchwork
2024-03-22  9:32 ` ✓ CI.checksparse: " Patchwork
2024-03-22 10:06 ` ✓ CI.BAT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox