Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/3] drm/xe/xe_guc_submit: Fix exec queue stop race condition
@ 2024-03-29 18:49 Jonathan Cavitt
  2024-03-29 18:49 ` [PATCH 2/3] drm/xe/xe_guc_status: Allow lr exec queues to be banned Jonathan Cavitt
                   ` (9 more replies)
  0 siblings, 10 replies; 13+ messages in thread
From: Jonathan Cavitt @ 2024-03-29 18:49 UTC (permalink / raw)
  To: intel-xe
  Cc: saurabhg.gupta, jonathan.cavitt, matthew.brost, lucas.demarchi,
	john.c.harrison

Reorder the xe_sched_tdr_queue_imm and set_exec_queue_banned calls in
guc_exec_queue_stop.  This prevents a possible race condition between
the two events.

Suggested-by: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
---
 drivers/gpu/drm/xe/xe_guc_submit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
index 13b7e195c7b57..294f40ab6aaf1 100644
--- a/drivers/gpu/drm/xe/xe_guc_submit.c
+++ b/drivers/gpu/drm/xe/xe_guc_submit.c
@@ -1430,8 +1430,8 @@ static void guc_exec_queue_stop(struct xe_guc *guc, struct xe_exec_queue *q)
 			    !xe_sched_job_completed(job)) ||
 			    xe_sched_invalidate_job(job, 2)) {
 				trace_xe_sched_job_ban(job);
-				xe_sched_tdr_queue_imm(&q->guc->sched);
 				set_exec_queue_banned(q);
+				xe_sched_tdr_queue_imm(&q->guc->sched);
 			}
 		}
 	}
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2024-04-03  3:28 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-29 18:49 [PATCH 1/3] drm/xe/xe_guc_submit: Fix exec queue stop race condition Jonathan Cavitt
2024-03-29 18:49 ` [PATCH 2/3] drm/xe/xe_guc_status: Allow lr exec queues to be banned Jonathan Cavitt
2024-04-03  3:27   ` Matthew Brost
2024-03-29 18:49 ` [PATCH 3/3] drm/xe/xe_guc_submit: Declare reset if banned or killed Jonathan Cavitt
2024-04-03  3:28   ` Matthew Brost
2024-03-29 19:11 ` ✓ CI.Patch_applied: success for series starting with [1/3] drm/xe/xe_guc_submit: Fix exec queue stop race condition Patchwork
2024-03-29 19:11 ` ✓ CI.checkpatch: " Patchwork
2024-03-29 19:12 ` ✓ CI.KUnit: " Patchwork
2024-03-29 19:23 ` ✓ CI.Build: " Patchwork
2024-03-29 19:26 ` ✓ CI.Hooks: " Patchwork
2024-03-29 19:27 ` ✓ CI.checksparse: " Patchwork
2024-03-29 20:00 ` ✓ CI.BAT: " Patchwork
2024-04-03  3:19 ` [PATCH 1/3] " Matthew Brost

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox