Re: [PATCH 4/6] drm/xe/guc: Add PF2GUC_UPDATE_VF_CFG to ABI

["Piotr Piórkowski" <piotr.piorkowski@intel.com>]

Michal Wajdeczko <michal.wajdeczko@intel.com> wrote on nie [2024-kwi-14 21:01:35 +0200]:
> In upcoming patches the PF driver will add support to change VFs
> configuration and will need to use PF2GUC_UPDATE_VF_CFG messages.
> Add necessary definitions to our GuC firmware ABI header.
> 
> Definitions of the GuC VF Configuration KLVs used by this action
> are already present in abi/guc_klvs_abi.h
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> ---
>  .../gpu/drm/xe/abi/guc_actions_sriov_abi.h    | 55 +++++++++++++++++++
>  1 file changed, 55 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/abi/guc_actions_sriov_abi.h b/drivers/gpu/drm/xe/abi/guc_actions_sriov_abi.h
> index 2d829e812c61..c1ad09b36453 100644
> --- a/drivers/gpu/drm/xe/abi/guc_actions_sriov_abi.h
> +++ b/drivers/gpu/drm/xe/abi/guc_actions_sriov_abi.h
> @@ -260,6 +260,61 @@
>  #define PF2GUC_UPDATE_VGT_POLICY_RESPONSE_MSG_LEN		GUC_HXG_RESPONSE_MSG_MIN_LEN
>  #define PF2GUC_UPDATE_VGT_POLICY_RESPONSE_MSG_0_COUNT		GUC_HXG_RESPONSE_MSG_0_DATA0
>  
> +/**
> + * DOC: PF2GUC_UPDATE_VF_CFG
> + *
> + * The `PF2GUC_UPDATE_VF_CFG`_ message is used by PF to provision single VF in GuC.
> + *
> + * This message must be sent as `CTB HXG Message`_.
> + *
> + *  +---+-------+--------------------------------------------------------------+
> + *  |   | Bits  | Description                                                  |
> + *  +===+=======+==============================================================+
> + *  | 0 |    31 | ORIGIN = GUC_HXG_ORIGIN_HOST_                                |
> + *  |   +-------+--------------------------------------------------------------+
> + *  |   | 30:28 | TYPE = GUC_HXG_TYPE_REQUEST_                                 |
> + *  |   +-------+--------------------------------------------------------------+
> + *  |   | 27:16 | MBZ                                                          |
> + *  |   +-------+--------------------------------------------------------------+
> + *  |   |  15:0 | ACTION = _`GUC_ACTION_PF2GUC_UPDATE_VF_CFG` = 0x5503         |
> + *  +---+-------+--------------------------------------------------------------+
> + *  | 1 |  31:0 | **VFID** - identifier of the VF that the KLV                 |
> + *  |   |       | configurations are being applied to                          |
> + *  +---+-------+--------------------------------------------------------------+
> + *  | 2 |  31:0 | **CFG_ADDR_LO** - dword aligned GGTT offset that represents  |
> + *  |   |       | the start of a list of virtualization related KLV configs    |
> + *  |   |       | that are to be applied to the VF.                            |
> + *  |   |       | If this parameter is zero, the list is not parsed.           |
> + *  |   |       | If full configs address parameter is zero and configs_size is|
> + *  |   |       | zero associated VF config shall be reset to its default state|
> + *  +---+-------+--------------------------------------------------------------+
> + *  | 3 |  31:0 | **CFG_ADDR_HI** - upper 32 bits of configs address.          |
> + *  +---+-------+--------------------------------------------------------------+
> + *  | 4 |  31:0 | **CFG_SIZE** - size (in dwords) of the config buffer         |
> + *  +---+-------+--------------------------------------------------------------+
> + *
> + *  +---+-------+--------------------------------------------------------------+
> + *  |   | Bits  | Description                                                  |
> + *  +===+=======+==============================================================+
> + *  | 0 |    31 | ORIGIN = GUC_HXG_ORIGIN_GUC_                                 |
> + *  |   +-------+--------------------------------------------------------------+
> + *  |   | 30:28 | TYPE = GUC_HXG_TYPE_RESPONSE_SUCCESS_                        |
> + *  |   +-------+--------------------------------------------------------------+
> + *  |   |  27:0 | **COUNT** - number of KLVs successfully applied              |
> + *  +---+-------+--------------------------------------------------------------+
> + */
> +#define GUC_ACTION_PF2GUC_UPDATE_VF_CFG			0x5503u
> +
> +#define PF2GUC_UPDATE_VF_CFG_REQUEST_MSG_LEN		(GUC_HXG_REQUEST_MSG_MIN_LEN + 4u)
> +#define PF2GUC_UPDATE_VF_CFG_REQUEST_MSG_0_MBZ		GUC_HXG_REQUEST_MSG_0_DATA0
> +#define PF2GUC_UPDATE_VF_CFG_REQUEST_MSG_1_VFID		GUC_HXG_REQUEST_MSG_n_DATAn
> +#define PF2GUC_UPDATE_VF_CFG_REQUEST_MSG_2_CFG_ADDR_LO	GUC_HXG_REQUEST_MSG_n_DATAn
> +#define PF2GUC_UPDATE_VF_CFG_REQUEST_MSG_3_CFG_ADDR_HI	GUC_HXG_REQUEST_MSG_n_DATAn
> +#define PF2GUC_UPDATE_VF_CFG_REQUEST_MSG_4_CFG_SIZE	GUC_HXG_REQUEST_MSG_n_DATAn
> +
> +#define PF2GUC_UPDATE_VF_CFG_RESPONSE_MSG_LEN		GUC_HXG_RESPONSE_MSG_MIN_LEN
> +#define PF2GUC_UPDATE_VF_CFG_RESPONSE_MSG_0_COUNT	GUC_HXG_RESPONSE_MSG_0_DATA0
> +


Reviewed-by: Piotr Piórkowski <piotr.piorkowski@intel.com>
>  /**
>   * DOC: PF2GUC_VF_CONTROL
>   *
> -- 
> 2.43.0
> 

--