Re: [PATCH 3/6] drm/xe: Add xe_ttm_vram_get_avail

["Ghimiray, Himal Prasad" <himal.prasad.ghimiray@intel.com>]

On 15-04-2024 00:31, Michal Wajdeczko wrote:
> The PF driver will need to know size of the remaining available
> VRAM to estimate fair VRAM allocations that could be used across
> all VFs in automatic VFs provisioning mode. Add helper function
> for that. We will use it in upcoming patch.
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_ttm_vram_mgr.c | 12 ++++++++++++
>   drivers/gpu/drm/xe/xe_ttm_vram_mgr.h |  1 +
>   2 files changed, 13 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_ttm_vram_mgr.c b/drivers/gpu/drm/xe/xe_ttm_vram_mgr.c
> index 0678faf83212..8a1f460ff20b 100644
> --- a/drivers/gpu/drm/xe/xe_ttm_vram_mgr.c
> +++ b/drivers/gpu/drm/xe/xe_ttm_vram_mgr.c
> @@ -478,3 +478,15 @@ void xe_ttm_vram_get_used(struct ttm_resource_manager *man,
>   	*used_visible = mgr->visible_size - mgr->visible_avail;
>   	mutex_unlock(&mgr->lock);
>   }
> +
> +u64 xe_ttm_vram_get_avail(struct ttm_resource_manager *man)
> +{
> +	struct xe_ttm_vram_mgr *mgr = to_xe_ttm_vram_mgr(man);
> +	u64 avail;
> +
> +	mutex_lock(&mgr->lock);
> +	avail =  mgr->mm.avail;
> +	mutex_unlock(&mgr->lock);
> +
> +	return avail;
> +}


LGTM.

Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>


> diff --git a/drivers/gpu/drm/xe/xe_ttm_vram_mgr.h b/drivers/gpu/drm/xe/xe_ttm_vram_mgr.h
> index d184e19a9230..cc76050e376d 100644
> --- a/drivers/gpu/drm/xe/xe_ttm_vram_mgr.h
> +++ b/drivers/gpu/drm/xe/xe_ttm_vram_mgr.h
> @@ -25,6 +25,7 @@ int xe_ttm_vram_mgr_alloc_sgt(struct xe_device *xe,
>   void xe_ttm_vram_mgr_free_sgt(struct device *dev, enum dma_data_direction dir,
>   			      struct sg_table *sgt);
>   
> +u64 xe_ttm_vram_get_avail(struct ttm_resource_manager *man);
>   u64 xe_ttm_vram_get_cpu_visible_size(struct ttm_resource_manager *man);
>   void xe_ttm_vram_get_used(struct ttm_resource_manager *man,
>   			  u64 *used, u64 *used_visible);