Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe: Use distinct error code in VM_CREATE for device fault mode checks
@ 2024-04-23 23:47 Brian Welty
  2024-04-23 23:55 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (9 more replies)
  0 siblings, 10 replies; 11+ messages in thread
From: Brian Welty @ 2024-04-23 23:47 UTC (permalink / raw)
  To: intel-xe, Matthew Brost

vm_create_ioctl doesn't allow creating new VM in fault_mode while existing
VMs are in non-fault mode, and vice-versa.
This is not necessarily the user doing anything wrong if others are sharing
the system. Instead of returning -EINVAL which suggests the user provided a
bad argument, return distinct error code of -EBUSY for this class of errors
so the user knows they can retry the vm_create when system is idle.

Signed-off-by: Brian Welty <brian.welty@intel.com>
---
 drivers/gpu/drm/xe/xe_vm.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
index 85d6f359142d..e8628a982db6 100644
--- a/drivers/gpu/drm/xe/xe_vm.c
+++ b/drivers/gpu/drm/xe/xe_vm.c
@@ -1840,16 +1840,16 @@ int xe_vm_create_ioctl(struct drm_device *dev, void *data,
 			 args->flags & DRM_XE_VM_CREATE_FLAG_FAULT_MODE))
 		return -EINVAL;
 
+	if (XE_IOCTL_DBG(xe, args->extensions))
+		return -EINVAL;
+
 	if (XE_IOCTL_DBG(xe, args->flags & DRM_XE_VM_CREATE_FLAG_FAULT_MODE &&
 			 xe_device_in_non_fault_mode(xe)))
-		return -EINVAL;
+		return -EBUSY;
 
 	if (XE_IOCTL_DBG(xe, !(args->flags & DRM_XE_VM_CREATE_FLAG_FAULT_MODE) &&
 			 xe_device_in_fault_mode(xe)))
-		return -EINVAL;
-
-	if (XE_IOCTL_DBG(xe, args->extensions))
-		return -EINVAL;
+		return -EBUSY;
 
 	if (args->flags & DRM_XE_VM_CREATE_FLAG_SCRATCH_PAGE)
 		flags |= XE_VM_FLAG_SCRATCH_PAGE;
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2024-05-17  4:19 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-23 23:47 [PATCH] drm/xe: Use distinct error code in VM_CREATE for device fault mode checks Brian Welty
2024-04-23 23:55 ` ✓ CI.Patch_applied: success for " Patchwork
2024-04-23 23:55 ` ✓ CI.checkpatch: " Patchwork
2024-04-23 23:56 ` ✓ CI.KUnit: " Patchwork
2024-04-24  0:16 ` ✓ CI.Build: " Patchwork
2024-04-24  0:19 ` ✓ CI.Hooks: " Patchwork
2024-04-24  0:20 ` ✓ CI.checksparse: " Patchwork
2024-04-24  0:50 ` ✓ CI.BAT: " Patchwork
2024-04-24  3:20 ` [PATCH] " Matthew Brost
2024-05-14 14:32 ` Ghimiray, Himal Prasad
2024-05-17  4:18 ` Matthew Brost

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox