[PATCH i-g-t] lib/intel_ctx: Propagate error from __intel_ctx_xe_exec wait timeout

[PATCH i-g-t] lib/intel_ctx: Propagate error from __intel_ctx_xe_exec wait timeout

[Maarten Lankhorst]

Any wait timeouts are currently ignored, which might cause silent
failures in test. Be more noisy about them.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 lib/intel_ctx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/intel_ctx.c b/lib/intel_ctx.c
index b43dd6391..30325b906 100644
--- a/lib/intel_ctx.c
+++ b/lib/intel_ctx.c
@@ -450,7 +450,7 @@ int __intel_ctx_xe_exec(const intel_ctx_t *ctx, uint64_t ahnd, uint64_t bb_offse
 		goto err;
 
 	if (!ctx->sync_bind || !ctx->sync_out)
-		syncobj_wait_err(ctx->fd, &sync_out, 1, INT64_MAX, 0);
+		ret = syncobj_wait_err(ctx->fd, &sync_out, 1, INT64_MAX, 0);
 
 err:
 	if (!ctx->sync_bind)
-- 
2.43.0

✗ CI.Patch_applied: failure for lib/intel_ctx: Propagate error from __intel_ctx_xe_exec wait timeout

[Patchwork]

== Series Details ==

Series: lib/intel_ctx: Propagate error from __intel_ctx_xe_exec wait timeout
URL   : https://patchwork.freedesktop.org/series/133229/
State : failure

== Summary ==

=== Applying kernel patches on branch 'drm-tip' with base: ===
Base commit: 5a43da669cdb drm-tip: 2024y-05m-06d-08h-26m-33s UTC integration manifest
=== git am output follows ===
error: lib/intel_ctx.c: does not exist in index
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Applying: lib/intel_ctx: Propagate error from __intel_ctx_xe_exec wait timeout
Patch failed at 0001 lib/intel_ctx: Propagate error from __intel_ctx_xe_exec wait timeout
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Re: [PATCH i-g-t] lib/intel_ctx: Propagate error from __intel_ctx_xe_exec wait timeout

[Zbigniew Kempczyński]

On Mon, May 06, 2024 at 02:08:27PM +0200, Maarten Lankhorst wrote:
> Any wait timeouts are currently ignored, which might cause silent
> failures in test. Be more noisy about them.
> 
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
>  lib/intel_ctx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/intel_ctx.c b/lib/intel_ctx.c
> index b43dd6391..30325b906 100644
> --- a/lib/intel_ctx.c
> +++ b/lib/intel_ctx.c
> @@ -450,7 +450,7 @@ int __intel_ctx_xe_exec(const intel_ctx_t *ctx, uint64_t ahnd, uint64_t bb_offse
>  		goto err;
>  
>  	if (!ctx->sync_bind || !ctx->sync_out)
> -		syncobj_wait_err(ctx->fd, &sync_out, 1, INT64_MAX, 0);
> +		ret = syncobj_wait_err(ctx->fd, &sync_out, 1, INT64_MAX, 0);
>  
>  err:
>  	if (!ctx->sync_bind)
> -- 
> 2.43.0
> 

Yes, you're definitely right:

Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>

--
Zbigniew

Re: [PATCH i-g-t] lib/intel_ctx: Propagate error from __intel_ctx_xe_exec wait timeout

[Maarten Lankhorst]

Hey,

Den 2024-05-06 kl. 15:32, skrev Zbigniew Kempczyński:
> On Mon, May 06, 2024 at 02:08:27PM +0200, Maarten Lankhorst wrote:
>> Any wait timeouts are currently ignored, which might cause silent
>> failures in test. Be more noisy about them.
>>
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> ---
>>   lib/intel_ctx.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/intel_ctx.c b/lib/intel_ctx.c
>> index b43dd6391..30325b906 100644
>> --- a/lib/intel_ctx.c
>> +++ b/lib/intel_ctx.c
>> @@ -450,7 +450,7 @@ int __intel_ctx_xe_exec(const intel_ctx_t *ctx, uint64_t ahnd, uint64_t bb_offse
>>   		goto err;
>>   
>>   	if (!ctx->sync_bind || !ctx->sync_out)
>> -		syncobj_wait_err(ctx->fd, &sync_out, 1, INT64_MAX, 0);
>> +		ret = syncobj_wait_err(ctx->fd, &sync_out, 1, INT64_MAX, 0);
>>   
>>   err:
>>   	if (!ctx->sync_bind)
>> -- 
>> 2.43.0
>>
> Yes, you're definitely right:
>
> Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Thanks, pushed!