From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org
Subject: [PATCH 1/9] drm/i915: Split gen2 vs. gen3 .max_stride()
Date: Mon, 6 May 2024 15:57:10 +0300 [thread overview]
Message-ID: <20240506125718.26001-2-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20240506125718.26001-1-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Plane .max_stride() is alreayd a vfunc so having one made
up of two branches based on the display version is silly.
Split i9xx_plane_max_stride() into gen2 vs. gen3 variants
so that we get rid of said check.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/i9xx_plane.c | 32 +++++++++++++----------
1 file changed, 18 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/i9xx_plane.c b/drivers/gpu/drm/i915/display/i9xx_plane.c
index 3442264443e5..21303fa4f08f 100644
--- a/drivers/gpu/drm/i915/display/i9xx_plane.c
+++ b/drivers/gpu/drm/i915/display/i9xx_plane.c
@@ -741,23 +741,25 @@ i965_plane_max_stride(struct intel_plane *plane,
}
static unsigned int
-i9xx_plane_max_stride(struct intel_plane *plane,
+i915_plane_max_stride(struct intel_plane *plane,
u32 pixel_format, u64 modifier,
unsigned int rotation)
{
- struct drm_i915_private *dev_priv = to_i915(plane->base.dev);
+ if (modifier == I915_FORMAT_MOD_X_TILED)
+ return 8 * 1024;
+ else
+ return 16 * 1024;
+}
- if (DISPLAY_VER(dev_priv) >= 3) {
- if (modifier == I915_FORMAT_MOD_X_TILED)
- return 8*1024;
- else
- return 16*1024;
- } else {
- if (plane->i9xx_plane == PLANE_C)
- return 4*1024;
- else
- return 8*1024;
- }
+static unsigned int
+i8xx_plane_max_stride(struct intel_plane *plane,
+ u32 pixel_format, u64 modifier,
+ unsigned int rotation)
+{
+ if (plane->i9xx_plane == PLANE_C)
+ return 4 * 1024;
+ else
+ return 8 * 1024;
}
static const struct drm_plane_funcs i965_plane_funcs = {
@@ -854,8 +856,10 @@ intel_primary_plane_create(struct drm_i915_private *dev_priv, enum pipe pipe)
if (HAS_GMCH(dev_priv)) {
if (DISPLAY_VER(dev_priv) >= 4)
plane->max_stride = i965_plane_max_stride;
+ else if (DISPLAY_VER(dev_priv) == 3)
+ plane->max_stride = i915_plane_max_stride;
else
- plane->max_stride = i9xx_plane_max_stride;
+ plane->max_stride = i8xx_plane_max_stride;
} else {
if (IS_BROADWELL(dev_priv) || IS_HASWELL(dev_priv))
plane->max_stride = hsw_primary_max_stride;
--
2.43.2
next prev parent reply other threads:[~2024-05-06 12:57 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 12:57 [PATCH 0/9] drm/i915: Plane fb refactoring Ville Syrjala
2024-05-06 12:57 ` Ville Syrjala [this message]
2024-05-06 13:57 ` [PATCH 1/9] drm/i915: Split gen2 vs. gen3 .max_stride() Jani Nikula
2024-05-06 12:57 ` [PATCH 2/9] drm/i915: Clean up skl+ plane stride limits Ville Syrjala
2024-05-06 14:03 ` Jani Nikula
2024-05-06 16:38 ` Ville Syrjälä
2024-05-07 9:02 ` Jani Nikula
2024-05-06 12:57 ` [PATCH 3/9] drm/i915: Drop 'uses_fence' parameter from intel_pin_fb_obj_dpt() Ville Syrjala
2024-05-06 14:04 ` Jani Nikula
2024-05-06 12:57 ` [PATCH 4/9] drm/i915: Extract intel_plane_needs_physical() Ville Syrjala
2024-05-06 14:05 ` Jani Nikula
2024-05-06 12:57 ` [PATCH 5/9] drm/i915: Polish types in fb calculations Ville Syrjala
2024-05-06 14:07 ` Jani Nikula
2024-05-06 12:57 ` [PATCH 6/9] drm/i915: Constify 'fb' in during pinning Ville Syrjala
2024-05-06 14:11 ` Jani Nikula
2024-05-06 12:57 ` [PATCH 7/9] drm/i915: Change intel_fbdev_fb_alloc() reuturn type Ville Syrjala
2024-05-06 14:16 ` Jani Nikula
2024-05-06 16:51 ` Ville Syrjälä
2024-05-06 18:19 ` Ville Syrjälä
2024-05-10 10:22 ` [PATCH v2 7/9] drm/i915: Change intel_fbdev_fb_alloc() return type Ville Syrjala
2024-05-10 11:30 ` Jani Nikula
2024-05-06 12:57 ` [PATCH 8/9] drm/i915: Cleanup fbdev fb setup Ville Syrjala
2024-05-10 10:22 ` [PATCH v2 " Ville Syrjala
2024-05-10 11:32 ` Jani Nikula
2024-05-06 12:57 ` [PATCH 9/9] drm/i915: Rename the fb pinning functions to indicate the address space Ville Syrjala
2024-05-10 11:35 ` Jani Nikula
2024-05-06 13:02 ` ✓ CI.Patch_applied: success for drm/i915: Plane fb refactoring Patchwork
2024-05-06 13:03 ` ✓ CI.checkpatch: " Patchwork
2024-05-06 13:03 ` ✓ CI.KUnit: " Patchwork
2024-05-06 13:15 ` ✓ CI.Build: " Patchwork
2024-05-06 13:18 ` ✓ CI.Hooks: " Patchwork
2024-05-06 13:19 ` ✗ CI.checksparse: warning " Patchwork
2024-05-06 13:53 ` ✓ CI.BAT: success " Patchwork
2024-05-06 15:07 ` ✓ CI.FULL: " Patchwork
2024-05-10 10:52 ` ✓ CI.Patch_applied: success for drm/i915: Plane fb refactoring (rev3) Patchwork
2024-05-10 10:53 ` ✓ CI.checkpatch: " Patchwork
2024-05-10 10:55 ` ✓ CI.KUnit: " Patchwork
2024-05-10 11:07 ` ✓ CI.Build: " Patchwork
2024-05-10 11:10 ` ✓ CI.Hooks: " Patchwork
2024-05-10 11:11 ` ✗ CI.checksparse: warning " Patchwork
2024-05-10 11:43 ` ✗ CI.BAT: failure " Patchwork
2024-05-10 13:54 ` ✓ CI.FULL: success " Patchwork
2024-05-10 16:55 ` [PATCH 0/9] drm/i915: Plane fb refactoring Ville Syrjälä
2024-05-11 19:00 ` Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240506125718.26001-2-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox