Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: jani.nikula@intel.com
Subject: [PATCH 2/2] drm/xe/display: remove unused xe->sb_lock
Date: Fri, 10 May 2024 12:43:13 +0300	[thread overview]
Message-ID: <20240510094313.3422982-2-jani.nikula@intel.com> (raw)
In-Reply-To: <20240510094313.3422982-1-jani.nikula@intel.com>

Nothing in xe needs xe->sb_lock. None of the i915 display code using
->sb_lock gets built with xe, and in any case that would be wrong as xe
uses gt->pcode.lock for this.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/xe/display/xe_display.c | 2 --
 drivers/gpu/drm/xe/xe_device_types.h    | 3 ---
 2 files changed, 5 deletions(-)

diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c
index fbe2c2eddea9..a2c39bcc7677 100644
--- a/drivers/gpu/drm/xe/display/xe_display.c
+++ b/drivers/gpu/drm/xe/display/xe_display.c
@@ -96,8 +96,6 @@ int xe_display_create(struct xe_device *xe)
 
 	xe->display.hotplug.dp_wq = alloc_ordered_workqueue("xe-dp", 0);
 
-	drmm_mutex_init(&xe->drm, &xe->sb_lock);
-
 	return drmm_add_action_or_reset(&xe->drm, display_destroy, NULL);
 }
 
diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h
index b78223e3baab..5c5e36de452a 100644
--- a/drivers/gpu/drm/xe/xe_device_types.h
+++ b/drivers/gpu/drm/xe/xe_device_types.h
@@ -511,9 +511,6 @@ struct xe_device {
 	/* To shut up runtime pm macros.. */
 	struct xe_runtime_pm {} runtime_pm;
 
-	/* For pcode */
-	struct mutex sb_lock;
-
 	/* only to allow build, not used functionally */
 	u32 irq_mask;
 
-- 
2.39.2


  reply	other threads:[~2024-05-10  9:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-10  9:43 [PATCH 1/2] drm/xe/display: remove unused xe->enabled_irq_mask Jani Nikula
2024-05-10  9:43 ` Jani Nikula [this message]
2024-05-10 11:28   ` [PATCH 2/2] drm/xe/display: remove unused xe->sb_lock Ghimiray, Himal Prasad
2024-05-10  9:49 ` ✓ CI.Patch_applied: success for series starting with [1/2] drm/xe/display: remove unused xe->enabled_irq_mask Patchwork
2024-05-10  9:50 ` ✓ CI.checkpatch: " Patchwork
2024-05-10  9:52 ` ✓ CI.KUnit: " Patchwork
2024-05-10 10:06 ` ✓ CI.Build: " Patchwork
2024-05-10 10:09 ` ✓ CI.Hooks: " Patchwork
2024-05-10 10:10 ` ✓ CI.checksparse: " Patchwork
2024-05-10 10:46 ` ✓ CI.BAT: " Patchwork
2024-05-10 11:30 ` [PATCH 1/2] " Ghimiray, Himal Prasad
2024-05-10 12:15 ` ✗ CI.FULL: failure for series starting with [1/2] " Patchwork
2024-05-13 12:10 ` [PATCH 1/2] " Jani Nikula
2024-05-13 14:35   ` Lucas De Marchi
2024-05-13 19:56     ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240510094313.3422982-2-jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox