Re: [PATCH 1/2] drm/xe/display: remove unused xe->enabled_irq_mask

["Ghimiray, Himal Prasad" <himal.prasad.ghimiray@intel.com>]

On 10-05-2024 15:13, Jani Nikula wrote:
> The xe->enabled_irq_mask member has never been used for anything.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>   drivers/gpu/drm/xe/display/xe_display.c | 1 -
>   drivers/gpu/drm/xe/xe_device_types.h    | 2 --
>   2 files changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c
> index 0de0566e5b39..fbe2c2eddea9 100644
> --- a/drivers/gpu/drm/xe/display/xe_display.c
> +++ b/drivers/gpu/drm/xe/display/xe_display.c
> @@ -97,7 +97,6 @@ int xe_display_create(struct xe_device *xe)
>   	xe->display.hotplug.dp_wq = alloc_ordered_workqueue("xe-dp", 0);
>   
>   	drmm_mutex_init(&xe->drm, &xe->sb_lock);
> -	xe->enabled_irq_mask = ~0;


LGTM

Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>

Thanks


>   
>   	return drmm_add_action_or_reset(&xe->drm, display_destroy, NULL);
>   }
> diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h
> index 906b98fb973b..b78223e3baab 100644
> --- a/drivers/gpu/drm/xe/xe_device_types.h
> +++ b/drivers/gpu/drm/xe/xe_device_types.h
> @@ -517,8 +517,6 @@ struct xe_device {
>   	/* only to allow build, not used functionally */
>   	u32 irq_mask;
>   
> -	u32 enabled_irq_mask;
> -
>   	struct intel_uncore {
>   		spinlock_t lock;
>   	} uncore;