Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [CI 15/21] drm/exec: Add a snapshot capability.
Date: Wed, 15 May 2024 10:14:43 +0200	[thread overview]
Message-ID: <20240515081449.46646-16-thomas.hellstrom@linux.intel.com> (raw)
In-Reply-To: <20240515081449.46646-1-thomas.hellstrom@linux.intel.com>

Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
---
 drivers/gpu/drm/drm_exec.c | 38 +++++++++++++++++++++++++++++++++++++-
 include/drm/drm_exec.h     | 13 ++++++++++++-
 2 files changed, 49 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_exec.c b/drivers/gpu/drm/drm_exec.c
index ec8c245e33d1..934f60e75744 100644
--- a/drivers/gpu/drm/drm_exec.c
+++ b/drivers/gpu/drm/drm_exec.c
@@ -57,6 +57,7 @@ static void drm_exec_unlock_all(struct drm_exec *exec)
 	struct drm_gem_object *obj;
 	unsigned long index;
 
+	WARN_ON(exec->snap);
 	drm_exec_for_each_locked_object_reverse(exec, index, obj) {
 		dma_resv_unlock(obj->resv);
 		drm_gem_object_put(obj);
@@ -289,7 +290,6 @@ int drm_exec_lock_obj(struct drm_exec *exec, struct drm_gem_object *obj)
 		goto error_unlock;
 
 	return 0;
-
 error_unlock:
 	dma_resv_unlock(obj->resv);
 	return ret;
@@ -383,5 +383,41 @@ int drm_exec_prepare_array(struct drm_exec *exec,
 }
 EXPORT_SYMBOL(drm_exec_prepare_array);
 
+void drm_exec_restore(struct drm_exec *exec, struct drm_exec_snapshot *snap)
+{
+	struct drm_gem_object *obj;
+	unsigned int index;
+
+	exec->snap = snap->saved_snap;
+
+	drm_exec_for_each_locked_object_reverse(exec, index, obj) {
+		if (index + 1 == snap->num_locked)
+			break;
+
+		dma_resv_unlock(obj->resv);
+		drm_gem_object_put(obj);
+		exec->objects[index] = NULL;
+	}
+
+	exec->num_objects = snap->num_locked;
+	
+	if (!exec->prelocked)
+		exec->prelocked = snap->prelocked;
+	else
+		drm_gem_object_put(snap->prelocked);
+}
+EXPORT_SYMBOL(drm_exec_restore);
+
+void drm_exec_snapshot(struct drm_exec *exec, struct drm_exec_snapshot *snap)
+{
+	snap->num_locked = exec->num_objects;
+	snap->prelocked = exec->prelocked;
+	if (snap->prelocked)
+		drm_gem_object_get(snap->prelocked);
+	snap->saved_snap = exec->snap;
+	exec->snap = snap;	
+}
+EXPORT_SYMBOL(drm_exec_snapshot);
+
 MODULE_DESCRIPTION("DRM execution context");
 MODULE_LICENSE("Dual MIT/GPL");
diff --git a/include/drm/drm_exec.h b/include/drm/drm_exec.h
index a37c851a178b..b82e4c8ead11 100644
--- a/include/drm/drm_exec.h
+++ b/include/drm/drm_exec.h
@@ -19,7 +19,6 @@ struct drm_exec {
 	 * @flags: Flags to control locking behavior
 	 */
 	u32                     flags;
-
 	/**
 	 * @ticket: WW ticket used for acquiring locks
 	 */
@@ -49,6 +48,13 @@ struct drm_exec {
 	 * @prelocked: already locked GEM object due to contention
 	 */
 	struct drm_gem_object *prelocked;
+	struct drm_exec_snapshot *snap;
+};
+
+struct drm_exec_snapshot {
+	struct drm_exec_snapshot *saved_snap;
+	struct drm_gem_object *prelocked;
+	unsigned long num_locked;
 };
 
 int drm_exec_handle_contended(struct drm_exec *exec);
@@ -144,6 +150,8 @@ static inline bool drm_exec_is_contended(struct drm_exec *exec)
 	return !!exec->contended;
 }
 
+
+
 void drm_exec_init(struct drm_exec *exec, u32 flags, unsigned nr);
 void drm_exec_fini(struct drm_exec *exec);
 bool drm_exec_cleanup(struct drm_exec *exec);
@@ -156,5 +164,8 @@ int drm_exec_prepare_array(struct drm_exec *exec,
 			   struct drm_gem_object **objects,
 			   unsigned int num_objects,
 			   unsigned int num_fences);
+void drm_exec_snapshot(struct drm_exec *exec, struct drm_exec_snapshot *snap);
+void drm_exec_restore(struct drm_exec *exec, struct drm_exec_snapshot *snap);
+
 
 #endif
-- 
2.44.0


  parent reply	other threads:[~2024-05-15  8:15 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-15  8:14 [CI 00/21] xe bo shrinker and exhaustive eviction Thomas Hellström
2024-05-15  8:14 ` [CI 01/21] drm/ttm: Allow TTM LRU list nodes of different types Thomas Hellström
2024-05-15  8:14 ` [CI 02/21] drm/ttm: Slightly clean up LRU list iteration Thomas Hellström
2024-05-15  8:14 ` [CI 03/21] drm/ttm: Use LRU hitches Thomas Hellström
2024-05-15  8:14 ` [CI 04/21] drm/ttm, drm/amdgpu, drm/xe: Consider hitch moves within bulk sublist moves Thomas Hellström
2024-05-15  8:14 ` [CI 05/21] drm/exec: Rework contended locking Thomas Hellström
2024-05-15  8:14 ` [CI 06/21] drm/ttm: Provide a generic LRU walker helper Thomas Hellström
2024-05-15  8:14 ` [CI 07/21] drm/ttm: Use restartable LRU and sleeping locks for swapping Thomas Hellström
2024-05-15  8:14 ` [CI 08/21] drm/ttm: sleeping evict lock Thomas Hellström
2024-05-15  8:14 ` [CI 09/21] drm/ttm: Add a virtual base class for graphics memory backup Thomas Hellström
2024-05-15  8:14 ` [CI 10/21] drm/ttm/pool: Provide a helper to shrink pages Thomas Hellström
2024-05-15  8:14 ` [CI 11/21] drm/ttm: Use fault-injection to test error paths Thomas Hellström
2024-05-15  8:14 ` [CI 12/21] drm/ttm, drm/xe: Add a shrinker for xe bos Thomas Hellström
2024-05-15  8:14 ` [CI 13/21] dma-buf/dma-resv: Introduce dma_resv_trylock_ctx() Thomas Hellström
2024-05-15  8:14 ` [CI 14/21] drm/exec: drm_exec_trylock() Thomas Hellström
2024-05-15  8:14 ` Thomas Hellström [this message]
2024-05-15  8:14 ` [CI 16/21] drm/exec: Introduce an evict mode Thomas Hellström
2024-05-15  8:14 ` [CI 17/21] drm/ttm: Support drm_exec locking for eviction and swapping Thomas Hellström
2024-05-15  8:14 ` [CI 18/21] drm/ttm: Convert ttm vm to using drm_exec Thomas Hellström
2024-05-15  8:14 ` [CI 19/21] drm/xe: Use drm_exec for fault locking Thomas Hellström
2024-05-15  8:14 ` [CI 20/21] drm/ttm: Use drm_exec_trylock for bo initialization Thomas Hellström
2024-05-15  8:14 ` [CI 21/21] drm/xe: Initial support for drm exec locking during validate Thomas Hellström
2024-05-15  8:20 ` ✓ CI.Patch_applied: success for xe bo shrinker and exhaustive eviction Patchwork
2024-05-15  8:21 ` ✗ CI.checkpatch: warning " Patchwork
2024-05-15  8:22 ` ✓ CI.KUnit: success " Patchwork
2024-05-15 14:53 ` ✓ CI.Patch_applied: success for xe bo shrinker and exhaustive eviction (rev2) Patchwork
2024-05-15 14:54 ` ✗ CI.checkpatch: warning " Patchwork
2024-05-15 14:55 ` ✓ CI.KUnit: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240515081449.46646-16-thomas.hellstrom@linux.intel.com \
    --to=thomas.hellstrom@linux.intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox