Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [CI 19/21] drm/xe: Use drm_exec for fault locking
Date: Wed, 15 May 2024 10:14:47 +0200	[thread overview]
Message-ID: <20240515081449.46646-20-thomas.hellstrom@linux.intel.com> (raw)
In-Reply-To: <20240515081449.46646-1-thomas.hellstrom@linux.intel.com>

Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
---
 drivers/gpu/drm/xe/xe_bo.c | 38 +++++++++++++++++++++++---------------
 1 file changed, 23 insertions(+), 15 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_bo.c b/drivers/gpu/drm/xe/xe_bo.c
index 3c56858e0751..27d7d36401b5 100644
--- a/drivers/gpu/drm/xe/xe_bo.c
+++ b/drivers/gpu/drm/xe/xe_bo.c
@@ -1217,29 +1217,37 @@ static vm_fault_t xe_gem_fault(struct vm_fault *vmf)
 	struct xe_device *xe = to_xe_device(ddev);
 	struct xe_bo *bo = ttm_to_xe_bo(tbo);
 	bool needs_rpm = bo->flags & XE_BO_FLAG_VRAM_MASK;
+	struct drm_exec exec;
 	vm_fault_t ret;
-	int idx;
+	int idx, err;
 
 	if (needs_rpm)
 		xe_pm_runtime_get(xe);
 
-	ret = ttm_bo_vm_reserve(tbo, vmf, NULL);
-	if (ret)
-		goto out;
+	drm_exec_init(&exec, DRM_EXEC_INTERRUPTIBLE_WAIT, 16);
+	drm_exec_until_all_locked(&exec) {
+		ret = ttm_bo_vm_reserve(tbo, vmf, &exec);
+		err = drm_exec_retry_on_contention(&exec, 0);
+		if (err)
+			ret = VM_FAULT_NOPAGE;
+		if (ret)
+			goto out;
 
-	if (drm_dev_enter(ddev, &idx)) {
-		trace_xe_bo_cpu_fault(bo);
+		if (drm_dev_enter(ddev, &idx)) {
+			trace_xe_bo_cpu_fault(bo);
 
-		ret = ttm_bo_vm_fault_reserved(vmf, vmf->vma->vm_page_prot,
-					       TTM_BO_VM_NUM_PREFAULT,
-					       NULL);
-		drm_dev_exit(idx);
-	} else {
-		ret = ttm_bo_vm_dummy_page(vmf, vmf->vma->vm_page_prot);
+			ret = ttm_bo_vm_fault_reserved(vmf, vmf->vma->vm_page_prot,
+						       TTM_BO_VM_NUM_PREFAULT,
+						       &exec);
+			drm_dev_exit(idx);
+			err = drm_exec_retry_on_contention(&exec, 0);
+			if (err)
+				ret = VM_FAULT_NOPAGE;
+		} else {
+			ret = ttm_bo_vm_dummy_page(vmf, vmf->vma->vm_page_prot);
+		}
 	}
 
-	if (ret == VM_FAULT_RETRY && !(vmf->flags & FAULT_FLAG_RETRY_NOWAIT))
-		goto out;
 	/*
 	 * ttm_bo_vm_reserve() already has dma_resv_lock.
 	 */
@@ -1250,8 +1258,8 @@ static vm_fault_t xe_gem_fault(struct vm_fault *vmf)
 		mutex_unlock(&xe->mem_access.vram_userfault.lock);
 	}
 
-	dma_resv_unlock(tbo->base.resv);
 out:
+	drm_exec_fini(&exec);
 	if (needs_rpm)
 		xe_pm_runtime_put(xe);
 
-- 
2.44.0


  parent reply	other threads:[~2024-05-15  8:15 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-15  8:14 [CI 00/21] xe bo shrinker and exhaustive eviction Thomas Hellström
2024-05-15  8:14 ` [CI 01/21] drm/ttm: Allow TTM LRU list nodes of different types Thomas Hellström
2024-05-15  8:14 ` [CI 02/21] drm/ttm: Slightly clean up LRU list iteration Thomas Hellström
2024-05-15  8:14 ` [CI 03/21] drm/ttm: Use LRU hitches Thomas Hellström
2024-05-15  8:14 ` [CI 04/21] drm/ttm, drm/amdgpu, drm/xe: Consider hitch moves within bulk sublist moves Thomas Hellström
2024-05-15  8:14 ` [CI 05/21] drm/exec: Rework contended locking Thomas Hellström
2024-05-15  8:14 ` [CI 06/21] drm/ttm: Provide a generic LRU walker helper Thomas Hellström
2024-05-15  8:14 ` [CI 07/21] drm/ttm: Use restartable LRU and sleeping locks for swapping Thomas Hellström
2024-05-15  8:14 ` [CI 08/21] drm/ttm: sleeping evict lock Thomas Hellström
2024-05-15  8:14 ` [CI 09/21] drm/ttm: Add a virtual base class for graphics memory backup Thomas Hellström
2024-05-15  8:14 ` [CI 10/21] drm/ttm/pool: Provide a helper to shrink pages Thomas Hellström
2024-05-15  8:14 ` [CI 11/21] drm/ttm: Use fault-injection to test error paths Thomas Hellström
2024-05-15  8:14 ` [CI 12/21] drm/ttm, drm/xe: Add a shrinker for xe bos Thomas Hellström
2024-05-15  8:14 ` [CI 13/21] dma-buf/dma-resv: Introduce dma_resv_trylock_ctx() Thomas Hellström
2024-05-15  8:14 ` [CI 14/21] drm/exec: drm_exec_trylock() Thomas Hellström
2024-05-15  8:14 ` [CI 15/21] drm/exec: Add a snapshot capability Thomas Hellström
2024-05-15  8:14 ` [CI 16/21] drm/exec: Introduce an evict mode Thomas Hellström
2024-05-15  8:14 ` [CI 17/21] drm/ttm: Support drm_exec locking for eviction and swapping Thomas Hellström
2024-05-15  8:14 ` [CI 18/21] drm/ttm: Convert ttm vm to using drm_exec Thomas Hellström
2024-05-15  8:14 ` Thomas Hellström [this message]
2024-05-15  8:14 ` [CI 20/21] drm/ttm: Use drm_exec_trylock for bo initialization Thomas Hellström
2024-05-15  8:14 ` [CI 21/21] drm/xe: Initial support for drm exec locking during validate Thomas Hellström
2024-05-15  8:20 ` ✓ CI.Patch_applied: success for xe bo shrinker and exhaustive eviction Patchwork
2024-05-15  8:21 ` ✗ CI.checkpatch: warning " Patchwork
2024-05-15  8:22 ` ✓ CI.KUnit: success " Patchwork
2024-05-15 14:53 ` ✓ CI.Patch_applied: success for xe bo shrinker and exhaustive eviction (rev2) Patchwork
2024-05-15 14:54 ` ✗ CI.checkpatch: warning " Patchwork
2024-05-15 14:55 ` ✓ CI.KUnit: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240515081449.46646-20-thomas.hellstrom@linux.intel.com \
    --to=thomas.hellstrom@linux.intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox