Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>,
	Lucas De Marchi <lucas.demarchi@intel.com>
Subject: [PATCH 3/3] drm/xe: Use platform name in xe_assert()
Date: Tue, 21 May 2024 16:22:57 +0200	[thread overview]
Message-ID: <20240521142257.756-4-michal.wajdeczko@intel.com> (raw)
In-Reply-To: <20240521142257.756-1-michal.wajdeczko@intel.com>

We can now use more user-friendly platform name instead of
previosly used magic platform enumerator value:

  [ ] xe 0000:00:02.0: [drm] Assertion `false` failed!
      platform: ALDERLAKE_S ...
  [ ] xe 0000:03:00.0: [drm] Assertion `false` failed!
      platform: DG2 ...

vs

  [ ] xe 0000:00:02.0: [drm] Assertion `false` failed!
      platform: 3 ...
  [ ] xe 0000:03:00.0: [drm] Assertion `false` failed!
      platform: 7 ...

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
---
 drivers/gpu/drm/xe/xe_assert.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_assert.h b/drivers/gpu/drm/xe/xe_assert.h
index 34c142e6cfb0..8b0cc1bc9327 100644
--- a/drivers/gpu/drm/xe/xe_assert.h
+++ b/drivers/gpu/drm/xe/xe_assert.h
@@ -109,11 +109,11 @@
 #define xe_assert_msg(xe, condition, msg, arg...) ({						\
 	const struct xe_device *__xe = (xe);							\
 	__xe_assert_msg(__xe, condition,							\
-			"platform: %d subplatform: %d\n"					\
+			"platform: %s subplatform: %d\n"					\
 			"graphics: %s %u.%02u step %s\n"					\
 			"media: %s %u.%02u step %s\n"						\
 			msg,									\
-			__xe->info.platform, __xe->info.subplatform,				\
+			__xe->info.platform_name, __xe->info.subplatform,			\
 			__xe->info.graphics_name,						\
 			__xe->info.graphics_verx100 / 100,					\
 			__xe->info.graphics_verx100 % 100,					\
-- 
2.43.0


  parent reply	other threads:[~2024-05-21 14:23 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-21 14:22 [PATCH 0/3] Store platform name in xe_device.info Michal Wajdeczko
2024-05-21 14:22 ` [PATCH 1/3] drm/xe: " Michal Wajdeczko
2024-05-22 16:28   ` Rodrigo Vivi
2024-05-21 14:22 ` [PATCH 2/3] drm/xe: Drop undesired prefix from the platform name Michal Wajdeczko
2024-05-22 16:29   ` Rodrigo Vivi
2024-05-21 14:22 ` Michal Wajdeczko [this message]
2024-05-22 16:29   ` [PATCH 3/3] drm/xe: Use platform name in xe_assert() Rodrigo Vivi
2024-05-21 16:39 ` ✓ CI.Patch_applied: success for Store platform name in xe_device.info Patchwork
2024-05-21 16:39 ` ✓ CI.checkpatch: " Patchwork
2024-05-21 16:40 ` ✓ CI.KUnit: " Patchwork
2024-05-21 16:52 ` ✓ CI.Build: " Patchwork
2024-05-21 16:54 ` ✓ CI.Hooks: " Patchwork
2024-05-21 16:56 ` ✓ CI.checksparse: " Patchwork
2024-05-21 17:28 ` ✓ CI.BAT: " Patchwork
2024-05-21 22:53 ` ✗ CI.FULL: failure " Patchwork
2024-05-22 21:37   ` Michal Wajdeczko
2024-05-28 14:18 ` [PATCH 0/3] " Michal Wajdeczko
2024-05-29 17:29   ` Lucas De Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240521142257.756-4-michal.wajdeczko@intel.com \
    --to=michal.wajdeczko@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox