Re: [PATCH 3/3] drm/xe: Use platform name in xe_assert()

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Tue, May 21, 2024 at 04:22:57PM +0200, Michal Wajdeczko wrote:
> We can now use more user-friendly platform name instead of
> previosly used magic platform enumerator value:
> 
>   [ ] xe 0000:00:02.0: [drm] Assertion `false` failed!
>       platform: ALDERLAKE_S ...
>   [ ] xe 0000:03:00.0: [drm] Assertion `false` failed!
>       platform: DG2 ...
> 
> vs
> 
>   [ ] xe 0000:00:02.0: [drm] Assertion `false` failed!
>       platform: 3 ...
>   [ ] xe 0000:03:00.0: [drm] Assertion `false` failed!
>       platform: 7 ...
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_assert.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_assert.h b/drivers/gpu/drm/xe/xe_assert.h
> index 34c142e6cfb0..8b0cc1bc9327 100644
> --- a/drivers/gpu/drm/xe/xe_assert.h
> +++ b/drivers/gpu/drm/xe/xe_assert.h
> @@ -109,11 +109,11 @@
>  #define xe_assert_msg(xe, condition, msg, arg...) ({						\
>  	const struct xe_device *__xe = (xe);							\
>  	__xe_assert_msg(__xe, condition,							\
> -			"platform: %d subplatform: %d\n"					\
> +			"platform: %s subplatform: %d\n"					\
>  			"graphics: %s %u.%02u step %s\n"					\
>  			"media: %s %u.%02u step %s\n"						\
>  			msg,									\
> -			__xe->info.platform, __xe->info.subplatform,				\
> +			__xe->info.platform_name, __xe->info.subplatform,			\
>  			__xe->info.graphics_name,						\
>  			__xe->info.graphics_verx100 / 100,					\
>  			__xe->info.graphics_verx100 % 100,					\
> -- 
> 2.43.0
>