Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Oak Zeng <oak.zeng@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: thomas.hellstrom@linux.intel.com
Subject: [PATCH] drm/xe: Add more document to xe_vm::lock
Date: Mon, 27 May 2024 16:07:31 -0700	[thread overview]
Message-ID: <20240527230731.1888261-1-oak.zeng@intel.com> (raw)

More document is added to xe_vm::lock to describe what is protected
by this lock.

Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Signed-off-by: Oak Zeng <oak.zeng@intel.com>
---
 drivers/gpu/drm/xe/xe_vm_types.h | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_vm_types.h b/drivers/gpu/drm/xe/xe_vm_types.h
index ce1a63a5e3e7..5597d8072046 100644
--- a/drivers/gpu/drm/xe/xe_vm_types.h
+++ b/drivers/gpu/drm/xe/xe_vm_types.h
@@ -161,7 +161,18 @@ struct xe_vm {
 
 	/**
 	 * @lock: outer most lock, protects objects of anything attached to this
-	 * VM
+	 * VM, more specifically:
+	 * 1) vm::rebind_list
+	 * 2) vm::flags, only XE_VM_FLA_BANNED bit
+	 * 3) vma::tile_present
+	 * 4) userptr::repin_list
+	 * 5) userptr::invalidated list
+	 * 6) vm::preempt::exec_queue
+	 * 7) drm_gpuvm::rb list and tree
+	 * 8) vm::size
+	 * 9) vm::q[]->last_fence, only if q->flags' EXEC_QUEUE_FLAG_VM is set,
+	 *    see xe_exec_queue_last_fence_lockdep_assert
+	 * 10) a contested list during vm close. see xe_vm_close_and_put
 	 */
 	struct rw_semaphore lock;
 	/**
-- 
2.25.1


             reply	other threads:[~2024-05-27 21:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-27 23:07 Oak Zeng [this message]
2024-05-27 22:14 ` ✓ CI.Patch_applied: success for drm/xe: Add more document to xe_vm::lock Patchwork
2024-05-27 22:15 ` ✓ CI.KUnit: " Patchwork
2024-05-27 22:27 ` ✓ CI.Build: " Patchwork
2024-05-27 22:28 ` ✗ CI.Hooks: failure " Patchwork
2024-05-27 22:30 ` ✓ CI.checksparse: success " Patchwork
2024-05-27 22:53 ` ✗ CI.BAT: failure " Patchwork
2024-05-27 23:45 ` ✗ CI.FULL: " Patchwork
2024-05-28  7:22 ` [PATCH] " Thomas Hellström
2024-05-28 13:22   ` Zeng, Oak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240527230731.1888261-1-oak.zeng@intel.com \
    --to=oak.zeng@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=thomas.hellstrom@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox