Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe: Add more document to xe_vm::lock
@ 2024-05-27 23:07 Oak Zeng
  2024-05-27 22:14 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (7 more replies)
  0 siblings, 8 replies; 10+ messages in thread
From: Oak Zeng @ 2024-05-27 23:07 UTC (permalink / raw)
  To: intel-xe; +Cc: thomas.hellstrom

More document is added to xe_vm::lock to describe what is protected
by this lock.

Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Signed-off-by: Oak Zeng <oak.zeng@intel.com>
---
 drivers/gpu/drm/xe/xe_vm_types.h | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_vm_types.h b/drivers/gpu/drm/xe/xe_vm_types.h
index ce1a63a5e3e7..5597d8072046 100644
--- a/drivers/gpu/drm/xe/xe_vm_types.h
+++ b/drivers/gpu/drm/xe/xe_vm_types.h
@@ -161,7 +161,18 @@ struct xe_vm {
 
 	/**
 	 * @lock: outer most lock, protects objects of anything attached to this
-	 * VM
+	 * VM, more specifically:
+	 * 1) vm::rebind_list
+	 * 2) vm::flags, only XE_VM_FLA_BANNED bit
+	 * 3) vma::tile_present
+	 * 4) userptr::repin_list
+	 * 5) userptr::invalidated list
+	 * 6) vm::preempt::exec_queue
+	 * 7) drm_gpuvm::rb list and tree
+	 * 8) vm::size
+	 * 9) vm::q[]->last_fence, only if q->flags' EXEC_QUEUE_FLAG_VM is set,
+	 *    see xe_exec_queue_last_fence_lockdep_assert
+	 * 10) a contested list during vm close. see xe_vm_close_and_put
 	 */
 	struct rw_semaphore lock;
 	/**
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2024-05-28 13:22 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-27 23:07 [PATCH] drm/xe: Add more document to xe_vm::lock Oak Zeng
2024-05-27 22:14 ` ✓ CI.Patch_applied: success for " Patchwork
2024-05-27 22:15 ` ✓ CI.KUnit: " Patchwork
2024-05-27 22:27 ` ✓ CI.Build: " Patchwork
2024-05-27 22:28 ` ✗ CI.Hooks: failure " Patchwork
2024-05-27 22:30 ` ✓ CI.checksparse: success " Patchwork
2024-05-27 22:53 ` ✗ CI.BAT: failure " Patchwork
2024-05-27 23:45 ` ✗ CI.FULL: " Patchwork
2024-05-28  7:22 ` [PATCH] " Thomas Hellström
2024-05-28 13:22   ` Zeng, Oak

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox