Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andrzej Hajda <andrzej.hajda@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
	"Matthew Brost" <matthew.brost@intel.com>,
	"Lucas De Marchi" <lucas.demarchi@intel.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Matthew Auld" <matthew.auld@intel.com>,
	"Andrzej Hajda" <andrzej.hajda@intel.com>
Subject: [PATCH v2 0/2] drm/xe: flush engine buffers before signalling user fence on all engines
Date: Tue, 04 Jun 2024 11:38:50 +0200	[thread overview]
Message-ID: <20240604-fix_user_fence_posted-v2-0-9276ecef973a@intel.com> (raw)

According to the discussion result on my previous patch I have prepared
new patchset, which reverts previous patch and adds barrier before
user fence signalling.
Remarks:
- I was not able to test it yet, hopefully CI will do it and me also after fixing LNL issue,
- I am not sure about MI_FLUSH_DW flags, bspec says:
  "After this command is completed with a Store DWord enabled, CPU access to graphics memory will be coherent"
  Shouldn't we use "Store DWord" then?

[1]: https://lore.kernel.org/intel-xe/Zl5DcuZeZiFgxVdJ@DUT025-TGLU.fm.intel.com/T/#m0b4420045908bac70426728d460108c0b2b65dca

Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
- Link to v1: https://lore.kernel.org/r/20240603-fix_user_fence_posted-v1-1-61c76ef69cea@intel.com

---
Andrzej Hajda (2):
      Revert "drm/xe: flush gtt before signalling user fence on all engines"
      drm/xe: flush engine buffers before signalling user fence on all engines

 drivers/gpu/drm/xe/xe_ring_ops.c | 26 ++++++++++++++++++++------
 1 file changed, 20 insertions(+), 6 deletions(-)
---
base-commit: fe3d637a9c72b22297da0c731fa5e217bd182d2d
change-id: 20240603-fix_user_fence_posted-ca56c79c0662

Best regards,
-- 
Andrzej Hajda <andrzej.hajda@intel.com>


             reply	other threads:[~2024-06-04  9:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-04  9:38 Andrzej Hajda [this message]
2024-06-04  9:38 ` [PATCH v2 1/2] Revert "drm/xe: flush gtt before signalling user fence on all engines" Andrzej Hajda
2024-06-04  9:38 ` [PATCH v2 2/2] drm/xe: flush engine buffers before signalling user fence on all engines Andrzej Hajda
2024-06-04 11:07 ` [PATCH v2 0/2] " Thomas Hellström
2024-06-04 14:58   ` Andrzej Hajda
2024-06-04 15:39     ` Thomas Hellström
2024-06-04 23:33 ` ✓ CI.Patch_applied: success for " Patchwork
2024-06-04 23:33 ` ✓ CI.checkpatch: " Patchwork
2024-06-04 23:34 ` ✓ CI.KUnit: " Patchwork
2024-06-04 23:46 ` ✓ CI.Build: " Patchwork
2024-06-04 23:46 ` ✗ CI.Hooks: failure " Patchwork
2024-06-04 23:47 ` ✓ CI.checksparse: success " Patchwork
2024-06-05  0:15 ` ✓ CI.BAT: " Patchwork
2024-06-05  7:53 ` ✓ CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240604-fix_user_fence_posted-v2-0-9276ecef973a@intel.com \
    --to=andrzej.hajda@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=matthew.auld@intel.com \
    --cc=matthew.brost@intel.com \
    --cc=thomas.hellstrom@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox