Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: gustavo.sousa@intel.com,
	Radhakrishna Sripada <radhakrishna.sripada@intel.com>
Subject: [PATCH v5 0/6] Tracing cleanup and add mmio tracing
Date: Thu,  6 Jun 2024 15:38:13 -0700	[thread overview]
Message-ID: <20240606223819.3545560-1-radhakrishna.sripada@intel.com> (raw)

xe_trace.h is getting bloated. Group related events to their own
files. All bo, vm and vma related events have been moved to 
xe_trace_bo.h. GuC related trace events have been moved to
xe_trace_guc.h. Patches 1 and 2 splits the trace events into
seperate files.

In multi gpu environments, it is important to know the device from
which the event was triggered. Print the device id information along
with the trace information being printed. Patches 3, 4 and 5 make
changes to print the device id's if not already captured.

Mmio reg read writes are important tracing information that needs to be
captured and will be helpful in display debug. Patch 6 adds the reg
read/write tracing support.

Earlier versions of patch 6 can be found here:
v1: https://patchwork.freedesktop.org/series/119312/
v2: https://patchwork.freedesktop.org/series/132626/

v4: Fixes the review comments from Gustavo
v5: Fixes the kunit error reported.

Radhakrishna Sripada (6):
  drm/xe/trace: Extract bo, vm, vma traces
  drm/xe/trace: Extract guc related traces
  drm/xe/trace: Print device_id in xe_trace_bo events
  drm/xe/trace: Print device_id in xe_trace_guc events
  drm/xe/trace: Print device_id in xe_trace events
  drm/xe: Add reg read/write trace

 drivers/gpu/drm/xe/Makefile                 |   2 +
 drivers/gpu/drm/xe/xe_bo.c                  |   2 +-
 drivers/gpu/drm/xe/xe_gt_pagefault.c        |   2 +-
 drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c |  27 +-
 drivers/gpu/drm/xe/xe_guc_ct.c              |  13 +-
 drivers/gpu/drm/xe/xe_migrate.c             |   2 +-
 drivers/gpu/drm/xe/xe_mmio.c                |  24 +-
 drivers/gpu/drm/xe/xe_pt.c                  |   8 +-
 drivers/gpu/drm/xe/xe_trace.h               | 381 ++++----------------
 drivers/gpu/drm/xe/xe_trace_bo.c            |   9 +
 drivers/gpu/drm/xe/xe_trace_bo.h            | 248 +++++++++++++
 drivers/gpu/drm/xe/xe_trace_guc.c           |   9 +
 drivers/gpu/drm/xe/xe_trace_guc.h           | 111 ++++++
 drivers/gpu/drm/xe/xe_vm.c                  |   2 +-
 14 files changed, 496 insertions(+), 344 deletions(-)
 create mode 100644 drivers/gpu/drm/xe/xe_trace_bo.c
 create mode 100644 drivers/gpu/drm/xe/xe_trace_bo.h
 create mode 100644 drivers/gpu/drm/xe/xe_trace_guc.c
 create mode 100644 drivers/gpu/drm/xe/xe_trace_guc.h

-- 
2.34.1


             reply	other threads:[~2024-06-06 22:39 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-06 22:38 Radhakrishna Sripada [this message]
2024-06-06 22:38 ` [PATCH v5 1/6] drm/xe/trace: Extract bo, vm, vma traces Radhakrishna Sripada
2024-06-06 22:38 ` [PATCH v5 2/6] drm/xe/trace: Extract guc related traces Radhakrishna Sripada
2024-06-06 22:38 ` [PATCH v5 3/6] drm/xe/trace: Print device_id in xe_trace_bo events Radhakrishna Sripada
2024-06-07 13:23   ` Gustavo Sousa
2024-06-06 22:38 ` [PATCH v5 4/6] drm/xe/trace: Print device_id in xe_trace_guc events Radhakrishna Sripada
2024-06-07 13:50   ` Gustavo Sousa
2024-06-06 22:38 ` [PATCH v5 5/6] drm/xe/trace: Print device_id in xe_trace events Radhakrishna Sripada
2024-06-07 14:35   ` Gustavo Sousa
2024-06-06 22:38 ` [PATCH v5 6/6] drm/xe: Add reg read/write trace Radhakrishna Sripada
2024-06-07 14:52   ` Gustavo Sousa
2024-06-06 22:45 ` ✓ CI.Patch_applied: success for Tracing cleanup and add mmio tracing (rev3) Patchwork
2024-06-06 22:45 ` ✗ CI.checkpatch: warning " Patchwork
2024-06-06 22:46 ` ✓ CI.KUnit: success " Patchwork
2024-06-06 22:58 ` ✓ CI.Build: " Patchwork
2024-06-06 23:00 ` ✓ CI.Hooks: " Patchwork
2024-06-06 23:02 ` ✓ CI.checksparse: " Patchwork
2024-06-06 23:44 ` ✓ CI.BAT: " Patchwork
2024-06-07  8:37 ` ✗ CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240606223819.3545560-1-radhakrishna.sripada@intel.com \
    --to=radhakrishna.sripada@intel.com \
    --cc=gustavo.sousa@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox