Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/1] Xe OA Consolidated Diffs
@ 2024-01-20  1:49 Ashutosh Dixit
  0 siblings, 0 replies; 10+ messages in thread
From: Ashutosh Dixit @ 2024-01-20  1:49 UTC (permalink / raw)
  To: intel-xe

Because Xe OA changes between successive revisions are distributed across
multiple patches, I am providing a combined diff of all changes in a single
patch to help with the code review.

These changes pertain to: https://patchwork.freedesktop.org/series/121084/

Ashutosh Dixit (1):
  drm/xe/oa: Combined diff of changes between v7 and v8

 drivers/gpu/drm/xe/regs/xe_oa_regs.h |   9 +-
 drivers/gpu/drm/xe/xe_device.c       |   7 +-
 drivers/gpu/drm/xe/xe_module.c       |   4 -
 drivers/gpu/drm/xe/xe_oa.c           | 420 +++++++--------------------
 drivers/gpu/drm/xe/xe_oa.h           |   3 -
 drivers/gpu/drm/xe/xe_oa_types.h     |   5 +-
 include/uapi/drm/xe_drm.h            | 162 ++++-------
 7 files changed, 174 insertions(+), 436 deletions(-)

-- 
2.41.0


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 0/1] Xe OA Consolidated Diffs
@ 2024-02-08  5:35 Ashutosh Dixit
  0 siblings, 0 replies; 10+ messages in thread
From: Ashutosh Dixit @ 2024-02-08  5:35 UTC (permalink / raw)
  To: intel-xe; +Cc: Umesh Nerlige Ramappa

Because Xe OA changes between successive revisions are distributed across
multiple patches, I am providing a combined diff of all changes in a single
patch to help with the code review.

These changes pertain to: https://patchwork.freedesktop.org/series/121084/

Ashutosh Dixit (1):
  drm/xe/oa: Combined diff of changes between v8 and v9

 drivers/gpu/drm/xe/xe_oa.c    | 87 +++++++++++++++++++----------------
 drivers/gpu/drm/xe/xe_query.c |  8 ++--
 include/uapi/drm/xe_drm.h     | 73 ++++++++++++++++++++++-------
 3 files changed, 106 insertions(+), 62 deletions(-)

-- 
2.41.0


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 0/1] Xe OA Consolidated Diffs
@ 2024-02-13  6:35 Ashutosh Dixit
  0 siblings, 0 replies; 10+ messages in thread
From: Ashutosh Dixit @ 2024-02-13  6:35 UTC (permalink / raw)
  To: intel-xe; +Cc: Umesh Nerlige Ramappa

Because Xe OA changes between successive revisions are distributed across
multiple patches, I am providing a combined diff of all changes in a single
patch to help with the code review.

These changes pertain to: https://patchwork.freedesktop.org/series/121084/

Ashutosh Dixit (1):
  drm/xe/oa: Combined diff of changes between v9 and v10

 drivers/gpu/drm/xe/xe_guc_pc.c   | 12 ++++------
 drivers/gpu/drm/xe/xe_oa_types.h | 12 ++++------
 drivers/gpu/drm/xe/xe_query.c    |  4 +---
 include/uapi/drm/xe_drm.h        | 40 +++++++++++++++++++-------------
 4 files changed, 33 insertions(+), 35 deletions(-)

-- 
2.41.0


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 0/1] Xe OA Consolidated Diffs
@ 2024-03-05  5:21 Ashutosh Dixit
  0 siblings, 0 replies; 10+ messages in thread
From: Ashutosh Dixit @ 2024-03-05  5:21 UTC (permalink / raw)
  To: intel-xe; +Cc: Umesh Nerlige Ramappa

Because Xe OA changes between successive revisions are distributed across
multiple patches, I am providing a combined diff of all changes in a single
patch to help with the code review.

These changes pertain to: https://patchwork.freedesktop.org/series/121084/

Ashutosh Dixit (1):
  drm/xe/oa: Combined diff of changes between v10 and v11

 drivers/gpu/drm/xe/xe_oa.c       | 21 +++++++++++++++------
 drivers/gpu/drm/xe/xe_oa_types.h |  2 +-
 include/uapi/drm/xe_drm.h        | 19 +++++++++++++++++--
 3 files changed, 33 insertions(+), 9 deletions(-)

-- 
2.41.0


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 0/1] Xe OA Consolidated Diffs
@ 2024-05-24 18:24 Ashutosh Dixit
  0 siblings, 0 replies; 10+ messages in thread
From: Ashutosh Dixit @ 2024-05-24 18:24 UTC (permalink / raw)
  To: intel-xe

Because Xe OA changes between successive revisions are distributed across
multiple patches, I am providing a combined diff of all changes in a single
patch to help with the code review.

These changes pertain to: https://patchwork.freedesktop.org/series/121084/

Ashutosh Dixit (1):
  drm/xe/oa: Combined diff of changes between v13 and v14

 drivers/gpu/drm/xe/regs/xe_oa_regs.h |  4 ++
 drivers/gpu/drm/xe/xe_guc_pc.c       |  9 +--
 drivers/gpu/drm/xe/xe_oa.c           | 98 +++++++++++++++++++---------
 drivers/gpu/drm/xe/xe_oa_types.h     |  3 +
 include/uapi/drm/xe_drm.h            | 21 +++---
 5 files changed, 93 insertions(+), 42 deletions(-)

-- 
2.41.0


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 0/1] Xe OA Consolidated Diffs
@ 2024-05-27  1:36 Ashutosh Dixit
  0 siblings, 0 replies; 10+ messages in thread
From: Ashutosh Dixit @ 2024-05-27  1:36 UTC (permalink / raw)
  To: intel-xe

Because Xe OA changes between successive revisions are distributed across
multiple patches, I am providing a combined diff of all changes in a single
patch to help with the code review.

These changes pertain to: https://patchwork.freedesktop.org/series/121084/

Ashutosh Dixit (1):
  drm/xe/oa: Combined diff of changes between v14 and v15

 drivers/gpu/drm/xe/xe_oa.c   | 16 +++++++---------
 drivers/gpu/drm/xe/xe_oa.h   |  9 +++------
 drivers/gpu/drm/xe/xe_perf.c |  6 +++---
 3 files changed, 13 insertions(+), 18 deletions(-)

-- 
2.41.0


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 0/1] Xe OA Consolidated Diffs
@ 2024-06-07 20:36 Ashutosh Dixit
  2024-06-07 20:36 ` [PATCH 1/1] drm/xe/oa: Combined diff of changes between v15 and v16 Ashutosh Dixit
  2024-06-07 21:33 ` ✗ CI.Patch_applied: failure for Xe OA Consolidated Diffs Patchwork
  0 siblings, 2 replies; 10+ messages in thread
From: Ashutosh Dixit @ 2024-06-07 20:36 UTC (permalink / raw)
  To: intel-xe

Because Xe OA changes between successive revisions are distributed across
multiple patches, I am providing a combined diff of all changes in a single
patch to help with the code review.

These changes pertain to: https://patchwork.freedesktop.org/series/121084/

Ashutosh Dixit (1):
  drm/xe/oa: Combined diff of changes between v15 and v16

 drivers/gpu/drm/xe/xe_device.c |  4 ++--
 drivers/gpu/drm/xe/xe_oa.c     | 10 +++++-----
 2 files changed, 7 insertions(+), 7 deletions(-)

-- 
2.41.0


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 1/1] drm/xe/oa: Combined diff of changes between v15 and v16
  2024-06-07 20:36 [PATCH 0/1] Xe OA Consolidated Diffs Ashutosh Dixit
@ 2024-06-07 20:36 ` Ashutosh Dixit
  2024-06-07 21:33 ` ✗ CI.Patch_applied: failure for Xe OA Consolidated Diffs Patchwork
  1 sibling, 0 replies; 10+ messages in thread
From: Ashutosh Dixit @ 2024-06-07 20:36 UTC (permalink / raw)
  To: intel-xe

Because Xe OA changes between successive revisions are distributed across
multiple patches, provide a combined diff of all changes in a single patch
to help with code review.

These changes pertain to: https://patchwork.freedesktop.org/series/121084/

This patch will not compile, it's purpose is to just provide the diff.

* Rebase on latest Xe changes and a few label renames

Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
 drivers/gpu/drm/xe/xe_device.c |  4 ++--
 drivers/gpu/drm/xe/xe_oa.c     | 10 +++++-----
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
index d61c56b13ec3..d29d8689d4ec 100644
--- a/drivers/gpu/drm/xe/xe_device.c
+++ b/drivers/gpu/drm/xe/xe_device.c
@@ -662,7 +662,7 @@ int xe_device_probe(struct xe_device *xe)
 
 	err = xe_display_init(xe);
 	if (err)
-		goto err_oa_fini;
+		goto err_fini_oa;
 
 	err = drm_dev_register(&xe->drm, 0);
 	if (err)
@@ -681,7 +681,7 @@ int xe_device_probe(struct xe_device *xe)
 err_fini_display:
 	xe_display_driver_remove(xe);
 
-err_oa_fini:
+err_fini_oa:
 	xe_oa_fini(xe);
 
 err_fini_gt:
diff --git a/drivers/gpu/drm/xe/xe_oa.c b/drivers/gpu/drm/xe/xe_oa.c
index 3ed4ca19f9cd..d0a46485571a 100644
--- a/drivers/gpu/drm/xe/xe_oa.c
+++ b/drivers/gpu/drm/xe/xe_oa.c
@@ -686,7 +686,7 @@ static int xe_oa_load_with_lri(struct xe_oa_stream *stream, struct xe_oa_reg *re
 static int xe_oa_configure_oar_context(struct xe_oa_stream *stream, bool enable)
 {
 	const struct xe_oa_format *format = stream->oa_buffer.format;
-	struct xe_lrc *lrc = &stream->exec_q->lrc[0];
+	struct xe_lrc *lrc = stream->exec_q->lrc[0];
 	u32 regs_offset = xe_lrc_regs_offset(lrc) / sizeof(u32);
 	u32 oacontrol = __format_to_oactrl(format, OAR_OACONTROL_COUNTER_SEL_MASK) |
 		(enable ? OAR_OACONTROL_COUNTER_ENABLE : 0);
@@ -708,7 +708,7 @@ static int xe_oa_configure_oar_context(struct xe_oa_stream *stream, bool enable)
 	int err;
 
 	/* Modify stream hwe context image with regs_context */
-	err = xe_oa_modify_ctx_image(stream, &stream->exec_q->lrc[0],
+	err = xe_oa_modify_ctx_image(stream, stream->exec_q->lrc[0],
 				     regs_context, ARRAY_SIZE(regs_context));
 	if (err)
 		return err;
@@ -720,7 +720,7 @@ static int xe_oa_configure_oar_context(struct xe_oa_stream *stream, bool enable)
 static int xe_oa_configure_oac_context(struct xe_oa_stream *stream, bool enable)
 {
 	const struct xe_oa_format *format = stream->oa_buffer.format;
-	struct xe_lrc *lrc = &stream->exec_q->lrc[0];
+	struct xe_lrc *lrc = stream->exec_q->lrc[0];
 	u32 regs_offset = xe_lrc_regs_offset(lrc) / sizeof(u32);
 	u32 oacontrol = __format_to_oactrl(format, OAR_OACONTROL_COUNTER_SEL_MASK) |
 		(enable ? OAR_OACONTROL_COUNTER_ENABLE : 0);
@@ -746,7 +746,7 @@ static int xe_oa_configure_oac_context(struct xe_oa_stream *stream, bool enable)
 	xe_mmio_write32(stream->gt, __oa_regs(stream)->oa_ctrl, __oa_ccs_select(stream));
 
 	/* Modify stream hwe context image with regs_context */
-	err = xe_oa_modify_ctx_image(stream, &stream->exec_q->lrc[0],
+	err = xe_oa_modify_ctx_image(stream, stream->exec_q->lrc[0],
 				     regs_context, ARRAY_SIZE(regs_context));
 	if (err)
 		return err;
@@ -1238,7 +1238,7 @@ static bool xe_oa_find_reg_in_lri(u32 *state, u32 reg, u32 *offset, u32 end)
 
 static u32 xe_oa_context_image_offset(struct xe_oa_stream *stream, u32 reg)
 {
-	struct xe_lrc *lrc = &stream->exec_q->lrc[0];
+	struct xe_lrc *lrc = stream->exec_q->lrc[0];
 	u32 len = (xe_gt_lrc_size(stream->gt, stream->hwe->class) +
 		   lrc->ring.size) / sizeof(u32);
 	u32 offset = xe_lrc_regs_offset(lrc) / sizeof(u32);
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* ✗ CI.Patch_applied: failure for Xe OA Consolidated Diffs
  2024-06-07 20:36 [PATCH 0/1] Xe OA Consolidated Diffs Ashutosh Dixit
  2024-06-07 20:36 ` [PATCH 1/1] drm/xe/oa: Combined diff of changes between v15 and v16 Ashutosh Dixit
@ 2024-06-07 21:33 ` Patchwork
  1 sibling, 0 replies; 10+ messages in thread
From: Patchwork @ 2024-06-07 21:33 UTC (permalink / raw)
  To: Ashutosh Dixit; +Cc: intel-xe

== Series Details ==

Series: Xe OA Consolidated Diffs
URL   : https://patchwork.freedesktop.org/series/134634/
State : failure

== Summary ==

=== Applying kernel patches on branch 'drm-tip' with base: ===
Base commit: 2bea08bd3129 drm-tip: 2024y-06m-07d-19h-26m-01s UTC integration manifest
=== git am output follows ===
error: patch failed: drivers/gpu/drm/xe/xe_device.c:662
error: drivers/gpu/drm/xe/xe_device.c: patch does not apply
error: drivers/gpu/drm/xe/xe_oa.c: does not exist in index
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Applying: drm/xe/oa: Combined diff of changes between v15 and v16
Patch failed at 0001 drm/xe/oa: Combined diff of changes between v15 and v16
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".



^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 0/1] Xe OA Consolidated Diffs
@ 2024-06-12  1:53 Ashutosh Dixit
  0 siblings, 0 replies; 10+ messages in thread
From: Ashutosh Dixit @ 2024-06-12  1:53 UTC (permalink / raw)
  To: intel-xe; +Cc: Michal Wajdeczko

Because Xe OA changes between successive revisions are distributed across
multiple patches, I am providing a combined diff of all changes in a single
patch to help with the code review.

These changes pertain to: https://patchwork.freedesktop.org/series/121084/

Ashutosh Dixit (1):
  drm/xe/oa: Combined diff of changes between v16 and v17

 .../gpu/drm/xe/instructions/xe_mi_commands.h  |  2 -
 drivers/gpu/drm/xe/regs/xe_oa_regs.h          |  5 +-
 drivers/gpu/drm/xe/xe_device.c                |  2 -
 drivers/gpu/drm/xe/xe_guc_pc.c                |  8 +-
 drivers/gpu/drm/xe/xe_guc_pc.h                |  2 +-
 drivers/gpu/drm/xe/xe_module.c                |  1 -
 drivers/gpu/drm/xe/xe_oa.c                    | 95 +++++++++++++++----
 drivers/gpu/drm/xe/xe_oa.h                    |  2 +-
 drivers/gpu/drm/xe/xe_oa_types.h              | 23 +++--
 drivers/gpu/drm/xe/xe_perf.c                  | 27 +++++-
 drivers/gpu/drm/xe/xe_perf.h                  |  4 +-
 include/uapi/drm/xe_drm.h                     | 22 ++++-
 12 files changed, 142 insertions(+), 51 deletions(-)

-- 
2.41.0


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2024-06-12  1:53 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-07 20:36 [PATCH 0/1] Xe OA Consolidated Diffs Ashutosh Dixit
2024-06-07 20:36 ` [PATCH 1/1] drm/xe/oa: Combined diff of changes between v15 and v16 Ashutosh Dixit
2024-06-07 21:33 ` ✗ CI.Patch_applied: failure for Xe OA Consolidated Diffs Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2024-06-12  1:53 [PATCH 0/1] " Ashutosh Dixit
2024-05-27  1:36 Ashutosh Dixit
2024-05-24 18:24 Ashutosh Dixit
2024-03-05  5:21 Ashutosh Dixit
2024-02-13  6:35 Ashutosh Dixit
2024-02-08  5:35 Ashutosh Dixit
2024-01-20  1:49 Ashutosh Dixit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox