Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Brost <matthew.brost@intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [PATCH v4 3/7] drm/xe: Improve unexpected state error messages
Date: Mon, 10 Jun 2024 06:50:07 -0700	[thread overview]
Message-ID: <20240610135011.2605272-4-matthew.brost@intel.com> (raw)
In-Reply-To: <20240610135011.2605272-1-matthew.brost@intel.com>

Include G2H handler name when an unexpected error state messages.

Signed-off-by: Matthew Brost <matthew.brost@intel.com>
---
 drivers/gpu/drm/xe/xe_guc_submit.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
index 4464ba337d12..766ff8e48dde 100644
--- a/drivers/gpu/drm/xe/xe_guc_submit.c
+++ b/drivers/gpu/drm/xe/xe_guc_submit.c
@@ -1632,8 +1632,8 @@ int xe_guc_sched_done_handler(struct xe_guc *guc, u32 *msg, u32 len)
 
 	if (unlikely(!exec_queue_pending_enable(q) &&
 		     !exec_queue_pending_disable(q))) {
-		drm_err(&xe->drm, "Unexpected engine state 0x%04x",
-			atomic_read(&q->guc->state));
+		drm_err(&xe->drm, "SCHED_DONE: Unexpected engine state 0x%04x, guc_id=%d",
+			atomic_read(&q->guc->state), q->guc->id);
 		return -EPROTO;
 	}
 
@@ -1671,8 +1671,8 @@ int xe_guc_deregister_done_handler(struct xe_guc *guc, u32 *msg, u32 len)
 
 	if (!exec_queue_destroyed(q) || exec_queue_pending_disable(q) ||
 	    exec_queue_pending_enable(q) || exec_queue_enabled(q)) {
-		drm_err(&xe->drm, "Unexpected engine state 0x%04x",
-			atomic_read(&q->guc->state));
+		drm_err(&xe->drm, "DEREGISTER_DONE: Unexpected engine state 0x%04x, guc_id=%d",
+			atomic_read(&q->guc->state), q->guc->id);
 		return -EPROTO;
 	}
 
-- 
2.34.1


  parent reply	other threads:[~2024-06-10 13:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-10 13:50 [PATCH v4 0/7] Only timeout jobs if they run longer than timeout period Matthew Brost
2024-06-10 13:50 ` [PATCH v4 1/7] drm/xe: Add ctx timestamp to LRC snapshot Matthew Brost
2024-06-10 13:50 ` [PATCH v4 2/7] drm/xe: Add xe_gt_clock_interval_to_ms helper Matthew Brost
2024-06-10 13:50 ` Matthew Brost [this message]
2024-06-10 13:50 ` [PATCH v4 4/7] drm/xe: Add GuC state asserts to deregister_exec_queue Matthew Brost
2024-06-10 13:50 ` [PATCH v4 5/7] drm/xe: Add pending disable assert to handle_sched_done Matthew Brost
2024-06-10 13:50 ` [PATCH v4 6/7] drm/xe: Add killed, banned, or wedged as stick bit during GuC reset Matthew Brost
2024-06-10 13:50 ` [PATCH v4 7/7] drm/xe: Sample ctx timestamp to determine if jobs have timed out Matthew Brost
2024-06-10 13:54 ` ✓ CI.Patch_applied: success for Only timeout jobs if they run longer than timeout period Patchwork
2024-06-10 13:54 ` ✗ CI.checkpatch: warning " Patchwork
2024-06-10 13:55 ` ✗ CI.KUnit: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240610135011.2605272-4-matthew.brost@intel.com \
    --to=matthew.brost@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox