Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Brost <matthew.brost@intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [PATCH v4 4/7] drm/xe: Add GuC state asserts to deregister_exec_queue
Date: Mon, 10 Jun 2024 06:50:08 -0700	[thread overview]
Message-ID: <20240610135011.2605272-5-matthew.brost@intel.com> (raw)
In-Reply-To: <20240610135011.2605272-1-matthew.brost@intel.com>

Will help catch bugs in GuC state machine.

Signed-off-by: Matthew Brost <matthew.brost@intel.com>
---
 drivers/gpu/drm/xe/xe_guc_submit.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
index 766ff8e48dde..e697732f1e74 100644
--- a/drivers/gpu/drm/xe/xe_guc_submit.c
+++ b/drivers/gpu/drm/xe/xe_guc_submit.c
@@ -1587,6 +1587,11 @@ static void deregister_exec_queue(struct xe_guc *guc, struct xe_exec_queue *q)
 		q->guc->id,
 	};
 
+	xe_gt_assert(guc_to_gt(guc), exec_queue_destroyed(q));
+	xe_gt_assert(guc_to_gt(guc), exec_queue_registered(q));
+	xe_gt_assert(guc_to_gt(guc), !exec_queue_pending_disable(q));
+	xe_gt_assert(guc_to_gt(guc), !exec_queue_pending_enable(q));
+
 	trace_xe_exec_queue_deregister(q);
 
 	xe_guc_ct_send_g2h_handler(&guc->ct, action, ARRAY_SIZE(action));
-- 
2.34.1


  parent reply	other threads:[~2024-06-10 13:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-10 13:50 [PATCH v4 0/7] Only timeout jobs if they run longer than timeout period Matthew Brost
2024-06-10 13:50 ` [PATCH v4 1/7] drm/xe: Add ctx timestamp to LRC snapshot Matthew Brost
2024-06-10 13:50 ` [PATCH v4 2/7] drm/xe: Add xe_gt_clock_interval_to_ms helper Matthew Brost
2024-06-10 13:50 ` [PATCH v4 3/7] drm/xe: Improve unexpected state error messages Matthew Brost
2024-06-10 13:50 ` Matthew Brost [this message]
2024-06-10 13:50 ` [PATCH v4 5/7] drm/xe: Add pending disable assert to handle_sched_done Matthew Brost
2024-06-10 13:50 ` [PATCH v4 6/7] drm/xe: Add killed, banned, or wedged as stick bit during GuC reset Matthew Brost
2024-06-10 13:50 ` [PATCH v4 7/7] drm/xe: Sample ctx timestamp to determine if jobs have timed out Matthew Brost
2024-06-10 13:54 ` ✓ CI.Patch_applied: success for Only timeout jobs if they run longer than timeout period Patchwork
2024-06-10 13:54 ` ✗ CI.checkpatch: warning " Patchwork
2024-06-10 13:55 ` ✗ CI.KUnit: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240610135011.2605272-5-matthew.brost@intel.com \
    --to=matthew.brost@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox