Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe: fix error handling in xe_migrate_update_pgtables
@ 2024-06-20 10:20 Matthew Auld
  2024-06-20 10:57 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (15 more replies)
  0 siblings, 16 replies; 17+ messages in thread
From: Matthew Auld @ 2024-06-20 10:20 UTC (permalink / raw)
  To: intel-xe; +Cc: Thomas Hellström, Matthew Brost, stable

Don't call drm_suballoc_free with sa_bo pointing to PTR_ERR.

References: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2120
Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: <stable@vger.kernel.org> # v6.8+
---
 drivers/gpu/drm/xe/xe_migrate.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_migrate.c b/drivers/gpu/drm/xe/xe_migrate.c
index 05f933787860..c9f5673353ee 100644
--- a/drivers/gpu/drm/xe/xe_migrate.c
+++ b/drivers/gpu/drm/xe/xe_migrate.c
@@ -1358,7 +1358,7 @@ xe_migrate_update_pgtables(struct xe_migrate *m,
 						 GFP_KERNEL, true, 0);
 			if (IS_ERR(sa_bo)) {
 				err = PTR_ERR(sa_bo);
-				goto err;
+				goto err_bb;
 			}
 
 			ppgtt_ofs = NUM_KERNEL_PDE +
@@ -1406,7 +1406,7 @@ xe_migrate_update_pgtables(struct xe_migrate *m,
 					 update_idx);
 	if (IS_ERR(job)) {
 		err = PTR_ERR(job);
-		goto err_bb;
+		goto err_sa;
 	}
 
 	/* Wait on BO move */
@@ -1458,10 +1458,10 @@ xe_migrate_update_pgtables(struct xe_migrate *m,
 
 err_job:
 	xe_sched_job_put(job);
+err_sa:
+	drm_suballoc_free(sa_bo, NULL);
 err_bb:
 	xe_bb_free(bb, NULL);
-err:
-	drm_suballoc_free(sa_bo, NULL);
 	return ERR_PTR(err);
 }
 
-- 
2.45.1


^ permalink raw reply related	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2024-06-21  5:35 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-20 10:20 [PATCH] drm/xe: fix error handling in xe_migrate_update_pgtables Matthew Auld
2024-06-20 10:57 ` ✓ CI.Patch_applied: success for " Patchwork
2024-06-20 10:57 ` ✗ CI.checkpatch: warning " Patchwork
2024-06-20 10:58 ` ✓ CI.KUnit: success " Patchwork
2024-06-20 11:10 ` ✓ CI.Build: " Patchwork
2024-06-20 11:13 ` ✗ CI.Hooks: failure " Patchwork
2024-06-20 11:14 ` ✓ CI.checksparse: success " Patchwork
2024-06-20 13:11 ` [PATCH] " Thomas Hellström
2024-06-20 14:13 ` ✗ CI.FULL: failure for " Patchwork
2024-06-21  3:28 ` ✓ CI.Patch_applied: success for drm/xe: fix error handling in xe_migrate_update_pgtables (rev2) Patchwork
2024-06-21  3:28 ` ✗ CI.checkpatch: warning " Patchwork
2024-06-21  3:29 ` ✓ CI.KUnit: success " Patchwork
2024-06-21  3:41 ` ✓ CI.Build: " Patchwork
2024-06-21  3:43 ` ✗ CI.Hooks: failure " Patchwork
2024-06-21  3:44 ` ✓ CI.checksparse: success " Patchwork
2024-06-21  4:11 ` ✓ CI.BAT: " Patchwork
2024-06-21  5:35 ` ✗ CI.FULL: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox