* [PATCHv3] drm/xe/display: Change HPD to polling on runtime suspend
@ 2024-08-12 4:02 Arun R Murthy
2024-08-12 4:18 ` ✗ CI.Patch_applied: failure for drm/xe/display: Change HPD to polling on runtime suspend (rev2) Patchwork
0 siblings, 1 reply; 3+ messages in thread
From: Arun R Murthy @ 2024-08-12 4:02 UTC (permalink / raw)
To: intel-xe, intel-gfx; +Cc: Arun R Murthy
HPD is interrupt based and on runtime suspend change it to polling as
HPD is not a wakeup event. A worker thread is scheduled for doing this
polling and it keeps polling for HPD live status on an internval of 10s.
On runtime resume disable polling and fallback to interrupt mechanism.
v2: move poll_enable() to xe_display(Imre)
v3: removed un-wanted comments (Jani)
Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
---
drivers/gpu/drm/xe/display/xe_display.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c
index 78cccbe28947..426b3f73c104 100644
--- a/drivers/gpu/drm/xe/display/xe_display.c
+++ b/drivers/gpu/drm/xe/display/xe_display.c
@@ -315,6 +315,9 @@ void xe_display_pm_suspend(struct xe_device *xe, bool runtime)
intel_hpd_cancel_work(xe);
+ if (runtime)
+ intel_hpd_poll_enable(xe);
+
intel_suspend_encoders(xe);
intel_opregion_suspend(xe, s2idle ? PCI_D1 : PCI_D3cold);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* ✗ CI.Patch_applied: failure for drm/xe/display: Change HPD to polling on runtime suspend (rev2)
2024-08-12 4:02 [PATCHv3] drm/xe/display: Change HPD to polling on runtime suspend Arun R Murthy
@ 2024-08-12 4:18 ` Patchwork
0 siblings, 0 replies; 3+ messages in thread
From: Patchwork @ 2024-08-12 4:18 UTC (permalink / raw)
To: Arun R Murthy; +Cc: intel-xe
== Series Details ==
Series: drm/xe/display: Change HPD to polling on runtime suspend (rev2)
URL : https://patchwork.freedesktop.org/series/137025/
State : failure
== Summary ==
=== Applying kernel patches on branch 'drm-tip' with base: ===
Base commit: a95e3e46063d drm-tip: 2024y-08m-10d-04h-20m-54s UTC integration manifest
=== git am output follows ===
error: patch failed: drivers/gpu/drm/xe/display/xe_display.c:315
error: drivers/gpu/drm/xe/display/xe_display.c: patch does not apply
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Applying: drm/xe/display: Change HPD to polling on runtime suspend
Patch failed at 0001 drm/xe/display: Change HPD to polling on runtime suspend
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCHv3] drm/xe/display: Change HPD to polling on runtime suspend
@ 2024-08-12 10:32 Arun R Murthy
0 siblings, 0 replies; 3+ messages in thread
From: Arun R Murthy @ 2024-08-12 10:32 UTC (permalink / raw)
To: intel-xe, intel-gfx; +Cc: Arun R Murthy
HPD is interrupt based and on runtime suspend change it to polling as
HPD is not a wakeup event. A worker thread is scheduled for doing this
polling and it keeps polling for HPD live status on an internval of 10s.
On runtime resume disable polling and fallback to interrupt mechanism.
v2: move poll_enable() to xe_display(Imre)
v3: removed un-wanted comments (Jani)
Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
---
drivers/gpu/drm/xe/display/xe_display.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c
index 0e4adde84cb2..4b8b28f96063 100644
--- a/drivers/gpu/drm/xe/display/xe_display.c
+++ b/drivers/gpu/drm/xe/display/xe_display.c
@@ -309,6 +309,9 @@ void xe_display_pm_suspend(struct xe_device *xe, bool runtime)
intel_hpd_cancel_work(xe);
+ if (runtime)
+ intel_hpd_poll_enable(xe);
+
intel_encoder_suspend_all(&xe->display);
intel_opregion_suspend(display, s2idle ? PCI_D1 : PCI_D3cold);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-12 10:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-12 4:02 [PATCHv3] drm/xe/display: Change HPD to polling on runtime suspend Arun R Murthy
2024-08-12 4:18 ` ✗ CI.Patch_applied: failure for drm/xe/display: Change HPD to polling on runtime suspend (rev2) Patchwork
-- strict thread matches above, loose matches on Subject: below --
2024-08-12 10:32 [PATCHv3] drm/xe/display: Change HPD to polling on runtime suspend Arun R Murthy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox