From: Matt Roper <matthew.d.roper@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: matthew.d.roper@intel.com
Subject: [PATCH 0/2] Remove falsely GT-centric design in pcode and hwmon
Date: Thu, 29 Aug 2024 15:06:20 -0700 [thread overview]
Message-ID: <20240829220619.789159-4-matthew.d.roper@intel.com> (raw)
Both the pcode and the hwmon code was using a GT-centric design, even
though these are not GT-level concepts in the hardware. Pcode has a
single instance per tile, and using a GT-centric design means that that
locking isn't actually preventing all of the concurrency that it should
be. hwmon is a per-device concept (all information is always read from
the root tile's MMIO interface).
In both cases, these seem to be artifacts of the larger driver
(mis)design where 'gt' is used as the target for MMIO operations.
There's a much larger driver-wide refactor coming to address that, but
let's start by fixing up these two components in preparation.
Matt Roper (2):
drm/xe/pcode: Treat pcode as per-tile rather than per-GT
drm/xe/hwmon: Treat hwmon as a per-device concept
.../drm/xe/compat-i915-headers/intel_pcode.h | 8 +-
.../drm/xe/compat-i915-headers/intel_uncore.h | 7 ++
drivers/gpu/drm/xe/xe_device_types.h | 6 +
drivers/gpu/drm/xe/xe_gt.c | 2 -
drivers/gpu/drm/xe/xe_gt_types.h | 6 -
drivers/gpu/drm/xe/xe_guc_pc.c | 2 +-
drivers/gpu/drm/xe/xe_hwmon.c | 95 +++++++++-------
drivers/gpu/drm/xe/xe_pcode.c | 104 +++++++++---------
drivers/gpu/drm/xe/xe_pcode.h | 16 +--
drivers/gpu/drm/xe/xe_tile.c | 3 +
drivers/gpu/drm/xe/xe_vram_freq.c | 6 +-
11 files changed, 136 insertions(+), 119 deletions(-)
--
2.45.2
next reply other threads:[~2024-08-29 22:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 22:06 Matt Roper [this message]
2024-08-29 22:06 ` [PATCH 1/2] drm/xe/pcode: Treat pcode as per-tile rather than per-GT Matt Roper
2024-08-30 14:08 ` Lucas De Marchi
2024-08-29 22:06 ` [PATCH 2/2] drm/xe/hwmon: Treat hwmon as a per-device concept Matt Roper
2024-08-30 14:14 ` Lucas De Marchi
2024-08-29 22:12 ` ✓ CI.Patch_applied: success for Remove falsely GT-centric design in pcode and hwmon Patchwork
2024-08-29 22:12 ` ✓ CI.checkpatch: " Patchwork
2024-08-29 22:13 ` ✓ CI.KUnit: " Patchwork
2024-08-29 22:30 ` ✓ CI.Build: " Patchwork
2024-08-29 22:35 ` ✓ CI.Hooks: " Patchwork
2024-08-29 22:37 ` ✓ CI.checksparse: " Patchwork
2024-08-29 22:55 ` ✓ CI.BAT: " Patchwork
2024-08-30 13:22 ` ✗ CI.FULL: failure " Patchwork
2024-08-30 16:02 ` Matt Roper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240829220619.789159-4-matthew.d.roper@intel.com \
--to=matthew.d.roper@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox