Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] Remove falsely GT-centric design in pcode and hwmon
@ 2024-08-29 22:06 Matt Roper
  2024-08-29 22:06 ` [PATCH 1/2] drm/xe/pcode: Treat pcode as per-tile rather than per-GT Matt Roper
                   ` (9 more replies)
  0 siblings, 10 replies; 14+ messages in thread
From: Matt Roper @ 2024-08-29 22:06 UTC (permalink / raw)
  To: intel-xe; +Cc: matthew.d.roper

Both the pcode and the hwmon code was using a GT-centric design, even
though these are not GT-level concepts in the hardware.  Pcode has a
single instance per tile, and using a GT-centric design means that that
locking isn't actually preventing all of the concurrency that it should
be.  hwmon is a per-device concept (all information is always read from
the root tile's MMIO interface).

In both cases, these seem to be artifacts of the larger driver
(mis)design where 'gt' is used as the target for MMIO operations.
There's a much larger driver-wide refactor coming to address that, but
let's start by fixing up these two components in preparation.


Matt Roper (2):
  drm/xe/pcode: Treat pcode as per-tile rather than per-GT
  drm/xe/hwmon: Treat hwmon as a per-device concept

 .../drm/xe/compat-i915-headers/intel_pcode.h  |   8 +-
 .../drm/xe/compat-i915-headers/intel_uncore.h |   7 ++
 drivers/gpu/drm/xe/xe_device_types.h          |   6 +
 drivers/gpu/drm/xe/xe_gt.c                    |   2 -
 drivers/gpu/drm/xe/xe_gt_types.h              |   6 -
 drivers/gpu/drm/xe/xe_guc_pc.c                |   2 +-
 drivers/gpu/drm/xe/xe_hwmon.c                 |  95 +++++++++-------
 drivers/gpu/drm/xe/xe_pcode.c                 | 104 +++++++++---------
 drivers/gpu/drm/xe/xe_pcode.h                 |  16 +--
 drivers/gpu/drm/xe/xe_tile.c                  |   3 +
 drivers/gpu/drm/xe/xe_vram_freq.c             |   6 +-
 11 files changed, 136 insertions(+), 119 deletions(-)

-- 
2.45.2


^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2024-08-30 16:02 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-29 22:06 [PATCH 0/2] Remove falsely GT-centric design in pcode and hwmon Matt Roper
2024-08-29 22:06 ` [PATCH 1/2] drm/xe/pcode: Treat pcode as per-tile rather than per-GT Matt Roper
2024-08-30 14:08   ` Lucas De Marchi
2024-08-29 22:06 ` [PATCH 2/2] drm/xe/hwmon: Treat hwmon as a per-device concept Matt Roper
2024-08-30 14:14   ` Lucas De Marchi
2024-08-29 22:12 ` ✓ CI.Patch_applied: success for Remove falsely GT-centric design in pcode and hwmon Patchwork
2024-08-29 22:12 ` ✓ CI.checkpatch: " Patchwork
2024-08-29 22:13 ` ✓ CI.KUnit: " Patchwork
2024-08-29 22:30 ` ✓ CI.Build: " Patchwork
2024-08-29 22:35 ` ✓ CI.Hooks: " Patchwork
2024-08-29 22:37 ` ✓ CI.checksparse: " Patchwork
2024-08-29 22:55 ` ✓ CI.BAT: " Patchwork
2024-08-30 13:22 ` ✗ CI.FULL: failure " Patchwork
2024-08-30 16:02   ` Matt Roper

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox