From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: <intel-xe@lists.freedesktop.org>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Lucas De Marchi <lucas.demarchi@intel.com>,
Jonathan Cavitt <jonathan.cavitt@intel.com>
Subject: [PATCH] drm/xe: Restore pci state upon resume
Date: Thu, 12 Sep 2024 17:45:07 -0400 [thread overview]
Message-ID: <20240912214507.456897-1-rodrigo.vivi@intel.com> (raw)
The pci state was saved, but not restored. Restore
right after the power state transition request like
every other driver.
v2: Use right fixes tag, since this was there initialy, but
accidentally removed.
Fixes: f6761c68c0ac ("drm/xe/display: Improve s2idle handling.")
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
drivers/gpu/drm/xe/xe_pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
index 5ba4ec229494..6d29ef4b396f 100644
--- a/drivers/gpu/drm/xe/xe_pci.c
+++ b/drivers/gpu/drm/xe/xe_pci.c
@@ -949,6 +949,8 @@ static int xe_pci_resume(struct device *dev)
if (err)
return err;
+ pci_restore_state(pdev);
+
err = pci_enable_device(pdev);
if (err)
return err;
--
2.46.0
next reply other threads:[~2024-09-12 21:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-12 21:45 Rodrigo Vivi [this message]
2024-09-12 21:50 ` ✓ CI.Patch_applied: success for drm/xe: Restore pci state upon resume (rev2) Patchwork
2024-09-12 21:50 ` ✓ CI.checkpatch: " Patchwork
2024-09-12 21:52 ` ✓ CI.KUnit: " Patchwork
2024-09-12 22:03 ` ✓ CI.Build: " Patchwork
2024-09-12 22:06 ` ✓ CI.Hooks: " Patchwork
2024-09-12 22:07 ` ✓ CI.checksparse: " Patchwork
2024-09-12 22:25 ` ✓ CI.BAT: " Patchwork
2024-09-13 14:41 ` ✓ CI.FULL: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2024-09-12 19:05 [PATCH] drm/xe: Restore pci state upon resume Rodrigo Vivi
2024-09-12 19:47 ` Cavitt, Jonathan
2024-09-12 20:11 ` Lucas De Marchi
2024-09-12 21:20 ` Rodrigo Vivi
2024-09-12 21:40 ` Lucas De Marchi
2024-09-17 21:37 ` Maarten Lankhorst
2024-09-13 11:01 ` Ville Syrjälä
2024-09-13 15:43 ` Rodrigo Vivi
2024-09-13 15:50 ` Gupta, Anshuman
2024-09-13 16:54 ` Ville Syrjälä
2024-09-17 18:49 ` Rodrigo Vivi
2024-09-17 21:09 ` Ville Syrjälä
2024-09-19 22:10 ` Rodrigo Vivi
2024-09-20 10:19 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240912214507.456897-1-rodrigo.vivi@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=jonathan.cavitt@intel.com \
--cc=lucas.demarchi@intel.com \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox