Re: [PATCH] drm/xe: Restore pci state upon resume

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Thu, Sep 12, 2024 at 03:05:30PM -0400, Rodrigo Vivi wrote:
> The pci state was saved, but not restored. Restore
> right after the power state transition request like
> every other driver.
> 
> Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_pci.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
> index 5ba4ec229494..6d29ef4b396f 100644
> --- a/drivers/gpu/drm/xe/xe_pci.c
> +++ b/drivers/gpu/drm/xe/xe_pci.c
> @@ -949,6 +949,8 @@ static int xe_pci_resume(struct device *dev)
>  	if (err)
>  		return err;
>  
> +	pci_restore_state(pdev);

Why is xe even doing this stuff by hand instead of letting
the pci core handle it?

> +
>  	err = pci_enable_device(pdev);
>  	if (err)
>  		return err;
> -- 
> 2.46.0

-- 
Ville Syrjälä
Intel