Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe: Restore pci state upon resume
@ 2024-09-12 19:05 Rodrigo Vivi
  2024-09-12 19:47 ` Cavitt, Jonathan
                   ` (10 more replies)
  0 siblings, 11 replies; 23+ messages in thread
From: Rodrigo Vivi @ 2024-09-12 19:05 UTC (permalink / raw)
  To: intel-xe; +Cc: Rodrigo Vivi

The pci state was saved, but not restored. Restore
right after the power state transition request like
every other driver.

Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/xe_pci.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
index 5ba4ec229494..6d29ef4b396f 100644
--- a/drivers/gpu/drm/xe/xe_pci.c
+++ b/drivers/gpu/drm/xe/xe_pci.c
@@ -949,6 +949,8 @@ static int xe_pci_resume(struct device *dev)
 	if (err)
 		return err;
 
+	pci_restore_state(pdev);
+
 	err = pci_enable_device(pdev);
 	if (err)
 		return err;
-- 
2.46.0


^ permalink raw reply related	[flat|nested] 23+ messages in thread
* [PATCH] drm/xe: Restore pci state upon resume
@ 2024-09-12 21:45 Rodrigo Vivi
  0 siblings, 0 replies; 23+ messages in thread
From: Rodrigo Vivi @ 2024-09-12 21:45 UTC (permalink / raw)
  To: intel-xe
  Cc: Rodrigo Vivi, Maarten Lankhorst, Lucas De Marchi, Jonathan Cavitt

The pci state was saved, but not restored. Restore
right after the power state transition request like
every other driver.

v2: Use right fixes tag, since this was there initialy, but
    accidentally removed.

Fixes: f6761c68c0ac ("drm/xe/display: Improve s2idle handling.")
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/xe_pci.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
index 5ba4ec229494..6d29ef4b396f 100644
--- a/drivers/gpu/drm/xe/xe_pci.c
+++ b/drivers/gpu/drm/xe/xe_pci.c
@@ -949,6 +949,8 @@ static int xe_pci_resume(struct device *dev)
 	if (err)
 		return err;
 
+	pci_restore_state(pdev);
+
 	err = pci_enable_device(pdev);
 	if (err)
 		return err;
-- 
2.46.0


^ permalink raw reply related	[flat|nested] 23+ messages in thread

end of thread, other threads:[~2024-09-20 10:19 UTC | newest]

Thread overview: 23+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-12 19:05 [PATCH] drm/xe: Restore pci state upon resume Rodrigo Vivi
2024-09-12 19:47 ` Cavitt, Jonathan
2024-09-12 20:05 ` ✓ CI.Patch_applied: success for " Patchwork
2024-09-12 20:05 ` ✓ CI.checkpatch: " Patchwork
2024-09-12 20:07 ` ✓ CI.KUnit: " Patchwork
2024-09-12 20:11 ` [PATCH] " Lucas De Marchi
2024-09-12 21:20   ` Rodrigo Vivi
2024-09-12 21:40     ` Lucas De Marchi
2024-09-17 21:37       ` Maarten Lankhorst
2024-09-12 20:18 ` ✓ CI.Build: success for " Patchwork
2024-09-12 20:21 ` ✓ CI.Hooks: " Patchwork
2024-09-12 20:22 ` ✓ CI.checksparse: " Patchwork
2024-09-12 20:37 ` ✓ CI.BAT: " Patchwork
2024-09-13 11:01 ` [PATCH] " Ville Syrjälä
2024-09-13 15:43   ` Rodrigo Vivi
2024-09-13 15:50     ` Gupta, Anshuman
2024-09-13 16:54     ` Ville Syrjälä
2024-09-17 18:49       ` Rodrigo Vivi
2024-09-17 21:09         ` Ville Syrjälä
2024-09-19 22:10           ` Rodrigo Vivi
2024-09-20 10:19             ` Ville Syrjälä
2024-09-13 14:10 ` ✗ CI.FULL: failure for " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2024-09-12 21:45 [PATCH] " Rodrigo Vivi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox