Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: bnilawar <badal.nilawar@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: anshuman.gupta@intel.com, john.c.harrison@intel.com
Subject: [[CI] 11/12] drm/xe/guc: Add a helper function for dumping GuC log to dmesg
Date: Fri, 20 Sep 2024 19:36:45 +0530	[thread overview]
Message-ID: <20240920140646.618008-12-badal.nilawar@intel.com> (raw)
In-Reply-To: <20240920140646.618008-1-badal.nilawar@intel.com>

From: John Harrison <John.C.Harrison@Intel.com>

Create a helper function that can be used to dump the GuC log to dmesg
in a manner that is reliable for extraction and decode. The intention
is that calls to this can be added by developers when debugging
specific issues that require a GuC log but do not allow easy capture
of the log - e.g. failures in selftests and failues that lead to
kernel hangs.

Also note that this is really a temporary stop-gap. The aim is to
allow on demand creation and dumping of devcoredump captures (which
includes the GuC log and much more). Currently this is not possible as
much of the devcoredump code requires a 'struct xe_sched_job' and
those are not available at many places that might want to do the dump.

v2: Add kerneldoc - review feedback from Michal W.

Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
Reviewed-by: Julia Filipchuk <julia.filipchuk@intel.com>
---
 drivers/gpu/drm/xe/xe_guc_log.c | 18 ++++++++++++++++++
 drivers/gpu/drm/xe/xe_guc_log.h |  1 +
 2 files changed, 19 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_guc_log.c b/drivers/gpu/drm/xe/xe_guc_log.c
index 24564624e91e..d7be69f20af4 100644
--- a/drivers/gpu/drm/xe/xe_guc_log.c
+++ b/drivers/gpu/drm/xe/xe_guc_log.c
@@ -214,6 +214,24 @@ void xe_guc_log_snapshot_print(struct xe_guc_log_snapshot *snapshot, struct drm_
 	}
 }
 
+/**
+ * xe_guc_log_print_dmesg - dump a copy of the GuC log to dmesg
+ * @log: GuC log structure
+ */
+void xe_guc_log_print_dmesg(struct xe_guc_log *log)
+{
+	struct xe_gt *gt = log_to_gt(log);
+	static int g_count;
+	struct drm_printer ip = xe_gt_info_printer(gt);
+	struct drm_printer lp = drm_line_printer(&ip, "Capture", ++g_count);
+
+	drm_printf(&lp, "Dumping GuC log for %ps...\n", __builtin_return_address(0));
+
+	xe_guc_log_print(log, &lp);
+
+	drm_printf(&lp, "Done.\n");
+}
+
 /**
  * xe_guc_log_print - dump a copy of the GuC log to some useful location
  * @log: GuC log structure
diff --git a/drivers/gpu/drm/xe/xe_guc_log.h b/drivers/gpu/drm/xe/xe_guc_log.h
index 949d2c98343d..1fb2fae1f4e1 100644
--- a/drivers/gpu/drm/xe/xe_guc_log.h
+++ b/drivers/gpu/drm/xe/xe_guc_log.h
@@ -39,6 +39,7 @@ struct xe_device;
 
 int xe_guc_log_init(struct xe_guc_log *log);
 void xe_guc_log_print(struct xe_guc_log *log, struct drm_printer *p);
+void xe_guc_log_print_dmesg(struct xe_guc_log *log);
 struct xe_guc_log_snapshot *xe_guc_log_snapshot_capture(struct xe_guc_log *log, bool atomic);
 void xe_guc_log_snapshot_print(struct xe_guc_log_snapshot *snapshot, struct drm_printer *p);
 void xe_guc_log_snapshot_free(struct xe_guc_log_snapshot *snapshot);
-- 
2.34.1


  parent reply	other threads:[~2024-09-20 13:48 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-20 14:06 [[CI] 00/12] Debug g2h timeout issue bnilawar
2024-09-20 14:06 ` [[CI] 01/12] drm/xe/guc: Remove spurious line feed in debug print bnilawar
2024-09-20 14:06 ` [[CI] 02/12] drm/xe/devcoredump: Use drm_puts and already cached local variables bnilawar
2024-09-20 14:06 ` [[CI] 03/12] drm/xe/devcoredump: Improve section headings and add tile info bnilawar
2024-09-20 14:06 ` [[CI] 04/12] drm/xe/devcoredump: Add ASCII85 dump helper function bnilawar
2024-09-20 14:06 ` [[CI] 05/12] drm/xe/guc: Copy GuC log prior to dumping bnilawar
2024-09-20 14:06 ` [[CI] 06/12] drm/xe/guc: Use a two stage dump for GuC logs and add more info bnilawar
2024-09-20 14:06 ` [[CI] 07/12] drm/print: Introduce drm_line_printer bnilawar
2024-09-20 14:06 ` [[CI] 08/12] drm/xe/guc: Dead CT helper bnilawar
2024-09-20 14:06 ` [[CI] 09/12] drm/xe/guc: Dump entire CTB on errors bnilawar
2024-09-20 14:06 ` [[CI] 10/12] drm/xe/guc: Add GuC log to devcoredump captures bnilawar
2024-09-20 14:06 ` bnilawar [this message]
2024-09-20 14:06 ` [[CI] 12/12] [For CI] Debug prints/logs to debug G2H timeout issue bnilawar
2024-09-20 14:43 ` ✓ CI.Patch_applied: success for 10/12] drm/xe/guc: Add GuC log to devcoredump captures Patchwork
2024-09-20 14:43 ` ✓ CI.checkpatch: " Patchwork
2024-09-20 14:44 ` ✓ CI.KUnit: " Patchwork
2024-09-20 14:56 ` ✓ CI.Build: " Patchwork
2024-09-20 14:58 ` ✓ CI.Hooks: " Patchwork
2024-09-20 15:00 ` ✓ CI.checksparse: " Patchwork
2024-09-20 15:18 ` ✓ CI.BAT: " Patchwork
2024-09-20 20:37 ` ✗ CI.FULL: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2024-09-20 14:29 [CI 00/12] Debug g2h timeout issue Badal Nilawar
2024-09-20 14:29 ` [CI 11/12] drm/xe/guc: Add a helper function for dumping GuC log to dmesg Badal Nilawar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240920140646.618008-12-badal.nilawar@intel.com \
    --to=badal.nilawar@intel.com \
    --cc=anshuman.gupta@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=john.c.harrison@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox